From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Justin Pryzby <pryzby@telsasoft.com>,
        Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Peter Eisentraut <peter@eisentraut.org>,
        Soumyadeep Chakraborty <soumyadeep2007@gmail.com>,
        Zhihong Yu <zyu@yugabyte.com>, pgsql-hackers@postgresql.org,
        Ashwin Agrawal <ashwinstar@gmail.com>, vanjared@vmware.com,
        Alexander Lakhin <exclusion@gmail.com>
Subject: Re: ALTER TABLE SET ACCESS METHOD on partitioned tables
In-reply-to: <ZoNVg33etJOKmCeL@paquier.xyz>
References: <202403261105.6o4ff4d6qagc@alvherre.pgsql> <202403211207.hfyirjweshbh@alvherre.pgsql> <ZgNSQraRJ4vWe6KI@pryzbyj2023> <ZkyivySXnbvOogZz@pryzbyj2023> <ZmEGMz7TC8SOIUpn@paquier.xyz> <ZoNId8GifUS4TlgG@paquier.xyz> <2969207.1719880817@sss.pgh.pa.us> <ZoNVg33etJOKmCeL@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Tue, 02 Jul 2024 10:18:59 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2974876.1719883784.1@sss.pgh.pa.us>
Date: Mon, 01 Jul 2024 21:29:44 -0400
Message-ID: <2974877.1719883784@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/2974877.1719883784%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Mon, Jul 01, 2024 at 08:40:17PM -0400, Tom Lane wrote:
>> While this won't actually fail against a v10 or v11 server, it won't
>> show anything useful either (because relam is zero for heaps in
>> pre-v12 versions).  Perhaps there should be a check to only add the
>> extra column if server >= v12?

> I've thought about that and would be OK to restrict things with this
> suggestion if you'd prefer it.  However, I could not decide in favor
> of it as using a psql \dP+ >= v18 gives the possibility to show the
> AMs of partitioned indexes, as these are also part listed in \dP.  So
> I've found that useful in itself.

Ah, I'd forgotten that partitioned indexes are shown too.
Never mind then.

			regards, tom lane