From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Aleksander Alekseev <aleksander@timescale.com>,
        Michael Paquier <michael@paquier.xyz>,
        Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_stop_backup() v2 incorrectly marked as proretset
In-reply-to: <CA+Tgmoas049acSuXnvyZjbsGHDjE+uPnj5eNRLYd_yLxyHBVrw@mail.gmail.com>
References: <Yh8guT78f1Ercfzw@paquier.xyz> <20220302.172235.1181597714315490061.horikyota.ntt@gmail.com> <Yh9BIWEcWVZJUQm1@paquier.xyz> <CAJ7c6TO2rq3LTe_TsPgb8RWuAnxd-gs0qV7g6HACu21P9cTXEQ@mail.gmail.com> <CA+Tgmoas049acSuXnvyZjbsGHDjE+uPnj5eNRLYd_yLxyHBVrw@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Wed, 02 Mar 2022 09:31:49 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2976201.1646231744.1@sss.pgh.pa.us>
Date: Wed, 02 Mar 2022 09:35:44 -0500
Message-ID: <2976202.1646231744@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/2976202.1646231744%40sss.pgh.pa.us>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Mar 2, 2022 at 5:25 AM Aleksander Alekseev
> <aleksander@timescale.com> wrote:
>> Declaring a macro inside the procedure body is a bit unconventional.
>> Since it doesn't seem to be used for anything except these two array
>> declarations I suggest keeping simply "3" here.

> I think we do this kind of thing in various places in similar
> situations, and I think it is good style. It makes it easier to catch
> everything if you ever need to update the code.

Yeah, there's plenty of precedent for that coding if you look around.
I've not read the whole patch, but this snippet seems fine to me
if there's also an #undef at the end of the function.

			regards, tom lane