From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jim Jones <jim.jones@uni-muenster.de>
cc: Ken Kato <katouknl@oss.nttdata.com>, pgsql-hackers@lists.postgresql.org
Subject: Re: Tab completion for GRANT MAINTAIN
In-reply-to: <a8ae0f8b-8ecb-a3f5-0c1b-bcb4bda1c80a@uni-muenster.de>
References: <6afe7712991882a864d6d10003264e7c@oss.nttdata.com>
 <a8ae0f8b-8ecb-a3f5-0c1b-bcb4bda1c80a@uni-muenster.de>
Comments: In-reply-to Jim Jones <jim.jones@uni-muenster.de>
	message dated "Wed, 19 Apr 2023 13:50:30 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2977469.1681916045.1@sss.pgh.pa.us>
Date: Wed, 19 Apr 2023 10:54:05 -0400
Message-ID: <2977470.1681916045@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2977470.1681916045%40sss.pgh.pa.us>
Precedence: bulk

Jim Jones <jim.jones@uni-muenster.de> writes:
> On 18.04.23 11:08, Ken Kato wrote:
>> I found that GRANT MAINTAIN is not tab-completed with ON, so here is a 
>> patch.

> I've marked the CF entry as "ready for committer"

Yup, clearly an oversight.  Pushed.

(One could wish that it didn't take touching three or so places in
tab-complete.c to add a privilege, especially when a naive hacker might
think he was done after touching Privilege_options_of_grant_and_revoke.
I didn't see any easy way to improve that situation though.)

			regards, tom lane