Received: from maia.hub.org (maia-2.hub.org [200.46.204.251]) by mail.postgresql.org (Postfix) with ESMTP id 145E91337B5C for ; Sat, 22 Jan 2011 21:50:31 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.251]) (amavisd-maia, port 10024) with ESMTP id 12157-01 for ; Sun, 23 Jan 2011 01:50:24 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by mail.postgresql.org (Postfix) with ESMTP id B8DD4133616B for ; Sat, 22 Jan 2011 21:50:23 -0400 (AST) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id p0N1oKqP029791; Sat, 22 Jan 2011 20:50:20 -0500 (EST) To: Robert Haas cc: Greg Smith , Fujii Masao , Magnus Hagander , pgsql-hackers@postgresql.org Subject: Re: auto-sizing wal_buffers In-reply-to: References: <20767.1294964709@sss.pgh.pa.us> <4D314406.3000703@2ndquadrant.com> <4D31D0E4.9000108@2ndquadrant.com> <11561.1295742146@sss.pgh.pa.us> <29279.1295746434@sss.pgh.pa.us> Comments: In-reply-to Robert Haas message dated "Sat, 22 Jan 2011 20:45:02 -0500" Date: Sat, 22 Jan 2011 20:50:20 -0500 Message-ID: <29790.1295747420@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-1.91 tagged_above=-5 required=5 tests=BAYES_00=-1.9, T_RP_MATCHES_RCVD=-0.01 X-Spam-Level: X-Archive-Number: 201101/2192 X-Sequence-Number: 180029 Robert Haas writes: >> As penance, I've committed the corrected patch. > Which is obviously derived from my version rather than Greg's, without credit. Apologies --- I thought I'd ended up reverting basically all your changes, so I just credited him. regards, tom lane