MIME-Version: 1.0
Date: Fri, 27 Dec 2024 12:08:12 +0300
From: Vladlen Popolitov <v.popolitov@postgrespro.ru>
To: "Kohei Harikae (Fujitsu)" <harikae.kohei@fujitsu.com>
Cc: 'Andres Freund' <andres@anarazel.de>,
 "'pgsql-hackers@lists.postgresql.org'" <pgsql-hackers@lists.postgresql.org>
Subject: Re: Windows meson build
In-Reply-To: <2fe1080dc2f42e2510b810d84eee45bd@postgrespro.ru>
References: <TYVPR01MB113306AB19264E89AD360A40EE4522@TYVPR01MB11330.jpnprd01.prod.outlook.com>
 <gjqvs4lcv5mpl7io2dzm2jantxenavljs5437kjlhjk4lmxzep@ahia6adaioc2>
 <TYVPR01MB11330FC4B949E05FE6A0F437CE4052@TYVPR01MB11330.jpnprd01.prod.outlook.com>
 <3fadfb663c69bae7448797acfa47c2ba@postgrespro.ru>
 <TYVPR01MB1133078C93F9FE432CA466573E40E2@TYVPR01MB11330.jpnprd01.prod.outlook.com>
 <2fe1080dc2f42e2510b810d84eee45bd@postgrespro.ru>
Message-ID: <29790e2f24e3579296e4a296ff8825a8@postgrespro.ru>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/29790e2f24e3579296e4a296ff8825a8%40postgrespro.ru>
Precedence: bulk

Vladlen Popolitov писал(а) 2024-12-27 09:57:
> Kohei Harikae (Fujitsu) писал(а) 2024-12-27 04:31:
>> Hi,
>> 
>> Thank you for your advice.
>> I added a sample setting PKG_CONFIG_PATH based on your advice.
>> 
>> How do you think about this?
>> 
>> Regards,
>> Kohei Harikae
>> 
> 
> Hi,
> From my point of view it looks good. Actual information is added,
> excessive information is removed.
> I think in the phrase:
> "add the directory where the .pc file resides to PKG_CONFIG_PATH."
> better to add wording, that PKG_CONFIG_PATH is the list of directories 
> separated
> by PATH separator ( ; in Windows, : in POSIX). Otherwise the reader has 
> to
> search additional information about this variable in meson 
> documentation.

Hi

I think, it is better to add the other options how to configure external
libraries, if they do not have .pc file:
add meson options defined by PostgreSQL for its configuration (gettext 
library example)
  
-Dextra_include_dirs=c:\postgres\gettext\x64-windows\include,c:\otherlibs\include
  -Dextra_lib_dirs=c:\postgres\gettext\x64-windows\lib,c:\otherlibs\lib

extra_include_dirs and extra_lib_dirs are options defined by PostgreSQL. 
This options are
comma separated lists of directories, if every value does not contain 
comma itself.


-- 
Best regards,

Vladlen Popolitov.