Message-ID: <297b82a297fa9c889354d59c3c6f989e1dbb6302.camel@cybertec.at>
Subject: Re: Incremental backup from a streaming replication standby fails
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Robert Haas <robertmhaas@gmail.com>
Cc: David Steele <david@pgmasters.net>, pgsql-hackers@postgresql.org
Date: Sat, 20 Jul 2024 00:07:36 +0200
In-Reply-To: <CA+TgmoaFVjaN-JRvBA04pp+cZ5XjYuzofVbDBMyvMhVNiS23XQ@mail.gmail.com>
References: <04f4277e5ed4046773e46837110bed1381a2583f.camel@cybertec.at>
	 <5468641ad821dad7aa3b2d65bf843146443a1b68.camel@cybertec.at>
	 <CA+TgmobToSs9DNynYA-iQt9m5zVAnyDCbfwGwcmEOA5zecPk4w@mail.gmail.com>
	 <a4391db7-d308-4814-ba6b-7c4e5ed59dc6@pgmasters.net>
	 <CA+TgmoZ2FrKX6WaDd8M-zqzR9Hr7bsVFOwo5ydCbeiSYz-2NdQ@mail.gmail.com>
	 <985825083da240ef8f3e32e2f49fc93fe1aeac7e.camel@cybertec.at>
	 <CA+TgmoaFVjaN-JRvBA04pp+cZ5XjYuzofVbDBMyvMhVNiS23XQ@mail.gmail.com>
Autocrypt: addr=laurenz.albe@cybertec.at; prefer-encrypt=mutual; keydata=mQINBGGDwAQBEADgbWy5cKXQld3N2mF+DFyiNFbi2oBl2T+XgxpPF8wTRw2D/u4bBKXP0SYSE/lA86jIVNWWU0gf1KODIkVvgJm2w4vH2VBV1b7ddVViGl1Iu+9zaRnv9wulhnH42KefepXnoean6UT1EzLM0opF/Ik0j+40TxdRtobkBprkQUyHDXWlHc2ffPs3SipyFEP9AVLf7ejRC46CXWDnsqjOBSMEW8Z4HiK/8RrPZBsKLts8dJxKF4pygOdJb0CWk8k/X1jbcfdxo+zOLjOMvJcSJ2pFdJmQHU+JufB3rePziqQ2S9Ur6sccr9XnTC1GVBWN4Lf5VHq+vf+bFJjVwg+2hrySZnAVfcOrxoqFLErr7ug1zN2nM1kcpgA4VWn4gxlJtYNYYq+9WxX5dtvnNANlG3ZCrRKQzl8lxtzoF6Zo7LUhEqPaHDwn7Rvs+IdbOn41lF5UDTJGqmC4gS/bZydW2Fy3YWm4aSaN9fgFf8D+PVkrlKAZB7gBLz1TyHjbcRf85cYF+GKKrDld5SzMB/V60VX3oP/Eo8ikFpyWaqiz1f9X7MBot3/PjJkY+wDzp3nmb19QEcOBuQiSQ4xds2r0HewbuHTAR68u8jNNMGmpm2j4x+g09Jd/WQDjqlTBZ/jEltH41fYCCPWMfljXTOOXu2eLNGdfi7ETZogtwjM9oTtSPQARAQABtCdMYXVyZW56IEFsYmUgPGxhdXJlbnouYWxiZUBjeWJlcnRlYy5hdD6JAk4EEwEIADgWIQR0CqhbZGGABqoaSbdi8bhXA2EdmAUCYYPABAIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRBi8bhXA2EdmM/6EADK232JCwmBzhlj8h7U9CjG6kx0JHP3uJGv+XfsHtHAlmY/RCwF1BHMEsRlk
 bT5UrLvJ2jb99bA9QARzhFaxzyn0F/BUKzuIjRGNs/n6d5dNUFA0kOt8sX+TacmC GEyjEBCrVCm4ranBiUyePn9NhHNWnaex7pJyqvMLLdwW9BEMJx0Fqo+DN8ukbXmYRsmhEtd3ue+x/luYmOmJnaGtzInaY5aOJYbW9XqoRIZkZvOCgbi1FfvNmoqWa+3oVxTOgw9RafjJDyW0lTHzKGjbGI5ofMU98l+/hKJFYJqWUF6VpFJY5YIcN/1lf4ZICMwDl+MPIVo/tpq8L10seJL28nLlvw3K+cI+TVW8IW/qL/LyVoDofI3USeOORuYmhpWRhik8JXX6xf3v6GrRilJIPWNFIJbxm1ZblQiQnOw3IOW7T+8nAmPin1HKqM3VrOrJQ2VtShsefNBibNAsr1oFaqcDBkn3yGG8i6CTW+FyO4PZ+/EwNxMVgktxbYdy5AT1/lpXr5tB+phhLIyVfiBvrWs5EThxYMQ/L8Y85c3GMsAy1l/x4h3jqySIYy3SCU9+jc5UVuNnXljbvkEzJ+NLWJ6C1rACFWrMszgPdh5tCrlRY9PpmYll4JbCgb8BtxEIUmR+xr50/ZElEK5iml7Q00KUekCcDt+36PsyGFTXBzNOrkCDQRhg8AEARAAzOZ2tLHlI4rrhG411h6cdCFjBZxuljaFCxFyHn3m6wbGLqwBUWC5k8UrRqjHMz88KcTSaNO7XGAmCqPdWd2SeflPZRnNTbjsVpw7mLdffsBm4JX7kki2Pvk5h0NtYeidXT1PSpc2ri4DutYXuT9uD8RAm1wUDCE5HQNUihT/WH6opt+hskHW21uHao0+y822tG0QQcGMqdQR5Vxdxj89wiEPdqW+HpU/oOZIhrf2E7prduAppxixjHy/o1rcnoznnJvc8D3+YgI9O0LrBMij89dM55pRGbLovTR1oGR3U74sX774+0xmSzeIKwZfiMUz7Atlvfk5SHOsRUFPN2Ux9kaXiiBibQpHFxt7b
 lDrT4wxdLJ/XCdbPPAyl+lZtOLsaHEEZvYNyTXwZc35dVf3R4/oz20HoG6s7ct8e1 AQygj43XAERzty9SkWgxs8+grp1PrGx6FHVSYRqBM8dS/ZR6yRVwOwJXPyaSSqfIF21DkE4j1y4n+ItSewPGoRp8K/yWCikt6qlkVkO2ASNIiX04fAbtzwVOaNn8ZMRNqyvLc1fED4sr49onE4cAIcBLjcC3KL+w9DUGRQCdziROj5H2Yl/sXGPdMciUHo/Uz2rggc+2th3bQiMhrHWSsBpUkDQp0yWewemstPpPgBL3h2fHKaX8B9oH5Qu/H1IgrOuX8AEQEAAYkCNgQYAQgAIBYhBHQKqFtkYYAGqhpJt2LxuFcDYR2YBQJhg8AEAhsMAAoJEGLxuFcDYR2YuPwQAMkpGtR80pQ1gVsONhdkqj0H2eU66efP/gO3CoyaoIcvrpKYj7C2HipVSmkt1gpByL0X4AMQ/vKuknUz3wd28Ba+G1dCfbVs/Xiusq+SmpUj5rTwmYqdSjWMuCo1R6oS5hdJMdUUJYGMT0QkVlm1KnW8jkmCTl9GzjDxOAsN9O6/6lPzaGFtk9XF+34Bry/N4HKiJkqpC4+UTd0AprPfzJ2jdT64e1F0+W88X8y1bTTgNrHwK4mDiLnlE4SKRuEm54lNhJz//ar86Or5BErzNpM6TL7lk44QS06hwsMrEdKIy8J/SYJPjfzR8tIUnKscclVpOgjKaBqC+0iFiVaRqAgfOlIEiezX6kMh5Q2FIUfqs46qWhhXjRrdKOEoStYAaikdLu5ZXr7vfb0ZaDh+ZwTQtbSMFolyOkecwI81MCdbMfT/1TqIGTOdAj5as9fAakk0jb2pXgUYQ8X1DVTR8ahSDVEaw9VTmWiSvTxvguVJ1Mb7gG4Gmh6aviDTJhfXtH4rPUNXhDLqrTH8JkJjyKROOMakIF68Hjse5vUfUxreBEOtb5r1Coa2Fe7ncJayaSE7ryrDbFqpZ
 36UMAx4ulWMyqJajLNGY0DdG8qIsR5nxRhrnK/mrCidZ8F9/D3bWAl4rjtHlsztN59 +AnW5l0HsQcY9ntFL/zEBOaonjdJf
Content-Type: multipart/mixed; boundary="=-jvFPmQMRH+JnV9tBUOkx"
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/297b82a297fa9c889354d59c3c6f989e1dbb6302.camel%40cybertec.at>
Precedence: bulk

--=-jvFPmQMRH+JnV9tBUOkx
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2024-07-19 at 16:03 -0400, Robert Haas wrote:
> On Fri, Jul 19, 2024 at 2:41=E2=80=AFPM Laurenz Albe <laurenz.albe@cybert=
ec.at> wrote:
> > I'd be alright with the hint, but I'd say "during making an *incrementa=
l*
> > standby backup", because that's the only case where it can happen.
> >=20
> > I think it would also be sufficient if we document that possibility.
> > When I got the error, I looked at the documentation of incremental
> > backup for any limitations with standby servers, but didn't find any.
> > A remark in the documentation would have satisfied me.
>=20
> Would you like to propose a patch adding a hint and/or adjusting the
> documentation? Or are you wanting me to do that?

Here is a patch.
I went for both the errhint and some documentation.

Yours,
Laurenz Albe

--=-jvFPmQMRH+JnV9tBUOkx
Content-Disposition: attachment;
	filename*0=v1-0001-Add-documentation-and-hint-for-incremental-backup.pat;
	filename*1=ch
Content-Transfer-Encoding: base64
Content-Type: text/x-patch;
	name="v1-0001-Add-documentation-and-hint-for-incremental-backup.patch";
	charset="UTF-8"

RnJvbSBhNDZiMjNhZmM5MTliZmEwZDBhYTliZGFkOTYyYjk1YTNhZTQwN2VjIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBMYXVyZW56IEFsYmUgPGxhdXJlbnouYWxiZUBjeWJlcnRlYy5h
dD4KRGF0ZTogU2F0LCAyMCBKdWwgMjAyNCAwMDowNToyNiArMDIwMApTdWJqZWN0OiBbUEFUQ0gg
djFdIEFkZCBkb2N1bWVudGF0aW9uIGFuZCBoaW50IGZvciBpbmNyZW1lbnRhbCBiYWNrdXAgb24K
IHN0YW5kYnlzCgpUYWtpbmcgYW4gaW5jcmVtZW50YWwgYmFja3VwIG9uIGEgc3RyZWFtaW5nIHJl
cGxpY2F0aW9uIHN0YW5kYnkgaW1tZWRpYXRlbHkKYWZ0ZXIgYSBiYXNlIGJhY2t1cCBjYW4gcmVz
dWx0IGluIHRoZSBlcnJvcgoKICBtYW5pZmVzdCByZXF1aXJlcyBXQUwgZnJvbSBmaW5hbCB0aW1l
bGluZSBuIGVuZGluZyBhdCBYWFgsIGJ1dCB0aGlzIGJhY2t1cCBzdGFydHMgYXQgWVlZCgpUaGlz
IG1lc3NhZ2UgbG9va3Mgc2NhcnksIGV2ZW4gdGhvdWdoIHRoZSBvbmx5IHByb2JsZW0gaXMgdGhh
dCB0aGUgYmFja3VwCndvdWxkIGJlIGVtcHR5IGFuZCB0aHVzIGl0IG1ha2VzIG5vIHNlbnNlIHRv
IHRha2UgaXQgYW55d2F5LgoKQWRkIGEgY2xhcmlmeWluZyBlcnJoaW50IGFuZCBzb21lIGRvY3Vt
ZW50YXRpb24gdG8gbWl0aWdhdGUgdGhlIHByb2JsZW0uCgpBdXRob3I6IExhdXJlbnogQWxiZQpS
ZXZpZXdlZC1ieTogUm9iZXJ0IEhhYXMsIERhdmlkIFN0ZWVsZQpEaXNjdXNzaW9uOiBodHRwczov
L3Bvc3Rnci5lcy9tLzA0ZjQyNzdlNWVkNDA0Njc3M2U0NjgzNzExMGJlZDEzODFhMjU4M2YuY2Ft
ZWxAY3liZXJ0ZWMuYXQKCkJhY2twYXRjaCB0byB2MTcuCi0tLQogZG9jL3NyYy9zZ21sL2JhY2t1
cC5zZ21sICAgICAgICAgICAgICAgICAgICB8IDkgKysrKysrKysrCiBzcmMvYmFja2VuZC9iYWNr
dXAvYmFzZWJhY2t1cF9pbmNyZW1lbnRhbC5jIHwgMyArKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTEg
aW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9i
YWNrdXAuc2dtbCBiL2RvYy9zcmMvc2dtbC9iYWNrdXAuc2dtbAppbmRleCA5MWRhM2MyNmJhLi4w
Zjg0ZWJjMzZlIDEwMDY0NAotLS0gYS9kb2Mvc3JjL3NnbWwvYmFja3VwLnNnbWwKKysrIGIvZG9j
L3NyYy9zZ21sL2JhY2t1cC5zZ21sCkBAIC05MjUsNiArOTI1LDE1IEBAIHRlc3QgISAtZiAvbW50
L3NlcnZlci9hcmNoaXZlZGlyLzAwMDAwMDAxMDAwMDAwQTkwMDAwMDA2NSAmYW1wOyZhbXA7IGNw
IHBnX3dhbC8wCiAgICAgdG8gbWFuYWdlLiBGb3IgYSBsYXJnZSBkYXRhYmFzZSBhbGwgb2Ygd2hp
Y2ggaXMgaGVhdmlseSBtb2RpZmllZCwKICAgICBpbmNyZW1lbnRhbCBiYWNrdXBzIHdvbid0IGJl
IG11Y2ggc21hbGxlciB0aGFuIGZ1bGwgYmFja3Vwcy4KICAgIDwvcGFyYT4KKworICAgPHBhcmE+
CisgICAgTGlrZSBhIGJhc2UgYmFja3VwLCB5b3UgY2FuIHRha2UgYW4gaW5jcmVtZW50YWwgYmFj
a3VwIGZyb20gYSBzdHJlYW1pbmcKKyAgICByZXBsaWNhdGlvbiBzdGFuZGJ5IHNlcnZlci4gIEJ1
dCBzaW5jZSBhIGJhY2t1cCBvZiBhIHN0YW5kYnkgc2VydmVyIGNhbm5vdAorICAgIGluaXRpYXRl
IGEgY2hlY2twb2ludCwgaXQgaXMgcG9zc2libGUgdGhhdCBhbiBpbmNyZW1lbnRhbCBiYWNrdXAg
dGFrZW4KKyAgICByaWdodCBhZnRlciBhIGJhc2UgYmFja3VwIHdpbGwgZmFpbCB3aXRoIGFuIGVy
cm9yLCBzaW5jZSBpdCB3b3VsZCBoYXZlCisgICAgdG8gc3RhcnQgd2l0aCB0aGUgc2FtZSBjaGVj
a3BvaW50IGFzIHRoZSBiYXNlIGJhY2t1cCBhbmQgd291bGQgdGhlcmVmb3JlCisgICAgYmUgZW1w
dHkuCisgICA8L3BhcmE+CiAgIDwvc2VjdDI+CiAKICAgPHNlY3QyIGlkPSJiYWNrdXAtbG93bGV2
ZWwtYmFzZS1iYWNrdXAiPgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvYmFja3VwL2Jhc2ViYWNr
dXBfaW5jcmVtZW50YWwuYyBiL3NyYy9iYWNrZW5kL2JhY2t1cC9iYXNlYmFja3VwX2luY3JlbWVu
dGFsLmMKaW5kZXggMjEwODcwMjM5Ny4uODVjMTYxODJhNiAxMDA2NDQKLS0tIGEvc3JjL2JhY2tl
bmQvYmFja3VwL2Jhc2ViYWNrdXBfaW5jcmVtZW50YWwuYworKysgYi9zcmMvYmFja2VuZC9iYWNr
dXAvYmFzZWJhY2t1cF9pbmNyZW1lbnRhbC5jCkBAIC00NDEsNyArNDQxLDggQEAgUHJlcGFyZUZv
ckluY3JlbWVudGFsQmFja3VwKEluY3JlbWVudGFsQmFja3VwSW5mbyAqaWIsCiAJCQkJCQkgZXJy
bXNnKCJtYW5pZmVzdCByZXF1aXJlcyBXQUwgZnJvbSBmaW5hbCB0aW1lbGluZSAldSBlbmRpbmcg
YXQgJVgvJVgsIGJ1dCB0aGlzIGJhY2t1cCBzdGFydHMgYXQgJVgvJVgiLAogCQkJCQkJCQlyYW5n
ZS0+dGxpLAogCQkJCQkJCQlMU05fRk9STUFUX0FSR1MocmFuZ2UtPmVuZF9sc24pLAotCQkJCQkJ
CQlMU05fRk9STUFUX0FSR1MoYmFja3VwX3N0YXRlLT5zdGFydHBvaW50KSkpKTsKKwkJCQkJCQkJ
TFNOX0ZPUk1BVF9BUkdTKGJhY2t1cF9zdGF0ZS0+c3RhcnRwb2ludCkpLAorCQkJCQkJIGVycmhp
bnQoIlBlcmhhcHMgdGhlcmUgd2FzIHRvbyBsaXR0bGUgYWN0aXZpdHkgc2luY2UgdGhlIHByZXZp
b3VzIGJhY2t1cCwgYW5kIHRoaXMgaW5jcmVtZW50YWwgYmFja3VwIHdvdWxkIGJlIGVtcHR5LiIp
KSk7CiAJCX0KIAkJZWxzZQogCQl7Ci0tIAoyLjQ1LjIKCg==


--=-jvFPmQMRH+JnV9tBUOkx--