From: Tom Lane <tgl@sss.pgh.pa.us>
To: Magnus Hagander <magnus@hagander.net>
cc: Jelte Fennema <postgres@jeltef.nl>,
 Maciek Sakrejda <m.sakrejda@gmail.com>,
        Robert Haas <robertmhaas@gmail.com>, Peter Geoghegan <pg@bowt.ie>,
        Andres Freund <andres@anarazel.de>,
        Andrew Dunstan <andrew@dunslane.net>,
        Michael Paquier <michael@paquier.xyz>, shiy.fnst@fujitsu.com,
        Justin Pryzby <pryzby@telsasoft.com>, Noah Misch <noah@leadboat.com>,
        Bruce Momjian <bruce@momjian.us>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        Stephen Frost <sfrost@snowman.net>, Jesse Zhang <sbjesse@gmail.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: run pgindent on a regular basis / scripted manner
In-reply-to: 
 <CABUevEwxYwZNQ0uhcrCHSV2YGXRjeO25odc53thmAtZ5x4ZZpQ@mail.gmail.com>
References: 
 <CAGECzQTvfpkyyRoGscSuS7ySCEXOO1DCi3eztHQbGEDrj_nt4g@mail.gmail.com>
 <30a72ba4-9ca4-15b5-db0f-0e68cba7ab26@dunslane.net>
 <1f594a4b-14c8-e159-b250-edf8a091320d@dunslane.net>
 <CAH2-WznOKBQ3HvdwvyXHz18T2u-brkE5umDUic4B-2vtavJKqA@mail.gmail.com>
 <20230811212511.aih23qfthi24zhq4@awork3.anarazel.de>
 <CAH2-Wz=+23=O6iioUR_k9-mgUoX2kJPOWW5JdOXmd5dCtvinVg@mail.gmail.com>
 <338202.1691793002@sss.pgh.pa.us>
 <CAH2-Wz=TNXWQWFgZPehFyPo+9HxxwuHHHYA-ymR+W+kMChM+9Q@mail.gmail.com>
 <342032.1691794926@sss.pgh.pa.us>
 <8c4d8afb-cda1-299c-8011-f60cdaff3999@dunslane.net>
 <20230812211404.sydbwo2juu7vyhtg@awork3.anarazel.de>
 <530189.1691880417@sss.pgh.pa.us>
 <CAH2-Wz=OXmLbQ9ykYYSTmadD=fHtn7-ctCqsco7rc2s3Fvx8QQ@mail.gmail.com>
 <544112.1691886017@sss.pgh.pa.us>
 <CAH2-WzmueQvoZVScpUcAes3Gq_OGCnOH1RXyMicrMdyaAg6OLA@mail.gmail.com>
 <CAH2-WznZ4g8mrHCPVr5MBcSFenFnaKPp2K52JvqLt2fjdcR-bg@mail.gmail.com>
 <CA+TgmoYPycBvESpVkTsEEDrt8PbUnLR1SHSYOKzM_bnkd-UkfQ@mail.gmail.com>
 <CAGECzQR4Dqb4Rpm4N9LbdMKB9!
 1hHLVSEvHo5kcWSjLA5yy5LuA@mail.gmail.com>
 <CA+TgmoYxG2Y56Wzg36otfK-FDEGeNkSwtLQU6pbP3-ix6FcZJQ@mail.gmail.com>
 <2817272.1697559531@sss.pgh.pa.us>
 <CA+TgmoaczPbq6_SnUb4-Ou7VBHei9yTF-jxEdT=asb2w5u24CA@mail.gmail.com>
 <CAOtHd0Am-bRAvVmSkHj2Tux_WOsy2fAmGaOj0hjZUFcCm9a2Ug@mail.gmail.com>
 <CAGECzQRH8b6e3W6Mp=mA_81aaUCVoE-4z83HZZV-93EGRubLVQ@mail.gmail.com>
 <CABUevEwxYwZNQ0uhcrCHSV2YGXRjeO25odc53thmAtZ5x4ZZpQ@mail.gmail.com>
Comments: In-reply-to Magnus Hagander <magnus@hagander.net>
	message dated "Tue, 17 Oct 2023 23:01:38 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2984087.1697576866.1@sss.pgh.pa.us>
Date: Tue, 17 Oct 2023 17:07:46 -0400
Message-ID: <2984088.1697576866@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2984088.1697576866%40sss.pgh.pa.us>
Precedence: bulk

Magnus Hagander <magnus@hagander.net> writes:
> If it doesn't know how to rebuild it, aren't we going to be stuck in a
> catch-22 if we need to change it in certain ways? Since an old version
> of pg_bsd_indent would reject the patch that might include updating
> it. (And when it does, one should expect the push to take quite a long
> time, but given the infrequency I agree that part is probably not an
> issue)

Everyone who has proposed this has included a caveat that there must
be a way to override the check.  Given that minimal expectation, it
shouldn't be too hard to deal with pg_bsd_indent-updating commits.

			regards, tom lane