Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M330579=pgsql-hackers-arkari@postgresql.org>)
	id 1dPUUZ-00016t-Qs
	for pgsql-hackers@arkaria.postgresql.org; Mon, 26 Jun 2017 13:55:51 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
	by malur.postgresql.org with smtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M330579=pgsql-hackers-arkari@postgresql.org>)
	id 1dPUUY-00075Q-28
	for pgsql-hackers@arkaria.postgresql.org; Mon, 26 Jun 2017 13:55:50 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1dPUSy-0004Bu-Oc
	for pgsql-hackers@postgresql.org; Mon, 26 Jun 2017 13:54:12 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1dPUSv-000420-9t
	for pgsql-hackers@postgresql.org; Mon, 26 Jun 2017 13:54:11 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v5QDs4Vd029897;
	Mon, 26 Jun 2017 09:54:04 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Victor Drobny <v.drobny@postgrespro.ru>
cc: pgsql-hackers@postgresql.org
Subject: Re: A mistake in a comment
In-reply-to: <2b5382fdff9b1f79d5eb2c99c4d2cbe2@postgrespro.ru>
References: <2b5382fdff9b1f79d5eb2c99c4d2cbe2@postgrespro.ru>
Comments: In-reply-to Victor Drobny <v.drobny@postgrespro.ru>
	message dated "Mon, 26 Jun 2017 11:02:36 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <29895.1498485244.1@sss.pgh.pa.us>
Date: Mon, 26 Jun 2017 09:54:04 -0400
Message-ID: <29896.1498485244@sss.pgh.pa.us>
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Victor Drobny <v.drobny@postgrespro.ru> writes:
> I believe that I have found a mistake in a comment to 
> parse_phrase_operator function. The comment has the following line:
> a <X> b (distance is no greater than X)
> which is not. According to documentation and practical results, this 
> line should me changed on something like:
> a <X> b (distance is equal to X)

Ah, this comment got missed when we changed the definition of <N>.

> Patch in the attachments fixes the issue.

Will apply, thanks.  Looks to me like there's an outright bug here
as well: if errno happened to already be ERANGE when we reach the
strtol() call, the code will incorrectly report an error.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers