Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1raKGJ-009ELe-6L
	for pgsql-hackers@arkaria.postgresql.org; Wed, 14 Feb 2024 18:45:39 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1raKGH-0082SO-Lt
	for pgsql-hackers@arkaria.postgresql.org; Wed, 14 Feb 2024 18:45:37 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1raKGH-0082SG-Cb
	for pgsql-hackers@lists.postgresql.org; Wed, 14 Feb 2024 18:45:37 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1raKGE-006kf3-T8
	for pgsql-hackers@postgresql.org; Wed, 14 Feb 2024 18:45:36 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 41EIjVrj2991603;
	Wed, 14 Feb 2024 13:45:31 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Pavlo Golub" <pavlo.golub@cybertec.at>
cc: "Nathan Bossart" <nathandbossart@gmail.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Re[2]: [PATCH] allow pg_current_logfile() execution under pg_monitor role
In-reply-to: <emc45c00d1-1e68-48c3-84bf-91e6f75992ea@a2fcc9ff.com>
References: <CAK7ymcLmEYWyQkiCZ64WC-HCzXAB0omM=Ypj9B3rXe8vUAFMqw@mail.gmail.com> <20240209163657.GC663211@nathanxps13> <em6ad775cd-5e48-497f-9708-46f201400f23@52f0f93e.com> <20240212154945.GA1645880@nathanxps13> <20240213212928.GA262402@nathanxps13> <emc45c00d1-1e68-48c3-84bf-91e6f75992ea@a2fcc9ff.com>
Comments: In-reply-to "Pavlo Golub" <pavlo.golub@cybertec.at>
	message dated "Wed, 14 Feb 2024 18:05:41 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2991601.1707936331.1@sss.pgh.pa.us>
Date: Wed, 14 Feb 2024 13:45:31 -0500
Message-ID: <2991602.1707936331@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/2991602.1707936331%40sss.pgh.pa.us>
Precedence: bulk

"Pavlo Golub" <pavlo.golub@cybertec.at> writes:
> Oh, thanks! I forgot, indeed, to update docs and catalog version! My 
> bad!

Docs, yes, but don't include catversion bumps in submitted patches.
They'll just lead to merge problems when somebody else changes the
current catversion.  We rely on the committer to remember to do this
(which is an imperfect system, but...)

			regards, tom lane