Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m40T5-00087t-2z for pgsql-hackers@arkaria.postgresql.org; Thu, 15 Jul 2021 12:27:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1m40T3-0003uf-QK for pgsql-hackers@arkaria.postgresql.org; Thu, 15 Jul 2021 12:27:53 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m40T3-0003te-Hf for pgsql-hackers@lists.postgresql.org; Thu, 15 Jul 2021 12:27:53 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1m40Sz-00056G-FE for pgsql-hackers@lists.postgresql.org; Thu, 15 Jul 2021 12:27:53 +0000 Received: by mail-wm1-x32f.google.com with SMTP id n4so3619423wms.1 for ; Thu, 15 Jul 2021 05:27:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aiven.io; s=google; h=from:to:cc:subject:date:message-id:organization:in-reply-to :references:mime-version:content-transfer-encoding; bh=gqPDjJ4pYM4j5VNslFsLuEzOiWmHzJS1jBv+LjKYBic=; b=r0Bbzl9FHY8uImvTtp2imL7sPYKwoLc1nAgKz4ZfPKNTFrg+xjZ0YQvfaYTqzzuPu/ 8TOTOzsEuCptXeJvK8ZcyZ8XQkeXTjdcE2DT6oXBKFiJMqHyux16KQfkSlB16WM/WCh8 3vp32t2VevBio27PtRZnNAZ3sCaY0CR8ShUfs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :in-reply-to:references:mime-version:content-transfer-encoding; bh=gqPDjJ4pYM4j5VNslFsLuEzOiWmHzJS1jBv+LjKYBic=; b=txdw/ZCrygO8iixcULVUIm6iL3VaEsuZTtyP5ISuECmI8IbwjuYFamAbOJRLaXqkFp rHKurbPDj07jcvtzTEKudwwnmjpUO7m2hQ8qYN6Fb0FhrdnAIfptVJsWB+RlKA9Dh6Zn wS1R2OzgQncHY+j8BgXtksRLyp8I4jRuZYsow9D7mC8fzNX7XtNaOnFObr63LvToIyKV //KNC5YG8MtOd2NgY2+pgAEL9ybtuyXdmL38O173/jqIF8v2amAF6JT0xYRG9rnU5vdt pxa/ePfn4toM0rUIPVCOfTPXCMiY1Vo3rP0TG8VRs/mIo7NXNhgN/PjO5ESd/3kg4XgM JtHA== X-Gm-Message-State: AOAM531HwBd46D8HsfJyoB/28aGbyD1hvqTqmJeF+8ian+3zZEDssOoR m7Ak1rQW9sxtiFSml2hnlNcnnw== X-Google-Smtp-Source: ABdhPJze3+3LJTHqjN9hJI2rg1zxa7PFMWzwkjZnBgkiZ7FKc16qShMnXy4ksEbbOTr01G/vt4+mjw== X-Received: by 2002:a1c:7c08:: with SMTP id x8mr4350351wmc.2.1626352068233; Thu, 15 Jul 2021 05:27:48 -0700 (PDT) Received: from aivenronan.localnet (static-176-158-121-96.ftth.abo.bbox.fr. [176.158.121.96]) by smtp.gmail.com with ESMTPSA id y16sm6535002wrw.42.2021.07.15.05.27.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jul 2021 05:27:47 -0700 (PDT) From: Ronan Dunklau To: Ranier Vilela Cc: David Rowley , John Naylor , James Coleman , PostgreSQL Developers , Dilip Kumar Subject: Re: [PATCH] Use optimized single-datum tuplesort in ExecSort Date: Thu, 15 Jul 2021 14:27:38 +0200 Message-ID: <2994948.lz6J30L4x0@aivenronan> Organization: aiven In-Reply-To: References: <3177670.itZtoPt7T5@aivenronan> <2502562.vDctQ7PNa3@aivenronan> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Le jeudi 15 juillet 2021, 14:09:26 CEST Ranier Vilela a =E9crit : > Is there a special reason to not share v7b tests and results? >=20 The v7b patch is wrong, as it loses the type of tuplesort being used and as= =20 such always tries to fetch results using tuplesort_gettupleslot after the f= irst=20 tuple is fetched.=20 =2D-=20 Ronan Dunklau