From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
cc: vignesh C <vignesh21@gmail.com>, Andres Freund <andres@anarazel.de>,
        Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Unused header file inclusion
In-reply-to: <20190805180656.GA11353@alvherre.pgsql>
References: <20190805180656.GA11353@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@2ndquadrant.com>
	message dated "Mon, 05 Aug 2019 14:06:56 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <29997.1565029503.1@sss.pgh.pa.us>
Date: Mon, 05 Aug 2019 14:25:03 -0400
Message-ID: <29998.1565029503@sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Then there's the <limits.h> removal, which is in tuplesort.c because of
> INT_MAX as added by commit d26559dbf356 and still present ...

One has to be especially wary of removing system-header inclusions;
the fact that they don't seem to be needed on your own machine doesn't
prove they aren't needed elsewhere.

> ... I suggest this patch should be rejected.

Yeah.  If we do anything along this line it should be based on
pgrminclude results, and even then I think it'd require manual
review, especially for changes in header files.

The big picture here is that removing #includes is seldom worth
the effort it takes :-(

			regards, tom lane