Message-ID: <29a2087d79080e9bbdde6d2423a94635cca639b8.camel@j-davis.com>
Subject: Re: Statistics import and export: difference in statistics of
 materialized view dumped
From: Jeff Davis <pgsql@j-davis.com>
To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers
 <pgsql-hackers@postgresql.org>,  Corey Huinker <corey.huinker@gmail.com>
Date: Fri, 28 Mar 2025 16:20:58 -0700
In-Reply-To: 
 <CAExHW5tB7xw=_WazvwSZ2jffi6E4JoV_H36rXSjK+jrPNe-bEA@mail.gmail.com>
References: 
	<CAExHW5s47kmubpbbRJzSM-Zfe0Tj2O3GBagB7YAyE8rQ-V24Uw@mail.gmail.com>
	 <1427602.1741702648@sss.pgh.pa.us>
	 <a443f2322c61ab38d6b3ac3915fe0afaf0235b93.camel@j-davis.com>
	 <1500726.1741706804@sss.pgh.pa.us>
	 <1a83225688da8a72a97029f69a222246638014ba.camel@j-davis.com>
	 <CAExHW5sFRnLkBjcmX8cpUgkKk=zn0WUZJ20ZZ8XUYBgPT0qnhw@mail.gmail.com>
	 <CAExHW5uiRcXqXvXs7FfSndHDQsf8bxOS8k=BoC5rx6VLfHBQPg@mail.gmail.com>
	 <73f0555abad4b40b82cae193789e4d1b0d0a1b00.camel@j-davis.com>
	 <CAExHW5tB7xw=_WazvwSZ2jffi6E4JoV_H36rXSjK+jrPNe-bEA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/29a2087d79080e9bbdde6d2423a94635cca639b8.camel%40j-davis.com>
Precedence: bulk

On Fri, 2025-03-28 at 14:53 +0530, Ashutosh Bapat wrote:
> When I applied v1 it didn't pass.

I applied v1 on top of master as of March 15 (771ba90298), and then
took your two changes adding the tests, and it passed.

Version v2j is just rebased forward, which involved a trivial merge
conflict.

> But applying v2j-0003, the test passes.

Great.

> It feels like we can simplify this as: REFRESH MATERIALIZED VIEW
> replaces storage and resets the stats hence the Matview stats should
> be printed after printing REFRESH MATERIALIZED VIEW command in
> SECTION_POST_DATA. Also the materialized view ... . Hence the section
> may be updated later for materialized views.

Done, with a few modifications. Hopefully it's simpler.


Tom suggested that there may be other dependency problems lurking, but
I believe the patch is an improvement, so I committed it now to unblock
your work.

Regards,
	Jeff Davis