MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Date: Fri, 17 Oct 2025 09:28:28 +0900
From: torikoshia <torikoshia@oss.nttdata.com>
To: Naga Appani <nagnrik@gmail.com>
Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, Michael Paquier
 <michael@paquier.xyz>, Kirill Reshke <reshkekirill@gmail.com>,
 pgsql-hackers@postgresql.org
Subject: Re: [Proposal] Expose internal MultiXact member count function for
 efficient monitoring
In-Reply-To: 
 <CA+QeY+C38cgqesZi1Tt92=D6rw_RzCV5yKhoDe5eFLtQ9RQB_Q@mail.gmail.com>
References: 
 <CALdSSPi3Gh08NtcCn44uVeUAYGOT74sU6uei_06qUTa5rMK43g@mail.gmail.com>
 <CA+QeY+DTggHskCXOa39nag2sFds9BD-7k__zPbvL-_VVyJw7Sg@mail.gmail.com>
 <CAExHW5uxBnodmpXygUQUxZAyxYvbXczadxGOVeL=0DxpkXUR-g@mail.gmail.com>
 <aIb67MiYhVy7gwV-@paquier.xyz>
 <CAExHW5vba_ecL2c27giAOOaRxoNdVX2BNQVCN4PFOZJC17NrqQ@mail.gmail.com>
 <CA+QeY+CFLjh0gb-j9p+0eJK=r19izhEPCBY3ns4+HCgOQojh8Q@mail.gmail.com>
 <CAExHW5s5hnxKK_VE=q94sN8uU5BJCRpAescGuamheuM-Ua559A@mail.gmail.com>
 <CA+QeY+C3tc12wWX56yHozLYK=MmCkn1fODzFWC6-dSY+TZghTQ@mail.gmail.com>
 <CAExHW5s-StFwDpZBeiikvdnrBBr0s+2jJTZRv3Hh914T4C6Euw@mail.gmail.com>
 <CA+QeY+AmRSSJU8GKJ1uNVe2ps8GTONXpioYR7gEz91_prKR6sw@mail.gmail.com>
 <aKQac2ZrY4UWBORR@paquier.xyz>
 <CA+QeY+AwWV=g8z1eDE7OGHxKBer18gVER7nD+SnfhqLmiL7NOA@mail.gmail.com>
 <a5f1b794396a79d69ec70f5eaa7bdaf3@oss.nttdata.com>
 <d8a16af85820dddd9495442cc23111d0@oss.nttdata.com>
 <CAExHW5sUU1+Vq9oG6x=u85W7Obr-dPfAc7rQtaN-LJw5uufuMA@mail.gmail.com>
 <CA+QeY+DLsjj4RxY-Z2wRC-sYCeFxuPSd8zSkt4Nvs==YV6GP6w@mail.gmail.com>
 <CAExHW5tDxjXKcP0XuUZXb_UbpAs_oQ29HyOtvL0xf7dCkk5ypw@mail.gmail.com>
 <CA+QeY+A2B7mjWc8kkieNS_nxNyTeZpTzi4Ue+vtHzkmfFxO-8Q@mail.gmail.com>
 <CAExHW5sFtNduYEnyGhQOb=xiLrbkvwE0merhpZA5pNqcNzBbmw@mail.gmail.com>
 <CA+QeY+C38cgqesZi1Tt92=D6rw_RzCV5yKhoDe5eFLtQ9RQB_Q@mail.gmail.com>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <29f9e7abc90c3a4fe4a44026141c0d6c@oss.nttdata.com>
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/29f9e7abc90c3a4fe4a44026141c0d6c%40oss.nttdata.com>
Precedence: bulk

On 2025-09-15 14:47, Naga Appani wrote:

> With these updates in v9, I believe the patch is now in good shape to
> be marked RFC. I=E2=80=99ll go ahead and update the CommitFest entry.

As shown in the commitfest app, v9 patch fails to build:

   multixactfuncs.c:129:28: error: call to undeclared function=20
'heap_form_tuple'; ISO C99 and later do not support implicit function=20
declarations [-Wimplicit-function-declaration]
   129 |                 return=20
HeapTupleGetDatum(heap_form_tuple(tupdesc, values, nulls));
       |                                          ^
   multixactfuncs.c:129:28: note: did you mean 'brin_form_tuple'?
../../../../src/include/access/brin_tuple.h:96:19: note:=20
'brin_form_tuple' declared here
    96 | extern BrinTuple *brin_form_tuple(BrinDesc *brdesc, BlockNumber=20
blkno,
       |                   ^
   multixactfuncs.c:129:28: error: incompatible integer to pointer=20
conversion passing 'int' to parameter of type 'const HeapTupleData *'=20
(aka 'const struct HeapTupleData *') [-Wint-conversion]
   129 |                 return=20
HeapTupleGetDatum(heap_form_tuple(tupdesc, values, nulls));
       |                                         =20
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   ../../../../src/include/funcapi.h:230:40: note: passing argument to=20
parameter 'tuple' here
   230 | HeapTupleGetDatum(const HeapTupleData *tuple)
       |                                        ^
   2 errors generated.

Could you please update the patch to fix this?


--=20
Regards,

--
Atsushi Torikoshi
Seconded from NTT DATA Japan Corporation to SRA OSS K.K.