Message-ID: <29ff27f5-d359-4479-b11c-ce28e525d806@postgrespro.ru>
Date: Wed, 10 Dec 2025 02:22:53 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
References: 
 <171085360143.2046436.7217841141682511557.pgcf@coridan.postgresql.org>
 <CAPpHfdsh_jPZ6-2JtWoFeZravVQYY4cYCcnKXQW6KxEx+F5vxg@mail.gmail.com>
 <2643645f-2a02-43de-9321-c995ab1b7ef8@postgrespro.ru>
 <CACJufxF1Hfx1PST7pCLrKkGcjHEn2A51znXmYwVccnt5GDORcw@mail.gmail.com>
 <57a94d8a-d7b6-4c5e-9001-be1cd403b172@postgrespro.ru>
 <54414932-9E82-47AA-902B-2DED18F07F64@gmail.com>
 <e7da0ceb-8a01-4856-8c87-f87f09b4a9ad@postgrespro.ru>
 <CACJufxET9Qe-=zJtjGrKPr7-1QbVcP9y-vJU9CMEDfPGt_dbyg@mail.gmail.com>
 <3280c458-a886-4c58-8e2b-4d220b73161d@postgrespro.ru>
 <CACJufxEBvrtcOWyX2NMwOCvb2ZvaRGaGeiMQpUD=yxL6ncBFOg@mail.gmail.com>
 <dbe8e3ac-0b85-4809-bfaf-1d11f3c9d814@postgrespro.ru>
 <CAPpHfdvSBR+sbsRCAybN949tOGArQvMH2QeDXf2L=7NDMNbJfw@mail.gmail.com>
 <b96a16a5-02de-4cc2-afb4-fbccba43eb54@postgrespro.ru>
 <CAPpHfduQwwa4ytK-dGjRGN0fTWfpWNNysYuUKrOetsyGioBMfA@mail.gmail.com>
 <09414bf8-9326-431c-9422-b13bddf5f554@postgrespro.ru>
 <CAPpHfdvpzezTnuumpdJYge=x1TbhgAkjMGh2GHnScf5SFsf2ew@mail.gmail.com>
Content-Language: en-US
From: Dmitry Koval <d.koval@postgrespro.ru>
In-Reply-To: 
 <CAPpHfdvpzezTnuumpdJYge=x1TbhgAkjMGh2GHnScf5SFsf2ew@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/29ff27f5-d359-4479-b11c-ce28e525d806%40postgrespro.ru>
Precedence: bulk

Hi, Alexander!

Thank you for your corrections!
Two questions:
----

1) "v65-0001-Implement-ALTER-TABLE-.-MERGE-PARTITIONS-.-comma.patch"
  patch, "src/backend/partitioning/partbounds.c" file, 
"check_two_partitions_bounds_range" function.

Old comment (v64)

+	/*
+	 * lower1=false (the second to last argument) for correct comparison of
+	 * lower and upper bounds.
+	 */

was changed to (v65)

+	/*
+	 * cmpval == false for the correct comparison result of the lower and
+	 * upper bounds.
+	 */

Maybe it's better to keep the old comment (or keep its meaning)?
----

2) "v65-0002-Implement-ALTER-TABLE-.-SPLIT-PARTITION-.-comman.patch"
patch, "src/backend/parser/parse_utilcmd.c" file, "checkPartition" function.

The third argument of function was changed from "is_merge" (v64) to
"isMerge" (v65). Maybe the function description should be changed in
the same way?

+ * is_merge: true indicates the operation is "ALTER TABLE ... MERGE 
PARTITIONS";

-- 
With best regards,
Dmitry Koval

Postgres Professional: http://postgrespro.com