Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vJnqi-003JjJ-2z for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Nov 2025 07:03:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vJnqg-004tBK-1e for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Nov 2025 07:03:58 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vJnqg-004tBC-0g for pgsql-hackers@lists.postgresql.org; Fri, 14 Nov 2025 07:03:58 +0000 Received: from mail-qk1-x735.google.com ([2607:f8b0:4864:20::735]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vJnqd-007frT-20 for pgsql-hackers@postgresql.org; Fri, 14 Nov 2025 07:03:57 +0000 Received: by mail-qk1-x735.google.com with SMTP id af79cd13be357-8b272a4ca78so230732685a.1 for ; Thu, 13 Nov 2025 23:03:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763103833; x=1763708633; darn=postgresql.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BpbTMRUmrA7YMjFSdP87s1mI4wGbWxxjPs+wTEdCi0o=; b=YyrUHtTk05G1THyirDjj330RDsqtshXGEjhrGsg5biK9aoh8fzH34sMJCwOZPf0l4d IFoSjpXaFpg94qyAgp6FK3FSTkozh4vmf8kr44nt+dKwnxkgF6nE/i2EPduYXVNSEN8G 15AGUytacwGST/zvOd9HxNWKTRrTsw8B5L0ZdmH5uTLDgPn1+uKRbWcf6t53ZhkrZpNB pLt6O7neezjs8Hv5IxkSXSmEzp95x2Y2gvbR8Ce4BucVN3z8sLhvxjZUEblWSIJQMyFp GOvgSRxg9RaBizKbdnukvb5yNY9GrNuO8WewTGo3H0GFVlEbsNpcYbflWlbjL3wBe0oh rOpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763103833; x=1763708633; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=BpbTMRUmrA7YMjFSdP87s1mI4wGbWxxjPs+wTEdCi0o=; b=TEfl8Ufbht71Sh2fZrB7AOJWKyRK1fUoJ7si8eCQTbPMgPuyNmJymlqJ5R6dJFXC2+ IduVN3w7PDvU1SD+gkufYJF7Zy0vfwg4lm+EShojXMvc1nSXCyhJOVVCBEisMjIc6YhA 0HhZWdP2va0MZXnKXUbFn74gUFjUWrn3LoFDT6NlJjiE4Ys/Ox023SWxFOi70CW8NjpE 3HVfmfnZcS1un0hk0HsEEPWH7hQc+ovlB9odTlt+nhaMA9xTbN5Mfez/7nj73j+IKm2V 80E9O1+UFt0g1pX6JV5aTlp0x6iYXFO/S/A5nWTzn5BvQFIwFG0/ntqEk286YUIvylAg NdCA== X-Forwarded-Encrypted: i=1; AJvYcCX8HPd/EOSSw4qgRoqtb/OOucZhwTL5roylCbvpUpGZwmOAfb6Ntvsv/iXu1wK8gDZlvxoto4tMht8/2bvh@postgresql.org X-Gm-Message-State: AOJu0YxPUlT0hdfkMrHdDtRGcvB6drSCIK3znWXO/xJ23ypQfXq8adkp MwMu9uOB/wm/P9hylRy9eOIBwod1TUUDhJGdE8CX1N9mecZzTR6xZyhs X-Gm-Gg: ASbGncusH1ctQkctaYd5tY3YzzSkFqrFpxJMsYgQoOSTt5RCFHQaRhT7Hm+wL0ZHZWJ seMi2OrBJ3BOW6Tu+Z1t6O7oAyrp1Mid/4J/wM5VL+vruyShbJBjN+wdqCzNPMHUdnVGiMKlXTx JHHAuBDlarfxk5/JWCpEawdPJHD+UVJ/HIxamZnvLhmX3x2qqEpp1EdqWAAoOnITAqLcM6TrAUR zLzM2wwmHpXijOkiassRsMJItLmYRonQ/NjFBOjQNx4gyfSc49qmhUrB8WJitXXnK7btx9275iL 6MQrftnnOgBihvYc2Ac0x0U9DfOKcR2xYLRocip2XwDgl9s2O2n5bifDKc6YAQIhaBw+oPDrl4V VKzkhgdMxdd7P8N2SWI8eU8nnpqZWn8kDBr94cDaLJ92PyVrcRPsMH4+QlygeRep+37aDzzgEon 2+78YLUqqxBA== X-Google-Smtp-Source: AGHT+IHQk5aOJ32v8gE+JbVuqp279ymV1oRtAC2OL6Hm7gUNceDWL7zlgSXinzhlO9sWy/wRWXthDw== X-Received: by 2002:a05:620a:4689:b0:892:4858:11a5 with SMTP id af79cd13be357-8b2c3175396mr273227385a.38.1763103833523; Thu, 13 Nov 2025 23:03:53 -0800 (PST) Received: from smtpclient.apple ([209.127.78.222]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8b2af062acasm282387085a.53.2025.11.13.23.03.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Nov 2025 23:03:52 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\)) Subject: Re: [PATCH] Add pg_get_database_ddl() function to reconstruct CREATE DATABASE statement From: Chao Li In-Reply-To: Date: Fri, 14 Nov 2025 15:03:15 +0800 Cc: Quan Zongliang , pgsql-hackers Content-Transfer-Encoding: quoted-printable Message-Id: <2A6390C3-8FA3-4BD6-8237-0ECCA21BE1BA@gmail.com> References: <7daf5cec-4eae-48e0-883e-684476b57531@yeah.net> To: Akshay Joshi X-Mailer: Apple Mail (2.3826.700.81) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi Akshay, I quick went through the patch, I do see some problems, but I need some = time to wrap up, so I will do a deep review next week. In the meantime, = I want to first ask that why there is no privilege check? I think = that=E2=80=99s a serious issue. > On Nov 13, 2025, at 16:32, Akshay Joshi = wrote: >=20 >=20 > Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/