Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rhref-00DkFn-10 for pgsql-hackers@arkaria.postgresql.org; Wed, 06 Mar 2024 13:49:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rhred-00AMVH-7t for pgsql-hackers@arkaria.postgresql.org; Wed, 06 Mar 2024 13:49:55 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rhrec-00AMV9-PH for pgsql-hackers@lists.postgresql.org; Wed, 06 Mar 2024 13:49:55 +0000 Received: from forwardcorp1a.mail.yandex.net ([178.154.239.72]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rhrea-0035jC-15 for pgsql-hackers@lists.postgresql.org; Wed, 06 Mar 2024 13:49:54 +0000 Received: from mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net [IPv6:2a02:6b8:c2a:3dc:0:640:1e66:0]) by forwardcorp1a.mail.yandex.net (Yandex) with ESMTPS id 7E8966116D; Wed, 6 Mar 2024 16:49:49 +0300 (MSK) Received: from smtpclient.apple (unknown [2a02:6b8:b081:b72e::1:24]) by mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id mng75a3i8uQ0-JW82ynOa; Wed, 06 Mar 2024 16:49:49 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1709732989; bh=/uxvLaRjmIXCtLnhWlkgY7dxNGSjGwDReN3jGlbUxt0=; h=Message-Id:To:Date:References:Cc:In-Reply-To:From:Subject; b=TZDizyCUrsDEHPL3peOtelMkZ7AQ1b4GpC/a9BkS/82ZNqdBO0YXtaiCoN+hvm3+J PmooGiqXg4d3172aibMlJLlwdlnaqk4I1hZ3wP2gBYRSGYA+6OQZ9AzQBcMIczLkB5 Snow571g5lBBsfwVbMRnTVsCF1OIbG54FLV20pMI= Authentication-Results: mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\)) Subject: Re: CF entries for 17 to be reviewed From: "Andrey M. Borodin" In-Reply-To: <48167BD3-7145-4CFC-B2D8-CEE18FAE9738@yandex-team.ru> Date: Wed, 6 Mar 2024 16:49:48 +0300 Cc: Pgsql Hackers Content-Transfer-Encoding: quoted-printable Message-Id: <2AFAACF9-27F2-4433-B62D-DC825DD7BA11@yandex-team.ru> References: <48167BD3-7145-4CFC-B2D8-CEE18FAE9738@yandex-team.ru> To: Melanie Plageman X-Mailer: Apple Mail (2.3696.120.41.1.4) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 4 Mar 2024, at 14:51, Andrey M. Borodin = wrote: >=20 > I=E2=80=99ve read other small sections. Here are statuses for "Refactoring" section: * New [relation] options engine Relatively heavy refactoring. Author keeps interest to the patch = for some years now. As I understood the main problem is that big = refactoring cannot be split into incremental steps. Definitely worth = reviewing, but I think not for 17 already... * Confine vacuum skip logic to lazy_scan_skip There was a discussion at the end of 2023, but no recent review = activity. Author actively improves the patchset. * Change prefetch and read strategies to use range in pg_prewarm Some discussion is happening. Changed to WoA to reflect actual = status. * Potential issue in ecpg-informix decimal converting functions On Daniel's TODO list. * BitmapHeapScan table AM violation removal (and use streaming read API) Active discussion with reviewers is going on. * Streaming read sequential and TID range scan Seems like discussion on this patch is going on in nearby = threads. In this thread I observe only improved patch versions posted. All in all "Refactoring" section seemed to me more complex and demanding = in-depth knowledge. It's difficult to judge why new approaches are an = improvement. So for newcomer reviewers I'd recommend to look to other = sections. Thanks. Best regards, Andrey Borodin.=