From: Mark Dilger <mark.dilger@enterprisedb.com>
Message-Id: <2BD8BDA8-A963-4D64-8B69-8F7EDF9AEA2D@enterprisedb.com>
Content-Type: multipart/mixed;
	boundary="Apple-Mail=_1B1A39F5-8B2D-47CF-A2BE-6EE2EAD611AB"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
Subject: Re: New Object Access Type hooks
Date: Mon, 4 Apr 2022 11:09:45 -0700
In-Reply-To: <1925660.1649095626@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@gmail.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>,
 Joshua Brindle <joshua.brindle@crunchydata.com>,
 Robert Haas <robertmhaas@gmail.com>,
 Andrew Dunstan <andrew@dunslane.net>,
 Jeff Davis <pgsql@j-davis.com>,
 Joe Conway <joe@crunchydata.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
References: <47F87A0E-C0E5-43A6-89F6-D403F2B45175@enterprisedb.com>
 <CA+hUKG+LOza8iSLiv6ymn=0R8S0x-R7KaqZmYfY+_b_cubcDOg@mail.gmail.com>
 <17BD82D7-49AC-40C9-8204-E7ADD30321A0@enterprisedb.com>
 <1918971.1649091790@sss.pgh.pa.us> <1922986.1649094077@sss.pgh.pa.us>
 <1923706.1649094673@sss.pgh.pa.us>
 <AACAF464-092B-4497-ADA2-AE1B122FAC6A@enterprisedb.com>
 <1925660.1649095626@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/2BD8BDA8-A963-4D64-8B69-8F7EDF9AEA2D%40enterprisedb.com>
Precedence: bulk


--Apple-Mail=_1B1A39F5-8B2D-47CF-A2BE-6EE2EAD611AB
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii


> On Apr 4, 2022, at 11:07 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 
> I was hoping to see regress_log_013_crash_restart, though.


--Apple-Mail=_1B1A39F5-8B2D-47CF-A2BE-6EE2EAD611AB
Content-Disposition: attachment;
	filename=regress_log_013_crash_restart
Content-Type: application/octet-stream;
	x-unix-mode=0644;
	name="regress_log_013_crash_restart"
Content-Transfer-Encoding: 7bit

# Checking port 49823
# Found port 49823
Name: primary
Data directory: /Users/mark.dilger/hydra/altersystem_v15_devel.7/src/test/recovery/tmp_check/t_013_crash_restart_primary_data/pgdata
Backup directory: /Users/mark.dilger/hydra/altersystem_v15_devel.7/src/test/recovery/tmp_check/t_013_crash_restart_primary_data/backup
Archive directory: /Users/mark.dilger/hydra/altersystem_v15_devel.7/src/test/recovery/tmp_check/t_013_crash_restart_primary_data/archives
Connection string: port=49823 host=/var/folders/6n/3f4vwbnn7fz5qk0xqhgbjrkw0000gp/T/hDGeeFsYRd
Log file: /Users/mark.dilger/hydra/altersystem_v15_devel.7/src/test/recovery/tmp_check/log/013_crash_restart_primary.log
# Running: initdb -D /Users/mark.dilger/hydra/altersystem_v15_devel.7/src/test/recovery/tmp_check/t_013_crash_restart_primary_data/pgdata -A trust -N
The files belonging to this database system will be owned by user "mark.dilger".
This user must also own the server process.

The database cluster will be initialized with this locale configuration:
  provider:    libc
  LC_COLLATE:  en_US.UTF-8
  LC_CTYPE:    en_US.UTF-8
  LC_MESSAGES: C
  LC_MONETARY: en_US.UTF-8
  LC_NUMERIC:  en_US.UTF-8
  LC_TIME:     en_US.UTF-8
The default database encoding has accordingly been set to "UTF8".
The default text search configuration will be set to "english".

Data page checksums are disabled.

creating directory /Users/mark.dilger/hydra/altersystem_v15_devel.7/src/test/recovery/tmp_check/t_013_crash_restart_primary_data/pgdata ... ok
creating subdirectories ... ok
selecting dynamic shared memory implementation ... posix
selecting default max_connections ... 100
selecting default shared_buffers ... 128MB
selecting default time zone ... America/Los_Angeles
creating configuration files ... ok
running bootstrap script ... ok
performing post-bootstrap initialization ... ok

Sync to disk skipped.
The data directory might become corrupt if the operating system crashes.

Success. You can now start the database server using:

    pg_ctl -D /Users/mark.dilger/hydra/altersystem_v15_devel.7/src/test/recovery/tmp_check/t_013_crash_restart_primary_data/pgdata -l logfile start

# Running: /Users/mark.dilger/hydra/altersystem_v15_devel.7/src/test/recovery/../../../src/test/regress/pg_regress --config-auth /Users/mark.dilger/hydra/altersystem_v15_devel.7/src/test/recovery/tmp_check/t_013_crash_restart_primary_data/pgdata
### Starting node "primary"
# Running: pg_ctl -w -D /Users/mark.dilger/hydra/altersystem_v15_devel.7/src/test/recovery/tmp_check/t_013_crash_restart_primary_data/pgdata -l /Users/mark.dilger/hydra/altersystem_v15_devel.7/src/test/recovery/tmp_check/log/013_crash_restart_primary.log -o --cluster-name=primary start
waiting for server to start.... done
server started
# Postmaster PID for node "primary" is 2070
ok 1 - acquired pid for SIGQUIT
ok 2 - inserted in-progress-before-sigquit
ok 3 - monitor connected
# Running: pg_ctl kill QUIT 2083
ok 4 - killed process with SIGQUIT
# pump_until: process terminated unexpectedly when searching for "(?^m:WARNING:  terminating connection because of crash of another server process|server closed the connection unexpectedly|connection to server was lost)" with stream: "psql:<stdin>:9: WARNING:  terminating connection because of unexpected SIGQUIT signal
# psql:<stdin>:9: could not send data to server: Socket is not connected
# "
not ok 5 - psql query died successfully after SIGQUIT

#   Failed test 'psql query died successfully after SIGQUIT'
#   at t/013_crash_restart.pl line 109.
ok 6 - psql monitor died successfully after SIGQUIT
ok 7 - reconnected after SIGQUIT
ok 8 - acquired pid for SIGKILL
ok 9 - inserted in-progress-before-sigkill
ok 10 - monitor connected
# Running: pg_ctl kill KILL 2103
ok 11 - killed process with KILL
ok 12 - psql query died successfully after SIGKILL
ok 13 - psql monitor died successfully after SIGKILL
ok 14 - reconnected after SIGKILL
ok 15 - data survived
ok 16 - can still write after crash restart
### Restarting node "primary"
# Running: pg_ctl -w -D /Users/mark.dilger/hydra/altersystem_v15_devel.7/src/test/recovery/tmp_check/t_013_crash_restart_primary_data/pgdata -l /Users/mark.dilger/hydra/altersystem_v15_devel.7/src/test/recovery/tmp_check/log/013_crash_restart_primary.log restart
waiting for server to shut down.... done
server stopped
waiting for server to start.... done
server started
# Postmaster PID for node "primary" is 2127
ok 17 - data survived
ok 18 - can still write after orderly restart
### Stopping node "primary" using mode fast
# Running: pg_ctl -D /Users/mark.dilger/hydra/altersystem_v15_devel.7/src/test/recovery/tmp_check/t_013_crash_restart_primary_data/pgdata -m fast stop
waiting for server to shut down.... done
server stopped
# No postmaster PID for node "primary"
1..18
# Looks like you failed 1 test of 18.

--Apple-Mail=_1B1A39F5-8B2D-47CF-A2BE-6EE2EAD611AB
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8


=E2=80=94
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--Apple-Mail=_1B1A39F5-8B2D-47CF-A2BE-6EE2EAD611AB--