Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\))
Subject: Re: Use pg_icu_unicode_version(void) instead of
 pg_icu_unicode_version()
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: <aaEhpwrj1FY/8/7n@ip-10-97-1-34.eu-west-3.compute.internal>
Date: Fri, 27 Feb 2026 14:04:30 +0800
Cc: pgsql-hackers@lists.postgresql.org,
 Jeff Davis <pgsql@j-davis.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <2E8E63C9-A2F6-4723-A937-B9F6CB34C88A@gmail.com>
References: <aaEhpwrj1FY/8/7n@ip-10-97-1-34.eu-west-3.compute.internal>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/2E8E63C9-A2F6-4723-A937-B9F6CB34C88A%40gmail.com>
Precedence: bulk


> On Feb 27, 2026, at 12:46, Bertrand Drouvot =
<bertranddrouvot.pg@gmail.com> wrote:
>=20
> Hi hackers,
>=20
> Standard practice in PostgreSQL is to use "foo(void)" instead of =
"foo()", as the
> latter looks like an "old-style" function declaration. 9b05e2ec08a did =
fix
> all the ones reported by -Wstrict-prototypes.
>=20
> af2d4ca191a4 introduced a new one, this patch fixes it.
>=20
> Regards,
>=20
> --=20
> Bertrand Drouvot
> PostgreSQL Contributors Team
> RDS Open Source Databases
> Amazon Web Services: https://aws.amazon.com
> <v1-0001-Use-pg_icu_unicode_version-void-instead-of-pg_icu.patch>

This patch is straightforward.

What I'm interested in is the broader policy: when reviewing patches, if =
we encounter a foo() declaration, should we consistently request a =
change to foo(void)? If yes, the standard should be documented =
somewhere.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/