Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\))
Subject: Re: Restart pg_usleep when interrupted
From: Sami Imseih <samimseih@gmail.com>
In-Reply-To: <Zo_7blmO166ZDGbW@nathan>
Date: Thu, 11 Jul 2024 13:10:25 -0500
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
 Tom Lane <tgl@sss.pgh.pa.us>,
 Robert Haas <robertmhaas@gmail.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <2F781744-69B8-4BC2-A6EF-3998DCCDB634@gmail.com>
References: 
 <01000190606e3d2a-116ead16-84d2-4449-8d18-5053da66b1f4-000000@email.amazonses.com>
 <CA+TgmobMqV95Zj2906s4_dtS2_JKqG-6ogKHGdiH+y3rar9NCA@mail.gmail.com>
 <7D50DC5B-80C6-47B5-8DA8-A6C68A115EE5@gmail.com>
 <2100439.1719610468@sss.pgh.pa.us>
 <AC328D21-21D6-4FFC-8F6B-BFE9AD940524@gmail.com>
 <ZoPC5IeP4k7sZpki@ip-10-97-1-34.eu-west-3.compute.internal>
 <373D199B-2312-431D-8018-F2808913F979@gmail.com>
 <Zo0UdeE3i9d0Wt5E@ip-10-97-1-34.eu-west-3.compute.internal>
 <3712E898-03DA-4E03-AF51-D3E24DE68216@gmail.com>
 <C18017A1-EDFD-4F2F-BCA1-0572D4CCC92B@gmail.com> <Zo_7blmO166ZDGbW@nathan>
To: Nathan Bossart <nathandbossart@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/2F781744-69B8-4BC2-A6EF-3998DCCDB634%40gmail.com>
Precedence: bulk


>=20
> I'm curious why we wouldn't just subtract "elapsed_time" from "delay" =
at
> the bottom of the while loop to avoid needing this extra check. =20

Can you elaborate further? I am not sure how this will work since delay =
is a timespec=20
and elapsed time is an instr_time.=20

Also, in every iteration of the loop, the delay must be set to the =
remaining time. The
purpose of the elapsed_time is to make sure that we don=E2=80=99t =
surpass requested time
delay as an additional safeguard.

> Also, I
> think we need some commentary about why we want to retry after an =
interrupt
> in this case.

I will elaborate further in the comments for the next revision.


Regards,

Sami=20