Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uA4SY-00ACmm-Sp for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Apr 2025 10:14:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uA4SW-00D1CX-2T for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Apr 2025 10:14:33 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uA4SV-00D1CP-PH for pgsql-hackers@lists.postgresql.org; Wed, 30 Apr 2025 10:14:32 +0000 Received: from fout-b7-smtp.messagingengine.com ([202.12.124.150]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uA4SU-000KXE-17 for pgsql-hackers@postgresql.org; Wed, 30 Apr 2025 10:14:31 +0000 Received: from phl-compute-03.internal (phl-compute-03.phl.internal [10.202.2.43]) by mailfout.stl.internal (Postfix) with ESMTP id 9EB151140220; Wed, 30 Apr 2025 06:14:29 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-03.internal (MEProxy); Wed, 30 Apr 2025 06:14:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm2; t=1746008069; x=1746094469; bh=tXqssT2pwt4DDaYW1nmQhbK0G9CPHoaE QhobZkGPAMI=; b=O4rDzju+hJ5m2F4Yu17b1QKwA6bNI8GYW9eOz+pM7hnVGaoN Ymf2YFgurgfFTYnbm5fUxHCtHqboIQ/1TB6xKlQR3uF4nsp3rdDwyTZcRB14JKHO T87aa1sFJYeC0Qj+wqwg1VIRYVZNxzztlhLuGXzQoUgSoFa/3adWtneY4QWupsvA 5xOq5V9j64veLCzPwtu2OcenAfWWS0THfG3MXInbF13G9f9DZalAXkdVPb8F8Q4T Fum55lyt3nzDQVdsKeYFGVjjZkjN9M/Q1d/p9KM0GdMAq/l4zKPDRgi3DImmtKCn xaR8Uobf5Iy+7MDvOKH81v9uUUAmJ1phHqJaIw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1746008069; x= 1746094469; bh=tXqssT2pwt4DDaYW1nmQhbK0G9CPHoaEQhobZkGPAMI=; b=G 9v7Ipsvvez14a+G2bGwC286FhZyVzlzI+CdyL6MkoyVOLh5LgpKwb6SfLc4sX6x2 TIu1QLbz7JiJHmWmdR7okVe6YIM03XMGkO+MMTGu6g2ijvofGFIL0aB9YcL5hhPR Jyh/Vx6kW1if0xIXrCP001UpLShy5K30mMKMKxfkvCWNQjJSBamlyJ3H6Ckz0z6Z DzRjZHXpb/bWhNqajduP3+P+p+kJpeRMAoFQdKe63ZB41quTFU+EgPR87AAwawcc LDVVNDLECNzfyiDGaQHPMQVFhD4yY8Enln18ACnQnFCvz8EwW3QrhBz2lgh5b/TZ 9E5BUTaVa+GulHGoV7u0g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvieeigeefucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddt vdejnecuhfhrohhmpefrvghtvghrucfgihhsvghnthhrrghuthcuoehpvghtvghrsegvih hsvghnthhrrghuthdrohhrgheqnecuggftrfgrthhtvghrnhepgfejtdfhkeeftdeugfei leehteeljeeghfeuledthfeutedvffdukeefjefhgeehnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhesvghishgvnhhtrhgruhht rdhorhhgpdhnsggprhgtphhtthhopeefpdhmohguvgepshhmthhpohhuthdprhgtphhtth hopehrrghhihhlrghshigvugeltdesghhmrghilhdrtghomhdprhgtphhtthhopegurghn ihgvlheshigvshhqlhdrshgvpdhrtghpthhtohepphhgshhqlhdqhhgrtghkvghrshesph hoshhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 30 Apr 2025 06:14:28 -0400 (EDT) Message-ID: <2a796830-de2d-4030-b480-d673f6cc5d94@eisentraut.org> Date: Wed, 30 Apr 2025 12:14:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Enhancing Memory Context Statistics Reporting To: Rahila Syed , Daniel Gustafsson Cc: PostgreSQL Hackers References: <54FAE93D-E156-4684-9352-1CEDE6BD4A1C@yesql.se> <5bxhxniyvjyfldi7yjxcnxkl3i2ghci2grjyeclrbkfqnyhowk@dfkqzbvtbpml> <3eb40b3e-45c7-426a-b7f8-81f7d05a9b53@oss.nttdata.com> <74105887-E4EF-4CA2-9F0A-3C0CE05BF632@yesql.se> <437100f2-dd86-42e6-830c-5ff413a25e8e@oss.nttdata.com> Content-Language: de-DE, en-US From: Peter Eisentraut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 29.04.25 15:13, Rahila Syed wrote: > Please find attached a patch with some comments and documentation changes. > Additionaly, added a missing '\0' termination to "Remaining Totals" string. > I think this became necessary after we replaced dsa_allocate0() > with dsa_allocate() is the latest version. > strncpy(nameptr, "Remaining Totals", namelen); > + nameptr[namelen] = '\0'; Looks like a case for strlcpy()?