Subject: Re: Skipping logical replication transactions on subscriber side
To: Masahiko Sawada <sawada.mshk@gmail.com>,
 Amit Kapila <amit.kapila16@gmail.com>
Cc: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>,
 "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>,
 "osumi.takamichi@fujitsu.com" <osumi.takamichi@fujitsu.com>,
 Alexey Lesovsky <lesovsky@gmail.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>,
 Greg Nancarrow <gregn4422@gmail.com>
References: 
 <CAD21AoCgfka7rDREXRNQZJ4_GnHTTwqP6JMpaD5aBPhbtoeS8A@mail.gmail.com>
 <CAA4eK1JKf2Jejg1abuuU-Gx8Dkw0tey4Jiz5ACyQJ4QzKDvHSg@mail.gmail.com>
 <CAD21AoBT+gx=2V-dKTdrqUeqrnm=6fdJ6r7KFoKNVgLrqDMGsg@mail.gmail.com>
 <CAA4eK1J3Fc0=tE2ZR7XnEfeZm52_4hyQZO1s7kEALFLvZsXxRQ@mail.gmail.com>
 <CAD21AoAZ76=YB_QyQuDNc-NBdGfQ_zbiee3aw7MUVFFmTZPB6A@mail.gmail.com>
 <CAA4eK1JRCQ-bYnbkwUrvcVcbLURjtiW+irFVvXzeG+j=y6jVgA@mail.gmail.com>
 <CAD21AoDR8-sjxrXtQX+ai12kJPR+atM3y5R7ohcj+At6grW7aQ@mail.gmail.com>
 <CAD21AoDOiVPvkcuEDC1cZ=tj67Rh6nErDHmRDAaL7wnqwSYBNQ@mail.gmail.com>
 <CAA4eK1JY=gGysTKdf5uUQSQpe7XVBkYTOWpFLoVZWuEc-rgoAQ@mail.gmail.com>
 <CAD21AoCkisO1b9z44HCdv0FyZBE5FK_nyQg0Y1HJNY1QPGGrRQ@mail.gmail.com>
 <3163a085-66e6-426c-f97b-8df66980c7c4@enterprisedb.com>
 <CAD21AoBh_fRr=pEn6gdazqRVYA5VGXWt4mgmcuFK3iQB8KuTBg@mail.gmail.com>
 <CAA4eK1+BOHXC=0S2kA7GkErWq3-QKj34oQvwAPfuTHq=epf34w@mail.gmail.com>
 <CAD21AoC_AdB5i4OVHu-RWxSFr4nYgcEp2XhVv7i-hpYsX=ANHw@mail.gmail.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Message-ID: <2a9287f4-a870-ee93-d032-b93d7e908ba7@enterprisedb.com>
Date: Sun, 10 Oct 2021 16:04:31 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: 
 <CAD21AoC_AdB5i4OVHu-RWxSFr4nYgcEp2XhVv7i-hpYsX=ANHw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/2a9287f4-a870-ee93-d032-b93d7e908ba7%40enterprisedb.com>
Precedence: bulk

On 04.10.21 02:31, Masahiko Sawada wrote:
> I guess disabling subscriptions on error/conflict and skipping the
> particular transactions are somewhat different types of functions.
> Disabling subscriptions on error/conflict seems likes a setting
> parameter of subscriptions. The users might want to specify this
> option at creation time. Whereas, skipping the particular transaction
> is a repair function that the user might want to use on the spot in
> case of a failure. I’m concerned a bit that combining these functions
> to one syntax could confuse the users.

Also, would the skip option be dumped and restored using pg_dump?  Maybe 
there is an argument for yes, but if not, then we probably need a 
different path of handling it separate from the more permanent options.