Subject: Re: More time spending with "delete pending"
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Tom Lane
 <tgl@sss.pgh.pa.us>, Justin Pryzby <pryzby@telsasoft.com>
References: <995713.1605725597@sss.pgh.pa.us>
 <1001775.1605731995@sss.pgh.pa.us>
 <3366bfde-183f-60be-62ab-8ae81b946bac@gmail.com>
 <1006364.1605738508@sss.pgh.pa.us>
 <20729794-e2bf-bd7a-f01b-d132f89fd0d7@gmail.com>
 <fcc8aea0-14d2-9fab-1a4e-37fd1925c49b@gmail.com>
 <YOQVX1f9/2s1ct6W@paquier.xyz>
 <78fa6a17-8e71-7c99-62bd-8a11a47fe894@gmail.com>
 <YOatgGjMgnEFsnGL@paquier.xyz>
 <d030cc87-641c-c2f0-b7a9-4d6669ea91d7@gmail.com>
 <YOfkMRNtMjyDLnLL@paquier.xyz>
From: Alexander Lakhin <exclusion@gmail.com>
Message-ID: <2aa7ce7a-d73a-fa36-4fb5-3affe1860c58@gmail.com>
Date: Fri, 9 Jul 2021 21:00:00 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <YOfkMRNtMjyDLnLL@paquier.xyz>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Archived-At: 
 <https://www.postgresql.org/message-id/2aa7ce7a-d73a-fa36-4fb5-3affe1860c58%40gmail.com>
Precedence: bulk

Hello Michael,
09.07.2021 08:52, Michael Paquier wrote:
> On Thu, Jul 08, 2021 at 11:00:00PM +0300, Alexander Lakhin wrote:
>> Beside the aforementioned test I can only propose the extended patch,
>> that incorporates the undo of the changes brought by bed90759f.
>> With this patch that test is passed.
> Checked and confirmed.  It is a nice test with IPC::Run you have here.
> Making things in win32stat.c more consistent with open.c surely is
> appealing.  One thing that I'd like to introduce in this patch, and
> also mentioned upthread, is to change the stat() call in open.c to use
> microsoft_native_stat().
>
> I have let pgbench run for a couple of hours with some concurrent
> activity using genfile.c, without noticing problems.  My environment
> is not representative of everything we can find out there on Windows,
> but it brings some confidence.
Thank you! I agree with your improvement. I can't remember why did I
inject 'include "port.h"' in genfile.c.
Today I've rechecked all the chain of includes and I see that stat() is
redefined as _pgstat64() in win32_port.h, that includes <sys/stat.h>.
genfile.c includes "postgres.h" (that includes win32_port.h indirectly)
and then includes <sys/stat.h> again, but the later include should be
ignored due "#pragma once" in stat.h.
So I have no objection to the removal of that include.

Best regards,
Alexander