Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1n9R6E-0000Fx-Dk
	for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Jan 2022 12:27:02 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1n9R6B-0001cW-Oo
	for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Jan 2022 12:26:59 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <a.pyhalov@postgrespro.ru>)
	id 1n9R6B-0001cM-EW
	for pgsql-hackers@lists.postgresql.org; Mon, 17 Jan 2022 12:26:59 +0000
Received: from mail.postgrespro.ru ([93.174.131.139])
	by magus.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <a.pyhalov@postgrespro.ru>)
	id 1n9R69-0002hO-6W
	for pgsql-hackers@postgresql.org; Mon, 17 Jan 2022 12:26:58 +0000
Received: from mail.postgrespro.ru (cyclops.postgrespro.ru [93.174.131.138])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(Client did not present a certificate)
	by mail.postgrespro.ru (Postfix) with ESMTPSA id 6FE9821C2D87;
	Mon, 17 Jan 2022 15:26:55 +0300 (MSK)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru;
	s=mail; t=1642422415;
	bh=Su+0L0LN9aXo7ZPZLwxDTC6bXpVQStPj1h5vAXXBB2k=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References;
	b=gUyz/KlkEBD8wy5nlTEcB3grb9gbhI9xD9YsIo7th2fpW+Y4iHT1/rpoxlJn6MvM2
	 VcXEdZagoW0UHexQ8dZrxQu75o8vy5lCQt9Npmn15cn1vyDl8hXiuUjDgNzj9rCcv8
	 eFM82u8q0Vaik6Gg8Z+4B+aXunG8LLATW5s6SIOg=
MIME-Version: 1.0
Date: Mon, 17 Jan 2022 15:26:55 +0300
From: Alexander Pyhalov <a.pyhalov@postgrespro.ru>
To: Zhihong Yu <zyu@yugabyte.com>
Cc: Julien Rouhaud <rjuju123@gmail.com>, Daniel Gustafsson
 <daniel@yesql.se>, Ilya Gladyshev <i.gladyshev@postgrespro.ru>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Partial aggregates pushdown
In-Reply-To: <CALNJ-vSm6z6Lg1CgxbGUG6=xP3n+tYC_XGGUm33b9g98Z3bF-g@mail.gmail.com>
References: <b5a2bb24-ba7d-4053-b298-7e6247fd4043@enterprisedb.com>
 <2486a6db3f068efb97c1277c23402e0d@postgrespro.ru>
 <504e576d-984f-d73c-2694-8ee9624f8def@enterprisedb.com>
 <07fa4d5a56f402732acfce25e7207cae@postgrespro.ru>
 <0fbeb9d7-0a8f-8e2c-0687-2d4c32c66a9c@postgrespro.ru>
 <05d98f67a4f44b31d90dfb977db4ad71@postgrespro.ru>
 <D327E6BD-D368-48E4-A8A8-4B59BFB48649@yesql.se>
 <317f8de58ce9889e056f2944e200a44d@postgrespro.ru>
 <E1C82737-B148-4975-81C9-5366E4412553@yesql.se>
 <2ed9ad03bc17cfb86da900d541a270b0@postgrespro.ru>
 <20220114121653.mjzqelwgnzwqhkoa@jrouhaud>
 <0cc653ad90dbfc5ca0fd8bb1ca57e1a7@postgrespro.ru>
 <CALNJ-vSm6z6Lg1CgxbGUG6=xP3n+tYC_XGGUm33b9g98Z3bF-g@mail.gmail.com>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <2ad047732a8b8a9aaaad06fef59fb283@postgrespro.ru>
X-Sender: a.pyhalov@postgrespro.ru
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/2ad047732a8b8a9aaaad06fef59fb283%40postgrespro.ru>
Precedence: bulk

Zhihong Yu писал 2022-01-17 11:43:
> Hi,
> +   FdwScanPrivateConvertors
> 
> + * Generate attinmeta if there are some converters:
> 
> I think it would be better if converter is spelled the same way across
> the patch.
> 
> For build_conv_list():
> 
> +   if (IS_UPPER_REL(foreignrel))
> 
> You can return NIL for !IS_UPPER_REL(foreignrel) - this would save
> indentation for the body of the func.

Hi.
Updated patch.

-- 
Best regards,
Alexander Pyhalov,
Postgres Professional