Message-ID: <2b002763-f39f-0814-e98e-c48989ddc3c3@gmail.com>
Date: Thu, 6 Apr 2023 16:20:22 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.9.1
Subject: Re: Minimal logical decoding on standbys
Content-Language: en-US
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Jeff Davis <pgsql@j-davis.com>,
 Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>,
 Thomas Munro <thomas.munro@gmail.com>, Ibrar Ahmed <ibrar.ahmad@gmail.com>,
 Amit Khandekar <amitdkhan.pg@gmail.com>, fabriziomello@gmail.com,
 tushar <tushar.ahuja@enterprisedb.com>,
 Rahila Syed <rahila.syed@2ndquadrant.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <ba5aa952-ef8c-b862-69df-0ad9e5d19d23@gmail.com>
 <20230330095449.47yz2q4mn27t6xgl@alvherre.pgsql>
 <CAA4eK1JX-HAmm3TuY=wCSgom+hmiKtkf_xaJLRX9JBo-iXUxHw@mail.gmail.com>
 <CAA4eK1+Tj3B+ODmdRhz7F3fnhang9qEUQatknMuZdi91e=QXeA@mail.gmail.com>
 <68a47e4c-f4bb-45ae-28be-938af60b203c@gmail.com>
 <CAA4eK1L_Zc+7cjm0OhktiPT5xn3=yXn6oenLuEyvJY_CM6T6Mw@mail.gmail.com>
 <e34ab1df-573b-20c1-664a-697851fc736d@gmail.com>
 <CAA4eK1+aUMLu3Q-y6A7nX6kfg_0_6zcRSevWK6Sx6kY1VegCBQ@mail.gmail.com>
 <8c6e7670-3914-35d1-7977-34f60e598477@gmail.com>
 <CAA4eK1+v27a+LONLuRwnzevkp5RuPgsey2VkFB1cfOq2R3XZrA@mail.gmail.com>
 <CAA4eK1+-pdrx3rRD1QCdKcQRaY+B+T3njEXgC3VC3eRAKmDhog@mail.gmail.com>
 <1903ca9b-1dc9-20a6-404a-d4c460c7bdcc@gmail.com>
 <CAA4eK1KFrxgQJt7kc-_o5ruLvafw_FR=NUizA8A7Bp1TDOEj8g@mail.gmail.com>
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
In-Reply-To: 
 <CAA4eK1KFrxgQJt7kc-_o5ruLvafw_FR=NUizA8A7Bp1TDOEj8g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/2b002763-f39f-0814-e98e-c48989ddc3c3%40gmail.com>
Precedence: bulk

Hi,

On 4/6/23 3:39 PM, Amit Kapila wrote:
> On Thu, Apr 6, 2023 at 6:32 PM Drouvot, Bertrand
> <bertranddrouvot.pg@gmail.com> wrote:
>>
>>
>> I don't think it could be possible to create logical walsenders on a standby if
>> AllowCascadeReplication() is not true, or am I missing something?
>>
> 
> Right, so why to even traverse walsenders for that case? What I was
> imagining a code is like:
> if (AllowCascadeReplication())
>      WalSndWakeup(switchedTLI, true);
> 
> Do you see any problem with this change?

Not at all, it looks good to me.

> 
> Few more minor comments on 0005
> =============================
> 0005
> 1.
> +       <para>
> +        Take a snapshot of running transactions and write this to WAL without
> +        having to wait bgwriter or checkpointer to log one.
> 
> /wait bgwriter/wait for bgwriter
> 
> 2.
> +use Test::More tests => 67;
> 
> We no more use the number of tests. Please refer to other similar tests.
> 

Thanks! Will update 0005.

Regards,


-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com