Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rpiSU-008AIV-3s for pgsql-hackers@arkaria.postgresql.org; Thu, 28 Mar 2024 05:37:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rpiSS-008fmz-G7 for pgsql-hackers@arkaria.postgresql.org; Thu, 28 Mar 2024 05:37:48 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rpiSS-008fmr-2V for pgsql-hackers@lists.postgresql.org; Thu, 28 Mar 2024 05:37:48 +0000 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rpiSO-006p4R-4e for pgsql-hackers@postgresql.org; Thu, 28 Mar 2024 05:37:46 +0000 Received: by mail-pj1-x1029.google.com with SMTP id 98e67ed59e1d1-29c75e348afso489841a91.2 for ; Wed, 27 Mar 2024 22:37:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20230601.gappssmtp.com; s=20230601; t=1711604264; x=1712209064; darn=postgresql.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=1PSsYQ5R5+1y48qjD3k14sWQMdeQd3G5QT22kKshzew=; b=E9kloeQLepVvX2AA58ydDLvhs8t2bZppuIG7ihzsrH4P5UWp7mNmTWTiV//wGWiriZ 5WHrQsjQkHkYQgj85Veb5gRr71lSZRAJY3e7VQQfH90/vRT5yQvskOA5Pghxt6CJVI93 /myoRfGdhyYJUvjD1uMR++hRjDkXybbIn9aIfhyHEEIWiGOIuzZp93G8ikJ2bRop2R6r XtcO/N3IQYcbaGGqhZui+jhYoKakAB9QQVi1V818J5r7Of22Hx6vGObEiAU7UOmDCE/N iq0k3ZllsFiaIO/hmW+xsyr7O8yTqTg1iHH3GJRBXc9HGjrVDwlomX+kS/yV8YgUu+Xf fIfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711604264; x=1712209064; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=1PSsYQ5R5+1y48qjD3k14sWQMdeQd3G5QT22kKshzew=; b=G0teOAdkUq3zXNeniRWBMpkXEyLVSf/fYGc3WeIT1joQwHGXUu6HGF9iLxxbAnwMYb rE/czqTCtx73Ggp+dkV+28gypFbImCOXru83jTDX3TNdB7A8hZCmG7nhsOsQnYDs4FhJ In6OeYVdtWsMz8DSpDELLmwyBedXM52GGAbFyMPRAhIgl+BHDun0OsezbZ6PHTfYNHWH qq1YpNLNNBQDK4JVHpYG77CgoiJrVRKvlKYp9fAbkwd7lR3tfuQ1FSiWCrlyZXST0uCf 13NkO1Lw72I6hT//6jE86b7rsed+PN2+61ApWeJ45wfdi5GzT+NZnRq3V3s6v1jcimZj o94A== X-Forwarded-Encrypted: i=1; AJvYcCUqqW1Z/zL5JZ3DtjQi+ZmiPE91EECo3onlVbgWvx6jBmeyKC9SqooqOJDAayizsD9hlJC0WpH7XNaSZc1p3N0O6XZRRep/RpEOEMUa X-Gm-Message-State: AOJu0YyLvYuBwgaErNzc93HNrYV0CLKrSvB9TDpyb8NyLSIH5r9aFEgl mNRRG04DDVf6oa5AcXf/zIJAo0ApFeRD4tbm3f9AvzwouyPWeV0zfqOCPtsfPw== X-Google-Smtp-Source: AGHT+IHhO/bCO0cNmiNhSmHoPYFMtakUciOFbbvY3JGB4qHJrmbM2KRydiZrx7aYZsAYN0sy8AIjVA== X-Received: by 2002:a17:90a:600e:b0:29c:64c9:e27f with SMTP id y14-20020a17090a600e00b0029c64c9e27fmr1608176pji.24.1711604263754; Wed, 27 Mar 2024 22:37:43 -0700 (PDT) Received: from jeff-laptop.lan (c-76-102-242-158.hsd1.ca.comcast.net. [76.102.242.158]) by smtp.gmail.com with ESMTPSA id hk8-20020a17090b224800b0029bde896fb1sm659185pjb.55.2024.03.27.22.37.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 22:37:43 -0700 (PDT) Message-ID: <2b0df3af97fac73a40aba16a58837e2cee594b1f.camel@j-davis.com> Subject: Re: Change GUC hashtable to use simplehash? From: Jeff Davis To: John Naylor Cc: Ants Aasma , Heikki Linnakangas , Junwang Zhao , jian he , Andres Freund , Tom Lane , Gurjeet Singh , pgsql-hackers@postgresql.org Date: Wed, 27 Mar 2024 22:37:41 -0700 In-Reply-To: References: <3786e988-0dc6-4feb-866c-ab5215bf2394@iki.fi> <611843ead9b111c763420bd09bbcb4a330032f8b.camel@j-davis.com> <09924cd6c49935d5e9bba5cd40bec28c605d7c2e.camel@j-davis.com> <48e8f8bbe0be9c789f98776c7438244ab7a7cc63.camel@j-davis.com> <458350a908d9607f7fc2a15407f4405cc454c970.camel@j-davis.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu2 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, 2024-03-27 at 13:44 +0700, John Naylor wrote: > Thanks for the pointers! In v20-0001, I've drafted checking thes > spelling first, since pg_attribute_no_sanitize_alignment has a > similar > version check. Then it checks for no_sanitize_address using > __has_attribute, which goes back to gcc 5. That's plenty for the > buildfarm and CI, and I'm not sure it's worth expending additional > effort to cover more cases. (A similar attribute exists for MSVC in > case it comes up.) 0001 looks good to me, thank you. > v21-0003 adds a new file hashfn_unstable.c for convenience functions > and converts all the duplicate frontend uses of hash_string_pointer. Why not make hash_string() inline, too? I'm fine with it either way, I'm just curious why you went to the trouble to create a new .c file so it didn't have to be inlined. Regards, Jeff Davis