Content-Type: multipart/mixed; boundary="------------sIvM5LgGU3q1n4UueLrUwF0X"
Message-ID: <2b91fbb3-5b49-aec6-22ba-d1cb57185aa4@enterprisedb.com>
Date: Tue, 1 Mar 2022 09:44:29 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.0
Subject: Re: psql: Make SSL info display more compact
Content-Language: en-US
To: Tom Lane <tgl@sss.pgh.pa.us>, Daniel Gustafsson <daniel@yesql.se>
Cc: =?UTF-8?Q?Dagfinn_Ilmari_Manns=c3=a5ker?= <ilmari@ilmari.org>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>
References: <aee28ee7-0ab3-c2e2-5bed-109feb0c089b@enterprisedb.com>
 <D0D58311-5C36-4B6C-9A09-8EC32A0D8A75@yesql.se>
 <87sfs3e04m.fsf@wibble.ilmari.org>
 <f59b3abc-3c42-c627-b7d6-dafd93ac68d9@enterprisedb.com>
 <6E96453E-FD9E-4E04-A829-B7D5F6159279@yesql.se>
 <2510882.1646061162@sss.pgh.pa.us>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <2510882.1646061162@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2b91fbb3-5b49-aec6-22ba-d1cb57185aa4%40enterprisedb.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------sIvM5LgGU3q1n4UueLrUwF0X
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 28.02.22 16:12, Tom Lane wrote:
> Daniel Gustafsson <daniel@yesql.se> writes:
>> On 28 Feb 2022, at 12:56, Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote:
>>> On 28.02.22 11:50, Dagfinn Ilmari Mannsåker wrote:
>>>> How about making it show "compression: on" if compression is on, but
>>>> nothing in the common "off" case?
> 
>>> That would work for me.
> 
>> On POLA grounds I would prefer to never to show it.  If we ever get libpq
>> compression and want to show that, I'd prefer that we didn't end up
>> "compression" meaning one thing except when it means two things.
> 
> Well, any such output would presumably be on a different line and
> thus distinguishable from the SSL property; plus, it'd be impossible
> for both forms to show up in the same connection.
> 
> However, how about writing "SSL compression: on" versus writing
> nothing?  That avoids doubt about what it means.  I don't buy
> Michael's argument that this is ambiguous, either.

I didn't mean to reopen the whole SSL compression can of worms here, I 
was mistaken about the level of support left after PG14.  I was merely 
lightly annoyed that the psql startup display got quite long with not 
very interesting information.

I propose a reduced patch that just removes the "bits" display, since 
that is redundant with the "cipher" display.
--------------sIvM5LgGU3q1n4UueLrUwF0X
Content-Type: text/plain; charset=UTF-8;
 name="v2-0001-psql-Make-SSL-info-display-more-compact.patch"
Content-Disposition: attachment;
 filename="v2-0001-psql-Make-SSL-info-display-more-compact.patch"
Content-Transfer-Encoding: base64

RnJvbSA5NzY4ZGM1YWI5YTAxYTYwZTg5OWJmYzVjOWUxYTUxNDc1ZGVkMTgzIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy
YXV0Lm9yZz4KRGF0ZTogVHVlLCAxIE1hciAyMDIyIDA5OjM4OjM4ICswMTAwClN1YmplY3Q6
IFtQQVRDSCB2Ml0gcHNxbDogTWFrZSBTU0wgaW5mbyBkaXNwbGF5IG1vcmUgY29tcGFjdAoK
UmVtb3ZlIHRoZSBiaXRzIGRpc3BsYXksIHNpbmNlIHRoYXQgY2FuIGJlIGRlcml2ZWQgZnJv
bSB0aGUgY2lwaGVyCnN1aXRlLgotLS0KIHNyYy9iaW4vcHNxbC9jb21tYW5kLmMgfCA1ICst
LS0tCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDQgZGVsZXRpb25zKC0pCgpk
aWZmIC0tZ2l0IGEvc3JjL2Jpbi9wc3FsL2NvbW1hbmQuYyBiL3NyYy9iaW4vcHNxbC9jb21t
YW5kLmMKaW5kZXggMjkyY2ZmNWRmOS4uMDc5ZjRhMWE3NiAxMDA2NDQKLS0tIGEvc3JjL2Jp
bi9wc3FsL2NvbW1hbmQuYworKysgYi9zcmMvYmluL3BzcWwvY29tbWFuZC5jCkBAIC0zNjY3
LDcgKzM2NjcsNiBAQCBwcmludFNTTEluZm8odm9pZCkKIHsKIAljb25zdCBjaGFyICpwcm90
b2NvbDsKIAljb25zdCBjaGFyICpjaXBoZXI7Ci0JY29uc3QgY2hhciAqYml0czsKIAljb25z
dCBjaGFyICpjb21wcmVzc2lvbjsKIAogCWlmICghUFFzc2xJblVzZShwc2V0LmRiKSkKQEAg
LTM2NzUsMTMgKzM2NzQsMTEgQEAgcHJpbnRTU0xJbmZvKHZvaWQpCiAKIAlwcm90b2NvbCA9
IFBRc3NsQXR0cmlidXRlKHBzZXQuZGIsICJwcm90b2NvbCIpOwogCWNpcGhlciA9IFBRc3Ns
QXR0cmlidXRlKHBzZXQuZGIsICJjaXBoZXIiKTsKLQliaXRzID0gUFFzc2xBdHRyaWJ1dGUo
cHNldC5kYiwgImtleV9iaXRzIik7CiAJY29tcHJlc3Npb24gPSBQUXNzbEF0dHJpYnV0ZShw
c2V0LmRiLCAiY29tcHJlc3Npb24iKTsKIAotCXByaW50ZihfKCJTU0wgY29ubmVjdGlvbiAo
cHJvdG9jb2w6ICVzLCBjaXBoZXI6ICVzLCBiaXRzOiAlcywgY29tcHJlc3Npb246ICVzKVxu
IiksCisJcHJpbnRmKF8oIlNTTCBjb25uZWN0aW9uIChwcm90b2NvbDogJXMsIGNpcGhlcjog
JXMsIGNvbXByZXNzaW9uOiAlcylcbiIpLAogCQkgICBwcm90b2NvbCA/IHByb3RvY29sIDog
XygidW5rbm93biIpLAogCQkgICBjaXBoZXIgPyBjaXBoZXIgOiBfKCJ1bmtub3duIiksCi0J
CSAgIGJpdHMgPyBiaXRzIDogXygidW5rbm93biIpLAogCQkgICAoY29tcHJlc3Npb24gJiYg
c3RyY21wKGNvbXByZXNzaW9uLCAib2ZmIikgIT0gMCkgPyBfKCJvbiIpIDogXygib2ZmIikp
OwogfQogCgpiYXNlLWNvbW1pdDogYTMzZTE3ZjIxMDU0NzIyNmFkYTUyZDJiOGFmODUxYzM1
NTNiYjRmYQotLSAKMi4zNS4xCgo=

--------------sIvM5LgGU3q1n4UueLrUwF0X--