Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gYWyG-0005t7-GW for pgsql-hackers@arkaria.postgresql.org; Sun, 16 Dec 2018 14:00:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gYWyE-0001Y5-21 for pgsql-hackers@arkaria.postgresql.org; Sun, 16 Dec 2018 14:00:38 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gYWyD-0001Xi-NF for pgsql-hackers@lists.postgresql.org; Sun, 16 Dec 2018 14:00:37 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gYWyA-0007st-6q for pgsql-hackers@postgresql.org; Sun, 16 Dec 2018 14:00:36 +0000 Received: by mail-wm1-x342.google.com with SMTP id s14so9850040wmh.1 for ; Sun, 16 Dec 2018 06:00:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LkGPURBlQ4cfUuVonDSQy/HNv5pMZ/SXWGTLaGnXiqY=; b=T/TCXkjeDGr/FNEsDHtviJFqNsRuHB6t1ra3iXfak8U2nQXqYjF/0qW6ztp0FL2WTC z4O9kF8nt9wdJTnOFbVQYX5wkz3N5Imw4Zm4hiZuUM7Tvpwhhrn63gY7n0JZ4chWuXPT rSADiC2p+eGWwz8m3DzteZChrvxrx0gGjV1LjN8wQRqvGVbLFhVT7FhaxaNOqR1TbdNm 50xZt6iyPhiuMhr3bMQgnUmA9tkenkmUBVTnCg0ux0UnuCz//d61CR8xiWrsMpBBgbi9 b6OAGMUfFadf3OkumFbRTJ4XjhCCXaDDEuaMlrqkznqtFlsMDb7lOUCIBs45HoJdNtnR g5dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LkGPURBlQ4cfUuVonDSQy/HNv5pMZ/SXWGTLaGnXiqY=; b=j7r6hrVN0j3DC4vG5dSpwRqG101q0s1TIL0Mqq6qrKKFo0J29PibVkv148FQpMVM22 r28qqgdPO4kTzwg3reDGcjhFFyI3LBEY/W8Vt1UUBepmsIBUwn6Z3ONJAfEJakWu+zbo /osrvEDN7UYTcn4CW2rgMjyY1t0MWboAWn+h431DXjVfO6+RXbaOwxx7occeVf3ulHvy v2Z+eKsPMbfH9brAdywFomeucmkxa3/RVIf2bvbGz1ARCqC9Sj5X9nUqcrTyYqtuqk6m tS8JvHsXc5H6/qUWWhWjLcUL1so1Oymzh9wHMzOZKkFjb+ThHkvKPmqlN3NPWuwFFQHU L5Sw== X-Gm-Message-State: AA+aEWYlBU4wKSdqCMXYFYFKJoUymJYdr0KrWueRjFJb8IA8tw2e6jE/ ekBIW20VEutsAE5xEA6uQ6/CWRdHo8rPV3Y3UQAKawIsEz9lIwk9XlLSPxKzpxVDOTXFVyXo4Hl zFwVuT3Bft2NO9rGnTDix/lYlqTfMVvrgkzqbZLfaS9wXUrOFAudNfJAKzHT3GbpK2hfGFiHNTK gdDshKPdIVeT+/dw== X-Google-Smtp-Source: AFSGD/Uj77VgPzHdiEs8mYjxtYToYoXmIx80q1r2E7lbCqywDtumW6V2CHKKu4VG19sxr2kgwZ1PUQ== X-Received: by 2002:a1c:ab87:: with SMTP id u129mr8805312wme.104.1544968831417; Sun, 16 Dec 2018 06:00:31 -0800 (PST) Received: from [10.137.2.19] (ip-86-49-251-50.net.upcbroadband.cz. [86.49.251.50]) by smtp.gmail.com with ESMTPSA id e142sm22488838wmf.46.2018.12.16.06.00.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 16 Dec 2018 06:00:30 -0800 (PST) Subject: Re: [HACKERS] logical decoding of two-phase transactions To: Nikhil Sontakke Cc: Andres Freund , Robert Haas , David Steele , Andrew Dunstan , Simon Riggs , Craig Ringer , Peter Eisentraut , Petr Jelinek , Sokolov Yura , Stas Kelvich , Dmitry Dolgov <9erthalion6@gmail.com>, Tom Lane , Masahiko Sawada , PostgreSQL mailing lists References: <20180719194208.j5m7qhdmqp46d6yg@alap3.anarazel.de> <20180719223500.lclj45aiojikwnwm@alap3.anarazel.de> <20180720145836.gxwhbftuoyx5h4gc@alap3.anarazel.de> <20180723135009.w25re6qxbb7njrbd@alap3.anarazel.de> <20180723141435.ercxxh3bj2uc2mjm@alap3.anarazel.de> <3B37B16B-A473-4352-ABCF-F23AE314D4F7@2ndquadrant.com> <20180726200241.aje4dv4jsv25v4k2@alap3.anarazel.de> From: Tomas Vondra Message-ID: <2ba9c978-ede8-35bf-14ec-45570bf0f6aa@2ndquadrant.com> Date: Sun, 16 Dec 2018 15:00:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Hi Nikhil, Thanks for the updated patch - I've started working on a review, with the hope of getting it committed sometime in 2019-01. But the patch bit-rotted again a bit (probably due to d3c09b9b), which broke the last part. Can you post a fixed version? regards -- Tomas Vondra http://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services