Message-ID: <2bf011b9-4694-429d-bef4-cb18159a6cd6@oss.nttdata.com>
Date: Fri, 11 Oct 2024 00:14:50 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: May be BUG. Periodic burst growth of the checkpoint_req counter
 on replica.
Content-Language: en-US
To: "Anton A. Melnikov" <a.melnikov@postgrespro.ru>,
 Alexander Korotkov <aekorotkov@gmail.com>
Cc: Magnus Hagander <magnus@hagander.net>,
 "Anton A. Melnikov" <aamelnikov@inbox.ru>, Andres Freund
 <andres@anarazel.de>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
 pgsql-hackers@lists.postgresql.org
References: <99b2ccd1-a77a-962a-0837-191cdf56c2b9@inbox.ru>
 <CABUevExav5-SR0x+G9kBUMV0G8XsvSUfuyyqmYBBJi6VHns6sw@mail.gmail.com>
 <CAPpHfdtfDPEy4Pf1n2LvhsQ8ZsE40=OcFf=+U3BAQvfCtdj0MQ@mail.gmail.com>
 <3ed0590b-8132-482e-a9e6-bd694e4a48d7@postgrespro.ru>
 <CAPpHfduFpdq0dUsF=SmTtYit684JoSQrXvzhA+hap-tCA8Z2cA@mail.gmail.com>
 <CAPpHfdss-+EZHUP_MMNm9wHm43+ZM84ERWZvGO+p-5kH_Qt6og@mail.gmail.com>
 <9ea77f40-818d-4841-9dee-158ac8f6e690@oss.nttdata.com>
 <77032579-4dc3-4552-9a09-30aaa114c144@postgrespro.ru>
 <206e58c1-d8f6-4ac3-8f40-7e4c17459473@oss.nttdata.com>
 <a9cbe052-7cd2-46d2-a688-c7b08919db83@postgrespro.ru>
 <82f03b0b-00c6-42b4-95c7-f2eca7fed1ea@oss.nttdata.com>
 <a7f75d42-3a2e-4d70-a1b1-27c8706d2897@postgrespro.ru>
 <4640258e-d959-4cf0-903c-cd02389c3e05@oss.nttdata.com>
 <8e5f353f-8b31-4a8e-9cfa-c037f22b4aee@postgrespro.ru>
 <2adc5283-ae2c-424a-babf-0247eeebf5a3@oss.nttdata.com>
 <d38b5a63-fb0d-43ad-a9a9-456f2bcb1a96@oss.nttdata.com>
 <ec71d37f-ce3f-400a-9260-c2a8bf6f43ee@postgrespro.ru>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: <ec71d37f-ce3f-400a-9260-c2a8bf6f43ee@postgrespro.ru>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/2bf011b9-4694-429d-bef4-cb18159a6cd6%40oss.nttdata.com>
Precedence: bulk


On 2024/10/08 23:16, Anton A. Melnikov wrote:
> 
> On 08.10.2024 15:42, Fujii Masao wrote:
>> On 2024/09/30 12:26, Fujii Masao wrote:
>>>>> In 0002.patch, I also modified the description of num_requested from
>>>>> "Number of backend requested checkpoints" to remove "backend," as it can
>>>>> be confusing since num_requested includes requests from sources other than
>>>>> the backend. Thought?
>>>>
>>>> Agreed. E.g. from xlog. Then maybe changed it also in the function
>>>> descriptions in the pg_proc.dat? For pg_stat_get_checkpointer_num_requested()
>>>> and pg_stat_get_checkpointer_restartpoints_requested().
>>>
>>> Yes, good catch!
>>
>> Patch attached.
> 
> Looked at the patch. Just in case, checked that neither
> “backend completed” nor “backend requested” were found anywhere else.
> All is ok for me.

Thanks for the review! Pushed.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION