Feedback-ID: ic6394509:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-522-ga39cca1d5-fm-20240610.002-ga39cca1d
MIME-Version: 1.0
Message-Id: <2c4c70ef-6567-4f5a-baa0-e16eb9430572@app.fastmail.com>
In-Reply-To: 
 <CAEudQArAr+HiBsMA_mC2=S0ruHjn8123z2DHmyAnCN6j7yDvQQ@mail.gmail.com>
References: <80b16434-b9b1-4c3d-8f28-569f21c2c102@app.fastmail.com>
 <CAEudQArAr+HiBsMA_mC2=S0ruHjn8123z2DHmyAnCN6j7yDvQQ@mail.gmail.com>
Date: Wed, 19 Jun 2024 15:26:03 +0200
From: "Joel Jacobson" <joel@compiler.org>
To: "Ranier Vilela" <ranier.vf@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Add pg_get_acl() function get the ACL for a database object
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/2c4c70ef-6567-4f5a-baa0-e16eb9430572%40app.fastmail.com>
Precedence: bulk

Hi Ranier,

Thanks for looking at this.

I've double-checked the patch I sent, and it works fine.

I think I know the cause of your problem:

Since this is a catalog change, you need to run `make clean`, to ensure =
the catalog is rebuilt,
followed by the usual `make && make install`.

You also need to run `initdb` to create a new database cluster, with the=
 new catalog version.

Let me know if you need more specific instructions.

Best,
Joel

On Wed, Jun 19, 2024, at 14:59, Ranier Vilela wrote:
> Em qua., 19 de jun. de 2024 =C3=A0s 08:35, Joel Jacobson <joel@compile=
r.org>=20
> escreveu:
>> Hello hackers,
>>=20
>> Currently, obtaining the Access Control List (ACL) for a database obj=
ect
>> requires querying specific pg_catalog tables directly, where the user
>> needs to know the name of the ACL column for the object.
>>=20
>> Consider:
>>=20
>> ```
>> CREATE USER test_user;
>> CREATE USER test_owner;
>> CREATE SCHEMA test_schema AUTHORIZATION test_owner;
>> SET ROLE TO test_owner;
>> CREATE TABLE test_schema.test_table ();
>> GRANT SELECT ON TABLE test_schema.test_table TO test_user;
>> ```
>>=20
>> To get the ACL we can do:
>>=20
>> ```
>> SELECT relacl FROM pg_class WHERE oid =3D 'test_schema.test_table'::r=
egclass::oid;
>>=20
>>                          relacl
>> ---------------------------------------------------------
>>  {test_owner=3DarwdDxtm/test_owner,test_user=3Dr/test_owner}
>> ```
>>=20
>> Attached patch adds a new SQL-callable functoin `pg_get_acl()`, so we=
 can do:
>>=20
>> ```
>> SELECT pg_get_acl('pg_class'::regclass, 'test_schema.test_table'::reg=
class::oid);
>>                        pg_get_acl
>> ---------------------------------------------------------
>>  {test_owner=3DarwdDxtm/test_owner,test_user=3Dr/test_owner}
>> ```
>>=20
>> The original idea for this function came from Alvaro Herrera,
>> in this related discussion:
>> https://postgr.es/m/261def6b-226e-4238-b7eb-ff240cb9c2c9@www.fastmail=
.com
>>=20
>> On Thu, Mar 25, 2021, at 16:16, Alvaro Herrera wrote:
>> > On 2021-Mar-25, Joel Jacobson wrote:
>> >
>> >> pg_shdepend doesn't contain the aclitem info though,
>> >> so it won't work for pg_permissions if we want to expose
>> >> privilege_type, is_grantable and grantor.
>> >
>> > Ah, of course -- the only way to obtain the acl columns is by going
>> > through the catalogs individually, so it won't be possible.  I think
>> > this could be fixed with some very simple, quick function pg_get_ac=
l()
>> > that takes a catalog OID and object OID and returns the ACL; then
>> > use aclexplode() to obtain all those details.
>>=20
>> The pg_get_acl() function has been implemented by following
>> the guidance from Alvaro in the related dicussion:
>>=20
>> On Fri, Mar 26, 2021, at 13:43, Alvaro Herrera wrote:
>> > AFAICS the way to do it is like AlterObjectOwner_internal obtains d=
ata
>> > -- first do get_catalog_object_by_oid (gives you the HeapTuple that
>> > represents the object), then
>> > heap_getattr( ..., get_object_attnum_acl(), ..), and there you have=
 the
>> > ACL which you can "explode" (or maybe just return as-is).
>> >
>> > AFAICS if you do this, it's just one cache lookups per object, or
>> > one indexscan for the cases with no by-OID syscache.  It should be =
much
>> > cheaper than the UNION ALL query.  And you use pg_shdepend to guide
>> > this, so you only do it for the objects that you already know are
>> > interesting.
>>=20
>> Many thanks Alvaro for the very helpful instructions.
>>=20
>> This function would then allow users to e.g. create a view to show th=
e privileges
>> for all database objects, like the pg_privileges system view suggeste=
d in the
>> related discussion.
>>=20
>> Tests and docs are added.
> Hi,
> For some reason, the function pg_get_acl, does not exist in generated =
fmgrtab.c
>
> So, when install postgres, the function does not work.
>
> postgres=3D# SELECT pg_get_acl('pg_class'::regclass,=20
> 'atest2'::regclass::oid);
> ERROR:  function pg_get_acl(regclass, oid) does not exist
> LINE 1: SELECT pg_get_acl('pg_class'::regclass, 'atest2'::regclass::...
>                ^
> HINT:  No function matches the given name and argument types. You migh=
t=20
> need to add explicit type casts.
>
> best regards,
> Ranier Vilela

--=20
Kind regards,

Joel