Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1etFw9-0004Zh-Vy
	for pgsql-bugs@arkaria.postgresql.org; Tue, 06 Mar 2018 16:59:38 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-bugs-owner+archive@lists.postgresql.org>)
	id 1etFw8-00074b-27
	for pgsql-bugs@arkaria.postgresql.org; Tue, 06 Mar 2018 16:59:36 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <david@pgmasters.net>)
	id 1etFw7-00074O-P6; Tue, 06 Mar 2018 16:59:35 +0000
Received: from mail.thelabyrinth.net ([45.56.70.56])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <david@pgmasters.net>)
	id 1etFw4-000472-M2; Tue, 06 Mar 2018 16:59:34 +0000
Received: from Davids-iMac.local (unknown [173.169.74.224])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: dsteele)
	by mail.thelabyrinth.net (Postfix) with ESMTPSA id 161E354683;
	Tue,  6 Mar 2018 16:59:31 +0000 (UTC)
Subject: Re: Fwd: [BUGS] pg_trgm word_similarity inconsistencies or bug
To: Teodor Sigaev <teodor@sigaev.ru>,
 Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: Robert Haas <robertmhaas@gmail.com>,
 =?UTF-8?Q?Jan_Przemys=c5=82aw_W=c3=b3jcik?=
 <jan.przemyslaw.wojcik@gmail.com>, Postgres-Bugs
 <pgsql-bugs@postgresql.org>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
 Liudmila Mantrova <l.mantrova@postgrespro.ru>
References: 
 <CY4PR17MB13207ED8310F847CF117EED0D85A0@CY4PR17MB1320.namprd17.prod.outlook.com>
 <20171028082225.GA2157@arthur.localdomain>
 <CAPpHfdtz4a9dTxp-Fpem8uBdSBuOQV_i2xuFyL1tG6zM6nAkpg@mail.gmail.com>
 <CA+YsLFp9scUNjjfYJC=84V9o-ZB66GWPq3e_Jveqs1bNejA4qA@mail.gmail.com>
 <CAPpHfdsDtQJ+pYfapH7GMt9n4RLByKMzHEBWcPL99C_g+rkUKQ@mail.gmail.com>
 <1510059095836-0.post@n3.nabble.com>
 <CA+Tgmobksqi+Kh2=NZarEhnSUAudY=3oc+K8HjqSRvytbw7cnQ@mail.gmail.com>
 <CAPpHfduRG6pXz8RC5TLppV7cpWeNPn0_4nNzX-nT4T6bb6_Y+Q@mail.gmail.com>
 <CAPpHfdtXJp0xvi8QbcHWqnrk=XyyMux4FtbJCgZFPknPbLERVA@mail.gmail.com>
 <42a3a2a4-59b9-c932-3bdf-e346e7b2e406@sigaev.ru>
 <CAPpHfdv1oYVxCmLxyEGNH7vb3Fy2s0xHdv9R_NUy5EHecUqijQ@mail.gmail.com>
 <CAPpHfdsfdC5L0xQ2QwshevbGnoL+L6Ex5B2eJq7FhSzFUqWg2Q@mail.gmail.com>
 <708593ed-1104-a0d2-56b7-097adfdcfc16@pgmasters.net>
 <b7263efb-d291-e51a-88f1-3c0e77711400@sigaev.ru>
From: David Steele <david@pgmasters.net>
Message-ID: <2c90c840-b858-e513-cf9f-e3a04dcb0216@pgmasters.net>
Date: Tue, 6 Mar 2018 11:59:30 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0)
 Gecko/20100101 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <b7263efb-d291-e51a-88f1-3c0e77711400@sigaev.ru>
Content-Type: text/plain; charset=koi8-r
Content-Language: en-US
Content-Transfer-Encoding: 8bit
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Precedence: bulk

On 3/6/18 7:04 AM, Teodor Sigaev wrote:
>> I agree with Teodor (upthread, not quoted here) that the documentation
>> could use some editing.
>>
>> I started to do it myself, but quickly realized I have no knowledge of
>> the content.š I'm afraid I would destroy the meaning while updating the
>> grammar.
>>
>> Anyone understand the subject matter well enough to review the
>> documentation?
> 
> Liudmila tried to improve docs in Alexander's patchset.
> 
> https://www.postgresql.org/message-id/f43b242d-000c-f4c8-cb8b-d37e9752cd93@postgrespro.ru

This looks good to me with a few minor exceptions:

+   <function>word_similarity(text, text)</function> requires further
+   explanation. Consider the following example:

Maybe too verbose?  I think "<function>word_similarity(text,
text)</function> requires further explanation." can be removed entirely.

+   string.  However, this function does not add paddings to the

"add padding"

> BTW, adding Liudmila's message to commitfest task
> (https://commitfest.postgresql.org/17/1403/) doesn't work

Doesn't work for me either.

Alexander, can you post the final patches to the thread so they show up
in the CF app?

Thanks,
-- 
-David
david@pgmasters.net