To: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
From: Konstantin Knizhnik <k.knizhnik@postgrespro.ru>
Subject: readdir is incorrectly implemented at Windows
Message-ID: <2cad7829-8d66-e39c-b937-ac825db5203d@postgrespro.ru>
Date: Mon, 25 Feb 2019 18:38:16 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="------------3D0289F58D2F6B2DCB10C6F4"
Content-Language: en-US
Precedence: bulk

This is a multi-part message in MIME format.
--------------3D0289F58D2F6B2DCB10C6F4
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi hackers,

Small issue with readir implementation for Windows.
Right now it returns ENOENT in case of any error returned by FindFirstFile.
So all places in Postgres where opendir/listdir are used will assume 
that directory is empty and
do nothing without reporting any error.
It is not so good if directory is actually not empty but there are not 
enough permissions for accessing the directory and FindFirstFile
returns ERROR_ACCESS_DENIED:

struct dirent *
readdir(DIR *d)
{
     WIN32_FIND_DATA fd;

     if (d->handle == INVALID_HANDLE_VALUE)
     {
         d->handle = FindFirstFile(d->dirname, &fd);
         if (d->handle == INVALID_HANDLE_VALUE)
         {
             errno = ENOENT;
             return NULL;
         }
     }


Attached please find small patch fixing the problem.

-- 
Konstantin Knizhnik
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company


--------------3D0289F58D2F6B2DCB10C6F4
Content-Type: text/x-patch;
 name="dirent.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="dirent.patch"

diff --git a/src/port/dirent.c b/src/port/dirent.c
index 7a91450..284bf27 100644
--- a/src/port/dirent.c
+++ b/src/port/dirent.c
@@ -83,7 +83,13 @@ readdir(DIR *d)
 		d->handle = FindFirstFile(d->dirname, &fd);
 		if (d->handle == INVALID_HANDLE_VALUE)
 		{
-			errno = ENOENT;
+			if (GetLastError() == ERROR_FILE_NOT_FOUND)
+			{
+				/* No more files, force errno=0 (unlike mingw) */
+				errno = 0;
+				return NULL;
+			}
+			_dosmaperr(GetLastError());
 			return NULL;
 		}
 	}

--------------3D0289F58D2F6B2DCB10C6F4--