Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nMzdn-0005I6-SJ for pgsql-hackers@arkaria.postgresql.org; Wed, 23 Feb 2022 21:57:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nMzdH-0001jz-0z for pgsql-hackers@arkaria.postgresql.org; Wed, 23 Feb 2022 21:57:11 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nMzdG-0001jp-OB for pgsql-hackers@lists.postgresql.org; Wed, 23 Feb 2022 21:57:10 +0000 Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nMzdE-00013q-4N for pgsql-hackers@postgresql.org; Wed, 23 Feb 2022 21:57:09 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id 50806E0003; Wed, 23 Feb 2022 21:57:03 +0000 (UTC) Message-ID: <2cdcc738-beda-a2ea-d26e-24fbb390bd4e@dunslane.net> Date: Wed, 23 Feb 2022 16:57:02 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: convert libpq uri-regress tests to tap test Content-Language: en-US To: Andres Freund , Tom Lane Cc: pgsql-hackers@postgresql.org References: <20220223203031.ezrd73ohvjgfksow@alap3.anarazel.de> <0b8719b8-f339-ebc0-781a-737db158b671@dunslane.net> <1251254.1645649828@sss.pgh.pa.us> <20220223211606.ikcwoolsz2nohsw6@alap3.anarazel.de> From: Andrew Dunstan In-Reply-To: <20220223211606.ikcwoolsz2nohsw6@alap3.anarazel.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2/23/22 16:16, Andres Freund wrote: > Hi, > > On 2022-02-23 15:57:08 -0500, Tom Lane wrote: >> Andrew Dunstan writes: >>> On 2/23/22 15:30, Andres Freund wrote: >>>> Perhaps we should just rename src/test/modules/libpq_pipeline to >>>> src/test/modules/libpq and move uri-regress in there as well? >>> WFM >> +1 > Cool. > > > One question on making that happen: Right now the makefiles building C stuff > in src/test/modules all have the contrib-style stanza to build via pgxs. But > afaics pgxs doesn't support building multiple programs. Which > src/test/modules/libpq would need to. That's my understanding also. > > Aaics there's currently no way to have Mkvcbuild.pm build multiple programs in > one dir via its makefile parsing stuff? Andrew, any suggestions for not > needing to spell this out in both the makefile and Mkvcbuild.pm? Well, it should be a SMOC. If you can solve the first problem I'm sure I can come up with a solution for Mkvcbuild.pm. But until we see the shape of the pgxs changes, planning for Mkcvbuild.pm changes seems remature. > > > Separately: I don't really understand why we do the whole if USE_PGXS dance in > src/test/modules? > ENOCLUE cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com