Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qVYFO-000XCT-9A for pgsql-hackers@arkaria.postgresql.org; Mon, 14 Aug 2023 14:08:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qVYFM-004qjn-Vz for pgsql-hackers@arkaria.postgresql.org; Mon, 14 Aug 2023 14:08:41 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qVYFM-004qi6-LA for pgsql-hackers@lists.postgresql.org; Mon, 14 Aug 2023 14:08:40 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qVYFK-0006YG-HN for pgsql-hackers@postgresql.org; Mon, 14 Aug 2023 14:08:40 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 336F032008C0; Mon, 14 Aug 2023 10:08:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 14 Aug 2023 10:08:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to; s=fm3; t=1692022114; x=1692108514; bh=qN157bOw6Is1wZi+QxN+ng70D yzKNkxz/Yw1bz9+0Js=; b=KHMn7ywqiWArkOFj6hFwh4uX+z2KbCwriVYVN7Rvv JfEK3t6edrve5KGjEraCXW6Z6mZ68BROEm0jKFPBfpsfB11RcM2a8BWKjwLfrmud /ieFQUf2c6flCr9tTlIEdX+3X/UmccHoDQTwd3BrFA4NWzh7T2hZwWdz7bm4Bqil eP8WEYwOtjZpQ3xFb0BpIhbc28CFoWTfby6xC2JD1XlBlh8oTT4SRcMg1P+XAzEG scG+I514rxDA1yRIkoovJmEorc71a5rBfbH3JzA5BeqAtdWaMYmf4FGvpwKNE6zC peI3nL2kk8drqY85BnOajjTLwjk2xFsULEuOf4vu4bqsg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1692022114; x=1692108514; bh=qN157bOw6Is1wZi+QxN+ng70DyzKNkxz/Yw 1bz9+0Js=; b=PjqRW7JZq2Z4K6/bdxP9NYmVEydx0Jtbiw7jmuYhIKJqnS2N7DP ZE7E/+gtMMYeEx/r33ZaFRW6DtV/mg984CfGYnvMLXDC+do9+nxJUnKaenIkfHMi whsBmbzV9G1xkOlscuh16gyUfG44pQcTx+0ZAiwRW+4SN1cyv0IfdEwRcqWAwXdX yQtMivFtCYjBlIkpT89Ao3MYDzs/rAO2TP33oiyImXvqCoaeZVITwfZF0uch+tvH +gp1Ki5lV5XHQAITUT5Xi4idPrmay1stGJQDVoZxFQHOPyPGppFytQ/BezIfM2oG xQmPZ7Pi4Mew4ZcVYKPgpWj55yW3OciHEjw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddtgedgjeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpefrvght vghrucfgihhsvghnthhrrghuthcuoehpvghtvghrsegvihhsvghnthhrrghuthdrohhrgh eqnecuggftrfgrthhtvghrnhepheeiuefhleelfeeikeehkefgkeeggfevheeuvdejveet tdegleekffffieekuedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepphgvthgvrhesvghishgvnhhtrhgruhhtrdhorhhg X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 14 Aug 2023 10:08:31 -0400 (EDT) Message-ID: <2d50ef0e-d1dd-4e13-c951-44fcdcf25759@eisentraut.org> Date: Mon, 14 Aug 2023 16:08:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: run pgindent on a regular basis / scripted manner Content-Language: en-US To: Tom Lane , Andres Freund Cc: Peter Geoghegan , Andrew Dunstan , Jelte Fennema , Michael Paquier , "shiy.fnst@fujitsu.com" , Robert Haas , Justin Pryzby , Noah Misch , Bruce Momjian , Magnus Hagander , Alvaro Herrera , Stephen Frost , Jesse Zhang , "pgsql-hackers@postgresql.org" , Peter Eisentraut References: <582c503b-cd98-1891-ff87-9c8e8ce73ee5@dunslane.net> <30a72ba4-9ca4-15b5-db0f-0e68cba7ab26@dunslane.net> <1f594a4b-14c8-e159-b250-edf8a091320d@dunslane.net> <20230811212511.aih23qfthi24zhq4@awork3.anarazel.de> <338202.1691793002@sss.pgh.pa.us> <20230811232024.4prbiiklqwcclgnw@awork3.anarazel.de> <349543.1691799094@sss.pgh.pa.us> From: Peter Eisentraut In-Reply-To: <349543.1691799094@sss.pgh.pa.us> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 12.08.23 02:11, Tom Lane wrote: > Andres Freund writes: >> On 2023-08-11 18:30:02 -0400, Tom Lane wrote: >>> +1 for including this in CI tests > >> I didn't even mean CI - I meant 'make check-world' / 'meson test'. Which of >> course would include CI automatically. > > Hmm. I'm allergic to anything that significantly increases the cost > of check-world, and this seems like it'd do that. > > Maybe we could automate it, but not as part of check-world per se? Also, during development, the code in progress is not always perfectly formatted, but I do want to keep running the test suites.