Message-ID: <2d7d47ef-98a3-47ff-9564-c4c4f7b0889f@gmail.com>
Date: Sun, 19 Apr 2026 22:00:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Typos in the code and README
From: Alexander Lakhin <exclusion@gmail.com>
To: Michael Paquier <michael@paquier.xyz>, David Rowley <dgrowleyml@gmail.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
References: 
 <CAN55FZ1YsO7e7Wr_49gi=2ne+Ov_YPY6q0EE-OxCJ1kWSJfEwg@mail.gmail.com>
 <D18650AE-65BF-431D-9FE0-6AD118F757A3@yesql.se>
 <CAApHDvq-2Zdqytm_Hf3RmVf0qg5PS9jTFAJ5QTc9xH9pwvwDTA@mail.gmail.com>
 <CAApHDvr3zgeb+2cQTsbyRcV2ZkjeMiHyDXYSWB5z71WwSyxwDA@mail.gmail.com>
 <ae9f2fcb-4b24-5bb0-4240-efbbbd944ca1@gmail.com>
 <CAApHDvq7chgw8=7TU4-hLpQNw8e7qN9_oA4ew2UH05RCcihEDQ@mail.gmail.com>
 <c1d63754-cb85-2d8a-8409-bde2c4d2d04b@gmail.com>
 <CAApHDvoYsiFkZpjWeLGejibAXi=T3B70MzFr7z-1EiJ4pVX2hA@mail.gmail.com>
 <f7e514cf-2446-21f1-a5d2-8c089a6e2168@gmail.com>
 <ZtadkEfXje7zvOs4@paquier.xyz> <Ztaj7BkN4658OMxF@paquier.xyz>
 <5812a0b9-b0cf-4151-9a14-d9f00e4f2858@gmail.com>
Content-Language: en-US
In-Reply-To: <5812a0b9-b0cf-4151-9a14-d9f00e4f2858@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/2d7d47ef-98a3-47ff-9564-c4c4f7b0889f%40gmail.com>
Precedence: bulk

Hello hackers,

Please look at another set of typos and inconsistencies introduced since
2026-01-01:
AttNumber -> AttrNumber

attytypids, attytypmods -> atttypids, atttypmods

AX handle  -> AH handle

big5_to_mic -> remove
(following 77645d44e)

bk_category -> bkcategory
(per postmaster/proctypelist.h)

BufferLockRelease -> BufferLockReleaseSub

build_index_scan -> build_index_scankeys

cacheoffset -> attcacheoff
(see index_getattr())

containg -> containing

Controlfile -> ControlFile

DataChecksumShmemRequest -> DataChecksumsShmemRequest

DataChecksumsLauncher -> DataChecksumsWorkerLauncherMain
(DataChecksumsWorkerLauncherMain() calls SetDataChecksumsOn(), which calls
EmitProcSignalBarrier())

Datachecksumsworker -> DataChecksumsWorker

dc_fake_temptable, dc_modify_db_result -> remove
(the implementation was removed in 07009121c)

determing -> determining

doublecheck -> double-check

Doublecheck -> Double-check

element_patterns -> path_pattern
(align with the implementation)

endTruncOff, endTruncMemb -> oldestMulti, oldestOffset
(align with the implementation)

expr_nulls[]  -> remove
(exprs_nulls[] was removed in
v2jsonb-0001-Add-support-for-exprs-in-pg_restore_extended.patch [1])

forPortionOfClause -> forPortionOf
(align with the implementation)

HeaptupleSatisfiesMVCC -> HeapTupleSatisfiesMVCC

hintbits -> hint bits

hostsfile -> hosts file

idenifier -> identifier

io_worker_launch_delay -> io_worker_launch_interval
(named io_worker_launch_delay in [2], but this name is absent in
v7-0001-aio-Adjust-I-O-worker-pool-size-automatically.patch attached
there)

load_from_disk_pending -> stashes_ready
(cf. "if (pg_atomic_unlocked_test_flag(&pgsa_state->stashes_ready))"
below)

LockManagerShmemSize -> remove the referencing sentence?
(following 9b5acad3f)

nonprivileged -> non-privileged

option_values -> option_value

oveflows -> overflows

path_pattern_lists -> path_elem_lists

paralell -> parallel

pg_buffercache_mark_dirt_relation -> pg_buffercache_mark_dirty_relation

pgpa_relation_identifier -> pgpa_identifier

pgstat_activity -> pg_stat_activity

pg_statistic.ext_data -> pg_statistic_ext_data

precalculated -> pre-calculated

PredicateLockShmemSize -> remove the referencing sentence?
(following 2e0943a85)

queryID -> Query ID

rel_dst -> cc_rel
(rel_dst existed in
v25-0004-Add-CONCURRENTLY-option-to-REPACK-command.patch [3], but then got
transformed into dest->rel in v26 [4] and then renamed to cc_rel)

relfrozen -> relfrozenxid
(as in other occurrences "relfrozenxid/relminmxid")

replorigin_session_origin -> replorigin_xact_state.origin

ResOwnerReleaseBufferPin -> ResOwnerReleaseBuffer
(see fcb9c977a)

RewriteGraphTable -> rewriteGraphTable

RTEkind -> RTE kind

SetHintBitExt -> SetHintBitsExt

signedess -> signedness

statsare -> stats are

SubPlanInfo -> SubPlanRTInfo

SubRTInfo -> SubPlanRTInfo

subsystemslist.h -> subsystemlist.h

swicthed -> switched

tablespacenames -> tablespace names

TABLE_UPDATE_WAIT -> remove the mention
("#define TABLE_UPDATE_WAIT" existed in
v46-0002-Add-CONCURRENTLY-option-to-REPACK-command.patch, but it was
removed in v47 [6].)

targetExpr -> targetRange
(see the code below)

testcluster -> test cluster

themself -> themselves

tkeys -> rids

truncation_block -> truncation_block_length

tupleTableSlot -> TupleTableSlot

VacAttrStatP -> VacAttrStatsP

XLOGShmemSize -> XLOGShmemRequest
(XLOGShmemRequest modifies wal_buffers)


[1] https://www.postgresql.org/message-id/CADkLM%3Ddu%2BOcctrsTk%2BhZryUGy%3D0OnPep-3LdGzut1nqF391%2BEg%40mail.gmail.com
[2] https://www.postgresql.org/message-id/CA%2BhUKGK%3DvELXFXNj2L%3DvTkof6s_EQzTjYXXrUVwOOW0rahEfVg%40mail.gmail.com
[3] https://www.postgresql.org/message-id/202510301734.pj4uds3mqxx4%40alvherre.pgsql
[4] https://www.postgresql.org/message-id/116433.1764870207%40localhost
[5] https://www.postgresql.org/message-id/202603292157.tnqxaozfjlkh%40alvherre.pgsql
[6] https://www.postgresql.org/message-id/202603311523.iqhng5ljkzpq%40alvherre.pgsql

Best regards,
Alexander