Subject: Re: Re: query logging of prepared statements
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Arthur Zakirov <a.zakirov@postgrespro.ru>, pgsql-hackers@postgresql.org
References: <20190208132953.GF29720@telsasoft.com>
 <20190215145704.GW30291@telsasoft.com> <20190227180653.GF28750@telsasoft.com>
 <70868e0d-2a29-36c8-e3e2-f54a56804bc4@postgrespro.ru>
 <20190304183150.GK29584@telsasoft.com>
 <345f3504-e3cd-3a01-c593-ebbbe555dd69@postgrespro.ru>
From: David Steele <david@pgmasters.net>
Message-ID: <2da70a91-2a22-9d78-84ba-cba4b71c7541@pgmasters.net>
Date: Wed, 20 Mar 2019 14:46:00 +0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0)
 Gecko/20100101 Thunderbird/60.5.3
MIME-Version: 1.0
In-Reply-To: <345f3504-e3cd-3a01-c593-ebbbe555dd69@postgrespro.ru>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Justin,

On 3/5/19 2:30 PM, Arthur Zakirov wrote:
> On 04.03.2019 21:31, Justin Pryzby wrote:
>> It wasn't intentional.  Find attached v3 patch which handles that case,
>> by removing the 2nd call to errdetail_execute() ; since it's otherwise 
>> unused,
>> so remove that function entirely.
> 
> Thank you.
> 
>> Thanks for reviewing.  I'm also interested in discussion about whether 
>> this
>> change is undesirable for someone else for some reason ?  For me, the 
>> existing
>> output seems duplicative and "denormalized".  :)
> 
> I perfectly understand your use case. I agree, it is duplicated. But I 
> think some people may want to see it at every EXECUTE, if they don't 
> want to grep for the prepared statement body which was logged earlier.
> 
> I think it would be good to give possibility to configure this behavior. 
> At first version of your patch you relied on log_error_verbosity GUC. 
> I'm not sure that this variables is suitable for configuring visibility 
> of prepared statement body in logs, because it sets more general 
> behavior. Maybe it would be better to introduce some new GUC variable if 
> the community don't mind.
Thoughts on this?

Regards,
-- 
-David
david@pgmasters.net