Subject: Re: Proposal: Save user's original authenticated identity for logging
To: Michael Paquier <michael@paquier.xyz>
Cc: Jacob Champion <pchampion@vmware.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
References: <4a87886f034c713c056c43850f55e6e0ba50d8b5.camel@vmware.com>
 <YGJ3FoOfgSao9Cv8@paquier.xyz>
 <e0f0484a1815b26bb99ef9ddc7a110dfd6425931.camel@vmware.com>
 <a4fddbcd2f99c293991b7669bd0da3e5a7d3f93b.camel@vmware.com>
 <YGQk74rdCdb8F9gZ@paquier.xyz> <YGUgHMF9zxNvY323@paquier.xyz>
 <d17b919e27474abfa55d97786cb9cfadfe2b59e9.camel@vmware.com>
 <YGaha/euiRjZ820X@paquier.xyz> <YGhf4TN6ukOZTUcd@paquier.xyz>
 <ae1143fb-455c-c80f-ed66-78d45bd93303@enterprisedb.com>
 <YUrdnoEc4NPfBZfI@paquier.xyz>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Message-ID: <2dba8b35-c607-ae30-07d2-610886aff897@enterprisedb.com>
Date: Wed, 22 Sep 2021 10:20:47 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <YUrdnoEc4NPfBZfI@paquier.xyz>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/2dba8b35-c607-ae30-07d2-610886aff897%40enterprisedb.com>
Precedence: bulk

On 22.09.21 09:39, Michael Paquier wrote:
> On Wed, Sep 22, 2021 at 08:59:38AM +0200, Peter Eisentraut wrote:
>> I noticed this patch eliminated one $Test::Builder::Level assignment. Was
>> there a reason for this?
>>
>> I think we should add it back, and also add a few missing ones in similar
>> places.  See attached patch.
>>
>> [...]
>>
>>   {
>> +	local $Test::Builder::Level = $Test::Builder::Level + 1;
>> +
> 
> So you are referring to this one removed in c50624c.  In what does
> this addition change things compared to what has been added in
> connect_ok() and connect_fails()?  I am pretty sure that I have
> removed this one because this logic got refactored in
> PostgresNode.pm.

This should be added to each level of a function call that represents a 
test.  This ensures that when a test fails, the line number points to 
the top-level location of the test_role() call.  Otherwise it would 
point to the connect_ok() call inside test_role().