Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rhrrk-00DlTS-8S for pgsql-hackers@arkaria.postgresql.org; Wed, 06 Mar 2024 14:03:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rhrri-00AXRT-Sw for pgsql-hackers@arkaria.postgresql.org; Wed, 06 Mar 2024 14:03:27 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rhrri-00AXKz-I3 for pgsql-hackers@lists.postgresql.org; Wed, 06 Mar 2024 14:03:27 +0000 Received: from mail1.dalibo.net ([51.159.93.128] helo=mail.dalibo.com) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rhrrf-0039Mm-7M for pgsql-hackers@lists.postgresql.org; Wed, 06 Mar 2024 14:03:25 +0000 Received: from [192.168.0.29] (unknown [78.201.30.201]) by mail.dalibo.com (Postfix) with ESMTPSA id 4363020116; Wed, 6 Mar 2024 15:03:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=dalibo.com; s=a; t=1709733801; bh=z1yQGKNzAnKUzksQ9fVa58hNYvu3Ya14EIZxBkihAOA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=TgPfKWbT+harwAJNg7+CFMQl9/cDQ5UVb29muw2X1cw5L3QTvWinSTjY3hY4aZ+Nl 8QBdQpii/pvAlaGsBgfElDHI6+7qrC3m0vozzQfu1Btid8LjPrXFXtGlqpvgH0rcGN TK6w8splKBLvBTSo65ycSpjm4HpFnFl8fWM6UETE= Content-Type: multipart/mixed; boundary="------------pDk7XOfQr6qOHn7Px7aaeBN0" Message-ID: <2e2933ad-86b4-4fea-8876-5fcc0307e97c@dalibo.com> Date: Wed, 6 Mar 2024 15:03:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [EXTERNAL] Re: Add non-blocking version of PQcancel To: Jelte Fennema-Nio , Alvaro Herrera Cc: vignesh C , Thomas Munro , Greg Stark , Tom Lane , "Gregory Stark (as CFM)" , Jelte Fennema , Daniel Gustafsson , Peter Eisentraut , Andres Freund , Justin Pryzby , Robert Haas , "pgsql-hackers@lists.postgresql.org" References: <202402141741.bifigsqxbj2m@alvherre.pgsql> Content-Language: fr, en-GB From: Denis Laxalde Autocrypt: addr=denis.laxalde@dalibo.com; keydata= xsBNBF5BdOABCACxKIHRx6IXguREkJ3mqzFpD2v5RFY1XpUfc3ui0NHgM7lfCNuAcLWxgjw5 gqWqp+y468G/Cp9mziAERMJQouEUPJ/qKqSpb6IjZlCdUNoteAaGrLIDXziICnEfjSJaN/Hf VjayetpRWvDprJ+aQylAqwJ5HjdBf9pONZ6HA2pLPPqYUnhM8ATvaB3nex7m8FN0AEWe4/1F tZqyWxIVBG6C4b5932N5HbVx5ZveRqo6v+0UQS9CROSJpUKMJ41t9VfstB2OT1wO17duwlYl kkjz7OnPflZ7XlKX4BC9vQUVs6mZTKZ3nkUh8tkQcWmyQJMLfTxJJWJehxICUIGx8gulABEB AAHNKERlbmlzIExheGFsZGUgPGRlbmlzLmxheGFsZGVAZGFsaWJvLmNvbT7CwJQEEwEKAD4C GwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AWIQQyMcMMipT0cvqTrwEKaI6MiNZPTQUCZF37 MQUJB/250QAKCRAKaI6MiNZPTf/0B/9usE5ZhM5C5Br27i8XMC6Ai7+N6E9TBizDLFwvVrBt rpP5E7O6Goa0v59pCw1Et600vEOVmt5LzTMMm0hK2zEJ91d95Dw0kKIxW88bq8WlAZlgnEIY 05DwkaLoZolggVEsjnqNlFW9yS4xh5TWNkAW0HDYcjiWcmifMi0LnoP3kEA1Mm/JqBO7MJ24 jPDf1YMVX96tX/zg6Z2ssBFwYm0yA7YQdhersh4USRMuazAksjTqxfuPITYGA6BCepTcrT0e ncN9E8385ib8RtwPhgsc98FqAMNNuKCjRJMnmk4zrZCISNN+tT2/xMXS5XfOBSPOAZ5j0a9d uTV3oPN+QxQYzsBNBF5BdOABCADerP5NXOtW8Vmpcqd2qMvhnlC8kF1vH81qY+DrBqhDxfUX AH/WfGqquY7HIoNDa5Axo4eUGV5XfWgT901hh6OqcBp+8hqkEd51ugQAw4z0nQkG0qKprgSd EPElUst7NPvq4gguShOpFlxR+tPfkOsL6Ck9eQ6fJDTsdJg0J7XpeSeFamJTrjKy5quFuoUE C97Am9T4pKoiNewBSt5JZF1sYw07Kxkjpj3cVHls5NjcgM9I/MelPbhLeY8DSpaegb6vAiMZ mUB5ZjGI2HKb/3uZbAhgjcIlZ0LMmDBZCh282V/NqeejEjG2GD9FiCA2LD3kcgg1nnXNSBGd B8lEL+5ZABEBAAHCwHwEGAEKACYCGwwWIQQyMcMMipT0cvqTrwEKaI6MiNZPTQUCZF37RQUJ B/255QAKCRAKaI6MiNZPTQRkCACWmXYomPXx9c1ARZYXVP8Ot4XZ024l00wWnCcMpJcXLohX WidddCTG4iI2NsdB12Yy0QmPY6fVanx+JVxn9e1Zv2DwbR2vSgOcMDptMGSWRG+zJpPzJtwh ueG0pAr2GKaq0hWUv1x2ZRIfdgaOJkokY1Na/zJjoQsItfwPp7BCIvTD66Aoxa41AtJenzeY pA8EY8GuLSqfnMWdzG3B4fbxLAD4AfhM84LWynqvv7qzKK5jMr5O6IMZe676sZQN61Jv6s80 X302in7pUf/i7TA1qG2zkswtZy/q0a1SQMXD4v2S3CQO7WVyKG88A7H1z6pe3Jdnr0IIyPs5 EQHI8j4H In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------pDk7XOfQr6qOHn7Px7aaeBN0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit In patch 0004, I noticed a couple of typos in the documentation; please find attached a fixup patch correcting these. Still in the documentation, same patch, the last paragraph documenting PQcancelPoll() ends as: + indicate the current stage of the connection procedure and might be useful + to provide feedback to the user for example. These statuses are: + while not actually listing the "statuses". Should we list them? Adjust the wording? Or refer to PQconnectPoll() documentation (since the paragraph is copied from there it seems)? Otherwise, the feature still works fine as far as I can tell. --------------pDk7XOfQr6qOHn7Px7aaeBN0 Content-Type: text/x-patch; charset=UTF-8; name="0001-fixup-libpq-Add-encrypted-and-non-blocking-versions-.patch" Content-Disposition: attachment; filename*0="0001-fixup-libpq-Add-encrypted-and-non-blocking-versions-.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAzZTA0NDQyZTNmMjgzODI5ZWQzOGU0YTJiNDM1ZmQxODJhZGRmODdhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBEZW5pcyBMYXhhbGRlIDxkZW5pcy5sYXhhbGRlQGRh bGliby5jb20+CkRhdGU6IFdlZCwgNiBNYXIgMjAyNCAxNDo1NTo0MCArMDEwMApTdWJqZWN0 OiBbUEFUQ0hdIGZpeHVwISBsaWJwcTogQWRkIGVuY3J5cHRlZCBhbmQgbm9uLWJsb2NraW5n IHZlcnNpb25zIG9mCiBQUWNhbmNlbAoKLS0tCiBkb2Mvc3JjL3NnbWwvbGlicHEuc2dtbCAg ICAgICAgICB8IDIgKy0KIHNyYy9pbnRlcmZhY2VzL2xpYnBxL2ZlLWNhbmNlbC5jIHwgMiAr LQogMiBmaWxlcyBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvZG9jL3NyYy9zZ21sL2xpYnBxLnNnbWwgYi9kb2Mvc3JjL3NnbWwvbGli cHEuc2dtbAppbmRleCAxNjEzZmNjN2JiLi4xMjgxY2FjMjg0IDEwMDY0NAotLS0gYS9kb2Mv c3JjL3NnbWwvbGlicHEuc2dtbAorKysgYi9kb2Mvc3JjL3NnbWwvbGlicHEuc2dtbApAQCAt NjEyMiw3ICs2MTIyLDcgQEAgUG9zdGdyZXNQb2xsaW5nU3RhdHVzVHlwZSBQUWNhbmNlbFBv bGwoUEdjYW5jZWxDb25uICpjYW5jZWxDb25uKTsKICAgICAgIDxwYXJhPgogICAgICAgIFRo ZSByZXF1ZXN0IGlzIG1hZGUgb3ZlciB0aGUgZ2l2ZW4gPHN0cnVjdG5hbWU+UEdjYW5jZWxD b25uPC9zdHJ1Y3RuYW1lPiwKICAgICAgICB3aGljaCBuZWVkcyB0byBiZSBjcmVhdGVkIHdp dGggPHhyZWYgbGlua2VuZD0ibGlicHEtUFFjYW5jZWxDb25uIi8+LgotICAgICAgIFRoZSBy ZXR1cm4gdmFsdWUgb2YgPHhyZWYgbGlua2VuZD0ibGlicHEtUFFjYW5jZWxCbG9ja2luZyIv PgorICAgICAgIFRoZSByZXR1cm4gdmFsdWUgb2YgPHhyZWYgbGlua2VuZD0ibGlicHEtUFFj YW5jZWxTdGFydCIvPgogICAgICAgIGlzIDEgaWYgdGhlIGNhbmNlbGxhdGlvbiByZXF1ZXN0 IGNvdWxkIGJlIHN0YXJ0ZWQgYW5kIDAgaWYgbm90LgogICAgICAgIElmIGl0IHdhcyB1bnN1 Y2Nlc3NmdWwsIHRoZSBlcnJvciBtZXNzYWdlIGNhbiBiZQogICAgICAgIHJldHJpZXZlZCB1 c2luZyA8eHJlZiBsaW5rZW5kPSJsaWJwcS1QUWNhbmNlbEVycm9yTWVzc2FnZSIvPi4KZGlm ZiAtLWdpdCBhL3NyYy9pbnRlcmZhY2VzL2xpYnBxL2ZlLWNhbmNlbC5jIGIvc3JjL2ludGVy ZmFjZXMvbGlicHEvZmUtY2FuY2VsLmMKaW5kZXggZTY2Yjg4MTllZS4uOWM5YTIzYmI0ZCAx MDA2NDQKLS0tIGEvc3JjL2ludGVyZmFjZXMvbGlicHEvZmUtY2FuY2VsLmMKKysrIGIvc3Jj L2ludGVyZmFjZXMvbGlicHEvZmUtY2FuY2VsLmMKQEAgLTE0Niw3ICsxNDYsNyBAQCBQUWNh bmNlbEJsb2NraW5nKFBHY2FuY2VsQ29ubiAqY2FuY2VsQ29ubikKIC8qCiAgKgkJUFFjYW5j ZWxTdGFydAogICoKLSAqIFN0YXJ0cyBzZW5kaW5nIGEgY2FuY2VsbGF0aW9uIHJlcXVlc3Qg aW4gYSBibG9ja2luZyBmYXNoaW9uLiBSZXR1cm5zCisgKiBTdGFydHMgc2VuZGluZyBhIGNh bmNlbGxhdGlvbiByZXF1ZXN0IGluIGEgbm9uLWJsb2NraW5nIGZhc2hpb24uIFJldHVybnMK ICAqIDEgaWYgc3VjY2Vzc2Z1bCAwIGlmIG5vdC4KICAqLwogaW50Ci0tIAoyLjM5LjIKCg== --------------pDk7XOfQr6qOHn7Px7aaeBN0--