Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sqZgW-00AsYc-HO for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Sep 2024 15:00:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sqZgV-00C4wp-W2 for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Sep 2024 15:00:08 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sqZgV-00C4we-If for pgsql-hackers@lists.postgresql.org; Tue, 17 Sep 2024 15:00:07 +0000 Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1sqZgS-001eo9-SM for pgsql-hackers@postgresql.org; Tue, 17 Sep 2024 15:00:06 +0000 Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2f77be8ffecso63461251fa.1 for ; Tue, 17 Sep 2024 08:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726585203; x=1727190003; darn=postgresql.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QeK/nOQT7H6uM/YJxoQi9/x8InmXNee/1W9dVL5Cd0c=; b=NKd8yQt2672908txXadDFo5Rl3SvnLOkuoeVGYwD39QDyEiHG1giOtmqv9CBXij9BZ AzbZSd7J3QG1u3ltjDvWua4xf2E/pa2xV7JF4sxzSocnv82c4R8kDeWvFkJsSAqcrjlT DcOaQ03GBTOLQPTa362eA/ShMPnGckx/VGQEbIXpKvcwv3afx/EO35R3sqlzs6Xr/izT 6zUHrn9ZJL9p/EBOX0cLmHqVYSMBYDHkFU3xzRapfg5P+Rz8gBPkKA64+fEsmsXhh4OV k4NK5PbAWrpFn/UhjSWz+RiHsBfomEfZBQyfI9q+qLxX4XY/B5MGyZf3UXXFt/EvG+Cp L6gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726585203; x=1727190003; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QeK/nOQT7H6uM/YJxoQi9/x8InmXNee/1W9dVL5Cd0c=; b=iRhTVITgyMVHQ8zVpr3+lgTxaprhn3D88UYoJ2dAA3JExDhxWocTEUr5jm5r0cTOiy PCZ/mXZNutJQEJglTvxR3Nq6U1Ckri9PWVsXH6wF8+hvNJ6yLvEBL4u+lHsJIH8JFgWs KtirIa8sLHsVLVhZSgDGiYCNWFLdDz+lUW9Pf0ds+C/iJYx5IYKDb9iLRmi40UYkYsd1 offmuEcMxrlKCVol0fD/Hweiq1yGnLhSF0ZQcL3Dk56DgfveTPqHWpshId0J5aUFJOlS gsuBF4g/K7gwifS0lUS7N0Iny+s4Z1M1Lr8ie0h8CAsF/tsJB+ZE3KMCnv1b157bZS12 lkww== X-Forwarded-Encrypted: i=1; AJvYcCXiZXN7GJ8yEWvvyAVi9JaTz1bpJuZ2ch40Z5mZ2UrjnCQDQxlRCds6BmNHkSBju7BDi3zlsgQhyDrRtT/Q@postgresql.org X-Gm-Message-State: AOJu0YyG87nMEt9q5dftScWvSHYd7heYnJZsbMRoekMfKvN4VzlxZRSh j0KRsJLUxj62XoZEz6QyRNItaUt1t9gplvuKI9Rfy7/MN2Z/aLjo X-Google-Smtp-Source: AGHT+IHjZMCggRIp5ettxLzfgeowmEJ+B0/z32ReqTulEGef/MvninqdKyyNoVCgIyfLP9Nv0wnmaw== X-Received: by 2002:a05:6512:304d:b0:536:581c:9d9f with SMTP id 2adb3069b0e04-53678fb7326mr10626459e87.24.1726585202918; Tue, 17 Sep 2024 08:00:02 -0700 (PDT) Received: from [1.0.0.7] ([91.185.76.62]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53687046805sm1211569e87.6.2024.09.17.08.00.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Sep 2024 08:00:02 -0700 (PDT) Message-ID: <2e5b89af-a351-ff0a-000c-037ac28314ab@gmail.com> Date: Tue, 17 Sep 2024 18:00:00 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bind Content-Language: en-US To: Michael Paquier , Anthonin Bonnefoy Cc: Jelte Fennema-Nio , Peter Eisentraut , Tomas Vondra , vignesh C , PostgreSQL Hackers References: <6cece376-07c6-4075-87b6-937156814202@enterprisedb.com> <4e9ef9f3-0227-45cf-a2a6-5b43ce1bd2a1@eisentraut.org> From: Alexander Lakhin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hello Michael and Anthonin, 22.08.2024 10:33, Michael Paquier wrote: > Looks OK to me. I have spent more time double-checking the whole, and > it looks like we're there, so applied. Now let's play with it in more > regression tests. Note that the refactoring patch has been merged > with the original one in a single commit. Please look at an assertion failure, caused by \bind_named: regression=# SELECT $1 \parse s \bind_named s regression=# \bind_named \bind_named: missing required argument regression=# 1 \g psql: common.c:1501: ExecQueryAndProcessResults: Assertion `pset.stmtName != ((void *)0)' failed. Best regards, Alexander