MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="=_4c2765a3f8d319ef50f9fedd357702b1"
Content-Transfer-Encoding: 7bit
Date: Wed, 28 Jun 2023 22:28:13 +0900
From: torikoshia <torikoshia@oss.nttdata.com>
To: Polina Bungina <bungina@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, cyberdemn@gmail.com,
 pgsql-hackers@lists.postgresql.org
Subject: Re: pg_rewind WAL segments deletion pitfall
In-Reply-To: 
 <CAAtGL4CM7hA0G4dS-Z_RckMy+pzz_KGV2b=8ivDPTgaU4nySGg@mail.gmail.com>
References: 
 <CAAtGL4A1UN7gxWjsmm-PxT0qmfQc8WQRT+Ag-YBUO-98pN9x4Q@mail.gmail.com>
 <20220927.165054.2142431385277288474.horikyota.ntt@gmail.com>
 <CAAtGL4A7zc9u+Gy0_kzcJZDmkrJL-cn1UO3LygXrVB0o6RZKkQ@mail.gmail.com>
 <20220928.181739.1943880428843903268.horikyota.ntt@gmail.com>
 <CAAtGL4CM7hA0G4dS-Z_RckMy+pzz_KGV2b=8ivDPTgaU4nySGg@mail.gmail.com>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <2e75ae22dce9a227c3d47fa6d0ed094a@oss.nttdata.com>
Archived-At: 
 <https://www.postgresql.org/message-id/2e75ae22dce9a227c3d47fa6d0ed094a%40oss.nttdata.com>
Precedence: bulk

--=_4c2765a3f8d319ef50f9fedd357702b1
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII;
 format=flowed


On 2022-09-29 17:18, Polina Bungina wrote:
> I agree with your suggestions, so here is the updated version of
> patch. Hope I haven't missed anything.
> 
> Regards,
> Polina Bungina

Thanks for working on this!
It seems like we are also facing the same issue.

I tested the v3 patch under our condition, old primary has succeeded to 
become new standby.


BTW when I used pg_rewind-removes-wal-segments-reproduce.sh attached in 
[1], old primary also failed to become standby:

   FATAL:  could not receive data from WAL stream: ERROR:  requested WAL 
segment 000000020000000000000007 has already been removed

However, I think this is not a problem:  just adding restore_command 
like below fixed the situation.

   echo "restore_command = '/bin/cp `pwd`/newarch/%f %p'" >> 
oldprim/postgresql.conf

Attached modified reproduction script for reference.

[1]https://www.postgresql.org/message-id/CAFh8B%3DnNiFZOAPsv49gffxHBPzwmZ%3D6Msd4miMis87K%3Dd9rcRA%40mail.gmail.com


-- 
Regards,

--
Atsushi Torikoshi
NTT DATA CORPORATION
--=_4c2765a3f8d319ef50f9fedd357702b1
Content-Transfer-Encoding: base64
Content-Type: text/plain;
 name=pg_rewind-removes-wal-segments-reproduce2.sh
Content-Disposition: attachment;
 filename=pg_rewind-removes-wal-segments-reproduce2.sh;
 size=2511

bWtkaXIgbmV3YXJjaCBvbGRhcmNoCmluaXRkYiAtayAtRCBvbGRwcmltCmVjaG8gImFyY2hpdmVf
bW9kZSA9ICdvbiciPj4gb2xkcHJpbS9wb3N0Z3Jlc3FsLmNvbmYKZWNobyAiYXJjaGl2ZV9jb21t
YW5kID0gJ2VjaG8gImFyY2hpdmUgJWYiID4mMjsgY3AgJXAgYHB3ZGAvb2xkYXJjaC8lZiciPj4g
b2xkcHJpbS9wb3N0Z3Jlc3FsLmNvbmYKcGdfY3RsIC1EIG9sZHByaW0gLW8gJy1wIDU0MzInIC1s
IG9sZHByaW0ubG9nIHN0YXJ0CnBzcWwgLXAgNTQzMiAtYyAnY3JlYXRlIHRhYmxlIHQoYSBpbnQp
JwpwZ19iYXNlYmFja3VwIC1EIG5ld3ByaW0gLXAgNTQzMgplY2hvICJwcmltYXJ5X2Nvbm5pbmZv
PSdob3N0PS90bXAgcG9ydD01NDMyJyI+PiBuZXdwcmltL3Bvc3RncmVzcWwuY29uZgplY2hvICJh
cmNoaXZlX2NvbW1hbmQgPSAnZWNobyAiYXJjaGl2ZSAlZiIgPiYyOyBjcCAlcCBgcHdkYC9uZXdh
cmNoLyVmJyI+PiBuZXdwcmltL3Bvc3RncmVzcWwuY29uZgp0b3VjaCBuZXdwcmltL3N0YW5kYnku
c2lnbmFsCnBnX2N0bCAtRCBuZXdwcmltIC1vICctcCA1NDMzJyAtbCBuZXdwcmltLmxvZyBzdGFy
dAoKIyB0aGUgbGFzdCBjb21tb24gY2hlY2twb2ludApwc3FsIC1wIDU0MzIgLWMgJ2NoZWNrcG9p
bnQnCgojIG9sZCBwcmltYXJ5IGNhbm5vdCBhcmNoaXZlIGFueSBtb3JlCmVjaG8gImFyY2hpdmVf
Y29tbWFuZCA9ICdmYWxzZSciPj4gb2xkcHJpbS9wb3N0Z3Jlc3FsLmNvbmYKcGdfY3RsIC1EIG9s
ZHByaW0gcmVsb2FkCiMgYWR2YW5jZSBXQUwgb24gdGhlIG9sZCBwcmltYXJ5OyBmb3VyIFdBTCBz
ZWdtZW50cyB3aWxsIG5ldmVyIG1ha2UgaXQgdG8gdGhlIGFyY2hpdmUKZm9yIGkgaW4gJChzZXEg
MSA0KTsgZG8gcHNxbCAtcCA1NDMyIC1jICdpbnNlcnQgaW50byB0IHZhbHVlcygwKTsgc2VsZWN0
IHBnX3N3aXRjaF93YWwoKTsnOyBkb25lCgojIHJlY29yZCBhcHByb3guIGRpdmVyZ2luZyBXQUwg
c2VnbWVudApzdGFydF93YWw9YHBzcWwgLXAgNTQzMiAtQXRjICJzZWxlY3QgcGdfd2FsZmlsZV9u
YW1lKHBnX2xhc3Rfd2FsX3JlcGxheV9sc24oKSAtIChzZWxlY3Qgc2V0dGluZyBmcm9tIHBnX3Nl
dHRpbmdzIHdoZXJlIG5hbWUgPSAnd2FsX3NlZ21lbnRfc2l6ZScpOjppbnQpOyJgCnBnX2N0bCAt
RCBuZXdwcmltIHByb21vdGUKCiMgb2xkIHJwcmltYXJ5IGxvc2VzIGRpdmVyZ2luZyBXQUwgc2Vn
bWVudApmb3IgaSBpbiAkKHNlcSAxIDQpOyBkbyBwc3FsIC1wIDU0MzIgLWMgJ2luc2VydCBpbnRv
IHQgdmFsdWVzKDApOyBzZWxlY3QgcGdfc3dpdGNoX3dhbCgpOyc7IGRvbmUKcHNxbCAtcCA1NDMy
IC1jICdjaGVja3BvaW50OycKcHNxbCAtcCA1NDMzIC1jICdjaGVja3BvaW50OycKCnBnX2N0bCAt
RCBvbGRwcmltIHN0b3AKCiMgcmV3aW5kIHRoZSBvbGQgcHJpbWFyeSwgdXNpbmcgaXRzIG93biBh
cmNoaXZlCiMgcGdfcmV3aW5kIC1EIG9sZHByaW0gLS1zb3VyY2Utc2VydmVyPSdwb3J0PTU0MzMn
ICMgc2hvdWxkIGZhaWwKZWNobyAicmVzdG9yZV9jb21tYW5kID0gJ2VjaG8gInJlc3RvcmUgJWYi
ID4mMjsgY3AgYHB3ZGAvb2xkYXJjaC8lZiAlcCciPj4gb2xkcHJpbS9wb3N0Z3Jlc3FsLmNvbmYK
cGdfcmV3aW5kIC1EIG9sZHByaW0gLS1zb3VyY2Utc2VydmVyPSdwb3J0PTU0MzMnIC1jCgojIGFk
dmFuY2UgV0FMIG9uIHRoZSBvbGQgcHJpbWFyeTsgbmV3IHByaW1hcnkgbG9zZXMgdGhlIGxhdW5j
aGluZyBXQUwgc2VnCmZvciBpIGluICQoc2VxIDEgNCk7IGRvIHBzcWwgLXAgNTQzMyAtYyAnaW5z
ZXJ0IGludG8gdCB2YWx1ZXMoMCk7IHNlbGVjdCBwZ19zd2l0Y2hfd2FsKCk7JzsgZG9uZQpwc3Fs
IC1wIDU0MzMgLWMgJ2NoZWNrcG9pbnQnCmVjaG8gInByaW1hcnlfY29ubmluZm89J2hvc3Q9L3Rt
cCBwb3J0PTU0MzMnIj4+IG9sZHByaW0vcG9zdGdyZXNxbC5jb25mCnRvdWNoIG9sZHByaW0vc3Rh
bmRieS5zaWduYWwKZWNobyAicmVzdG9yZV9jb21tYW5kID0gJy9iaW4vY3AgYHB3ZGAvbmV3YXJj
aC8lZiAlcCciID4+IG9sZHByaW0vcG9zdGdyZXNxbC5jb25mCgpwb3N0Z3JlcyAtRCBvbGRwcmlt
ICAjIGZhaWxzIHdpdGggIldBTCBmaWxlIGhhcyBiZWVuIHJlbW92ZWQiCgojIyBUaGUgYWx0ZXJu
YXRpdmUgb2YgY29weWluZy1pbgojIyBlY2hvICJyZXN0b3JlX2NvbW1hbmQgPSAnZWNobyAicmVz
dG9yZSAlZiIgPiYyOyBjcCBgcHdkYC9uZXdhcmNoLyVmICVwJyI+PiBvbGRwcmltL3Bvc3RncmVz
cWwuY29uZgojCiMjIGNvcHktaW4gV0FMIGZpbGVzIGZyb20gbmV3IHByaW1hcnkncyBhcmNoaXZl
IHRvIG9sZCBwcmltYXJ5CiMoY2QgbmV3YXJjaDsKI2ZvciBmIGluIGBsc2A7IGRvCiMgIGlmIFtb
ICIkZiIgPiAiJHN0YXJ0X3dhbCIgXV07IHRoZW4gZWNobyBjb3B5ICRmOyBjcCAkZiAuLi9vbGRw
cmltL3BnX3dhbDsgZmkKI2RvbmUpCiMKI3Bvc3RncmVzIC1EIG9sZHByaW0gICMgYWxzbyBmYWls
cyB3aXRoICJyZXF1ZXN0ZWQgV0FMIHNlZ21lbnQgWFhYIGhhcyBhbHJlYWR5IGJlZW4gcmVtb3Zl
ZCIK
--=_4c2765a3f8d319ef50f9fedd357702b1--