Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gS85x-0003kf-W9 for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Nov 2018 22:14:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gS85w-0006ze-JJ for pgsql-hackers@arkaria.postgresql.org; Wed, 28 Nov 2018 22:14:08 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gS85w-0006zS-83 for pgsql-hackers@lists.postgresql.org; Wed, 28 Nov 2018 22:14:08 +0000 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gS85o-0005BQ-BZ for pgsql-hackers@postgresql.org; Wed, 28 Nov 2018 22:14:06 +0000 Received: by mail-wr1-x432.google.com with SMTP id t3so27882501wrr.3 for ; Wed, 28 Nov 2018 14:13:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=thd5h2OQaxx+E9jut5UxzyH5gfGeRreYNQPOqT+wXis=; b=dKtNluTdACnrvg2Fi9Hh40C/6ceBJ9RDSpqtjsW77OT20231OzHulcCJZKcylo4LB+ OHGC4n0dire7eliD8IOyAOsEg/paPbb6exl5RzM/X+/cHrPYwq70eMMScDeiq3HfDMqO kIt7p4YjR7GGw6bEyjXLZz+usBlLVKMd+wN9s3+TNxqg4hPN/XjnMFsnSAv059acLGVV o7IiB/3z9LP4AnPiMKC567WUo15x+cksscuiR5itGBk/vj08yL+CarYlFAvJgIaFN+Bl cmy0qTaNY/TPXMu87kwALGqX5hvXx82O8PEqXv6ntKPHlSHZRxGj5bUaA0yzpA7tWwYZ ByHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=thd5h2OQaxx+E9jut5UxzyH5gfGeRreYNQPOqT+wXis=; b=N+Bo9b+UhcONIwQEsi5K+7I8TsuZCZYrHx7ACAu43W5hYgiAQqKCuhnY+sePhjv+5G lUqI2E+fe3Ro/JXmJ6+3Us63z3qaHWDTAIaD7ARv1ryNyKpbDd8GIiOvQBziF87Nn4cT tZ6Qi0aR4yUmThKe4iQd0a5hs6m7ycQNQhXi+itC/4fa0Oz5GzsxpEn9ynpAX7djDRI3 7gAGpi9KnBgZ4vp3MBMdSWBbenNLDZJJh3iOhTkoahxRmZ1CdCT6P+DrsUiIunnHGJKo ZNEPt/jQnsz+5ZmnzihuPRe2kKNx6+JVStANSblKtk9CGZ1LiJ947DtusvKQzIoK4/Fw +XEw== X-Gm-Message-State: AA+aEWZZFdYzH/TbZSx0/6ZkHus/qOqeJ2Ha4TppOGDL2f4uZDKlZtxs 82gdsflW6kBLJnq9XtKctIV/LUrwvzgqJB8MfNu8xYXGgrsG2OxGyRN2AGoBnS25msFx3ct8635 xlXIiWfaAYlrksQfKVO03HKxqgThvXw6+vQaB2Tn+539ATnwYpfdwFZS4k6i0Jwo4QLAE5N12EQ sTDhfuktMx83nTJw== X-Google-Smtp-Source: AFSGD/V6VNz7LnGvoHNPuhwwjc6GRYKEfs3lvkmwCvVlMzABLaleHUmEoqofMqJh/H2GJzFyDfUJGg== X-Received: by 2002:a5d:454f:: with SMTP id p15mr35039820wrr.39.1543443237990; Wed, 28 Nov 2018 14:13:57 -0800 (PST) Received: from [10.137.2.19] (ip-86-49-251-50.net.upcbroadband.cz. [86.49.251.50]) by smtp.gmail.com with ESMTPSA id x81sm163971wmg.17.2018.11.28.14.13.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Nov 2018 14:13:56 -0800 (PST) Subject: Re: shared-memory based stats collector To: Kyotaro HORIGUCHI Cc: alvherre@2ndquadrant.com, andres@anarazel.de, ah@cybertec.at, magnus@hagander.net, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, pgsql-hackers@postgresql.org References: <20181112.201042.147595779.horiguchi.kyotaro@lab.ntt.co.jp> <8e041a34a70ae5d44cb10a7e516308e2f6d1b651.camel@2ndquadrant.com> <6c079a69-feba-e47c-7b85-8a9ff31adef3@2ndquadrant.com> <20181127.175949.06807946.horiguchi.kyotaro@lab.ntt.co.jp> From: Tomas Vondra Message-ID: <2e77189a-48f0-ea50-c0b7-507d22d37032@2ndquadrant.com> Date: Wed, 28 Nov 2018 23:13:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <20181127.175949.06807946.horiguchi.kyotaro@lab.ntt.co.jp> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 11/27/18 9:59 AM, Kyotaro HORIGUCHI wrote: > ... > > v10-0001-sequential-scan-for-dshash.patch > v10-0002-Add-conditional-lock-feature-to-dshash.patch > fixed. > v10-0003-Make-archiver-process-an-auxiliary-process.patch > fixed. > v10-0004-Shared-memory-based-stats-collector.patch > updated not to touch guc. > v10-0005-Remove-the-GUC-stats_temp_directory.patch > collected all guc-related changes. > updated not to break other programs. > v10-0006-Split-out-backend-status-monitor-part-from-pgstat.patch > basebackup.c requires both bestats.h and pgstat.h > v10-0007-Documentation-update.patch > small change related to 0005. > I need to do a more thorough review of part 0006, but these patches seems quite fine to me. I'd however merge 0007 into the other relevant parts (it seems like a mix of docs changes for 0004, 0005 and 0006). Thinking about it a bit more, I'm wondering if we need to keep 0004 and 0005 separate. My understanding is that the stats_temp_directory is used only from the stats collector, so it probably does not make much sense to keep it after 0004. We may also keep it separate and then commit both 0004 and 0005 together, of course. What do you think. regards -- Tomas Vondra http://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services