Received: from localhost (maia-3.hub.org [200.46.204.184])
	by postgresql.org (Postfix) with ESMTP id EAED69FB6D9
	for <pgsql-patches-postgresql.org@postgresql.org>;
	Mon, 21 May 2007 06:32:30 -0300 (ADT)
Received: from postgresql.org ([200.46.204.71])
	by localhost (mx1.hub.org [200.46.204.184]) (amavisd-maia, port 10024)
	with ESMTP id 37462-07 for
	<pgsql-patches-postgresql.org@postgresql.org>;
	Mon, 21 May 2007 06:32:17 -0300 (ADT)
X-Greylist: domain auto-whitelisted by SQLgrey-1.7.4
Received: from wr-out-0506.google.com (wr-out-0506.google.com
 [64.233.184.231])
	by postgresql.org (Postfix) with ESMTP id 78AC19FB64A
	for <pgsql-patches@postgresql.org>;
	Mon, 21 May 2007 06:32:20 -0300 (ADT)
Received: by wr-out-0506.google.com with SMTP id 70so1208034wra
	for <pgsql-patches@postgresql.org>;
	Mon, 21 May 2007 02:32:19 -0700 (PDT)
DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta;
	h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references;
	b=mJF8yTL/VP3njCqfGyaiaJ4ewBYlxQ5cjE87a73nsNA/6vhe6JlPFd5Ta4GdtLbO1exHBBlZhSth39w+7CebIITWaPe9ERqidQ5VmNgD43TBhXT47TKwuu6gGszY+HsU4NolNQF/mEu20URJfBYHjAUW8sYaltlwc7CfwNWkrOw=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta;
	h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references;
	b=JOHYDNLbM2cVIdZGnC8AGNzsFOevyAFLJ9vb9B/WqCSiFrxHMYbTVpx02iLPqso7HvlOC4NGpEWEMWDbC0WLIgCeFxVSh7UOJsXvT297Ef/5fWWaLlcKf4F08gjlkeFs6L+qRqmra8ppxnK/paKT9utf1xlJ/Jv2AZPrrpaceS8=
Received: by 10.114.94.1 with SMTP id r1mr2566231wab.1179739938565;
	Mon, 21 May 2007 02:32:18 -0700 (PDT)
Received: by 10.114.56.6 with HTTP; Mon, 21 May 2007 02:32:18 -0700 (PDT)
Message-ID: <2e78013d0705210232m5d031a6fk779be6d7df5a2e3c@mail.gmail.com>
Date: Mon, 21 May 2007 15:02:18 +0530
From: "Pavan Deolasee" <pavan.deolasee@gmail.com>
To: "Heikki Linnakangas" <heikki@enterprisedb.com>
Subject: Re: Maintaining cluster order on insert
Cc: "Jaime Casanova" <systemguards@gmail.com>,
	PostgreSQL-patches <pgsql-patches@postgresql.org>
In-Reply-To: <2e78013d0705210117y6a65245cw426bbaafa9eb6419@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_67126_31614403.1179739938323"
References: <200705152223.l4FMNJa17969@momjian.us>
	<464A33AB.1050401@enterprisedb.com> <20070516003810.GI20707@nasby.net>
	<464B15EF.4000808@enterprisedb.com>
	<c2d9e70e0705172153g3207adb6kd4abdfdf3a9215ff@mail.gmail.com>
	<464D96D6.1030608@enterprisedb.com>
	<c2d9e70e0705182205o44a4bbbft18a73b9de91de726@mail.gmail.com>
	<464F410C.8090900@enterprisedb.com>
	<2e78013d0705210117y6a65245cw426bbaafa9eb6419@mail.gmail.com>
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Archive-Number: 200705/376
X-Sequence-Number: 2476

------=_Part_67126_31614403.1179739938323
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On 5/21/07, Pavan Deolasee <pavan.deolasee@gmail.com> wrote:
>
>
>
> On 5/19/07, Heikki Linnakangas <heikki@enterprisedb.com > wrote:
> >
> >
> > Ah, sorry about that. For some reason my source tree was checked out
> > from the 8.2 branch, instead of CVS HEAD.
> >
> >
> I looked at the patch. Not that I am very comfortable with this part
> of the code, but nevertheless here are my comments:
>
>
Another problem that I noticed with the patch is that it disregards
the fillfactor while inserting the tuples. ISTM that this is a correct
behavior when a tuple is being inserted in the block to preserve cluster
ordering. But when the tuple is being inserted as a normal operation,
IMO we should respect the fillfactor.

The easiest way to reproduce this is to insert tuples sorted on the
cluster index key.

Thanks,
Pavan


-- 

EnterpriseDB     http://www.enterprisedb.com

------=_Part_67126_31614403.1179739938323
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

<br><br><div><span class="gmail_quote">On 5/21/07, <b class="gmail_sendername">Pavan Deolasee</b> &lt;<a href="mailto:pavan.deolasee@gmail.com">pavan.deolasee@gmail.com</a>&gt; wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<span class="q"><br><br><div><span class="gmail_quote">On 5/19/07, <b class="gmail_sendername">Heikki Linnakangas</b> &lt;<a href="mailto:heikki@enterprisedb.com" target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">
heikki@enterprisedb.com
</a>&gt; wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>Ah, sorry about that. For some reason my source tree was checked out<br>from the 8.2 branch, instead of CVS HEAD.<br><br></blockquote></div><br></span>I looked at the patch. Not that I am very comfortable with this part
<br>
of the code, but nevertheless here are my comments:
<br><br></blockquote></div><br>Another problem that I noticed with the patch is that it disregards<br>the fillfactor while inserting the tuples. ISTM that this is a correct<br>behavior when a tuple is being inserted in the block to preserve cluster
<br>ordering. But when the tuple is being inserted as a normal operation,<br>IMO we should respect the fillfactor.<br><br>The easiest way to reproduce this is to insert tuples sorted on the<br>cluster index key.<br><br>Thanks,
<br>Pavan<br><br clear="all"><br>-- <br><br>EnterpriseDB&nbsp;&nbsp;&nbsp;&nbsp; <a href="http://www.enterprisedb.com">http://www.enterprisedb.com</a>

------=_Part_67126_31614403.1179739938323--