Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcsWV-0001um-JE for pgsql-hackers@arkaria.postgresql.org; Wed, 02 Aug 2017 12:13:11 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dcsWU-0006pn-84 for pgsql-hackers@arkaria.postgresql.org; Wed, 02 Aug 2017 12:13:10 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dcsWT-0006pM-FR for pgsql-hackers@postgresql.org; Wed, 02 Aug 2017 12:13:09 +0000 Received: from mail.postgrespro.ru ([93.174.131.138]) by magus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcsWP-00017C-Pt for pgsql-hackers@postgresql.org; Wed, 02 Aug 2017 12:13:08 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.postgrespro.ru (Postfix) with ESMTP id 58F7821C0911; Wed, 2 Aug 2017 15:13:04 +0300 (MSK) X-Virus-Scanned: Debian amavisd-new at postgrespro.ru MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1501675984; bh=yUWnSWHdCjz3lK18ffym9pgEivV3dxSV6811wACfwH0=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=gSmi+nODUz2AZMMVGWaRngwPV8WFA5uKMfCHW/hGpC8bjXek4+6YqEmKpUJelDIi2 JIGR/6oftjoXXFsgT/7InLa1miIXjNT2lPvRrhMim/cNaInI4208Jzj6buirJ33X9P x1KqDcDnv86M7HxeW7Rpv7RzmCrm3PLUlgUACmtg= Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 02 Aug 2017 15:13:04 +0300 From: Victor Drobny To: Aleksander Alekseev Cc: Pgsql Hackers Subject: Re: Red-Black tree traversal tests Organization: Postgres Professional In-Reply-To: <20170801095835.GB22764@e733.localdomain> References: <20170801095446.GA22764@e733.localdomain> <20170801095835.GB22764@e733.localdomain> Message-ID: <2e864bd9888f41f7f6c9808ee2b8a5a0@postgrespro.ru> X-Sender: v.drobny@postgrespro.ru User-Agent: Roundcube Webmail/1.2.4 List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Hello, Thank you for the reviewing. >> If it's not too much trouble perhaps you could write a few more test >> so >> we would have 100% test coverage for rbtree, could modify it safely >> and >> be sure that it actually works when someone will need the rest of its >> functionality? Done. Now all of the functions in rbtree.c are covered. > Also I would recommend to add your patch to the nearest commitfest [1]. > Otherwise there is a good chance that everyone will forget about it > quite soon. > > [1]: https://commitfest.postgresql.org/14/ Done. Here is the link: https://commitfest.postgresql.org/14/1225/ Thank you for attention! -- ------ Victor Drobny Postgres Professional: http://www.postgrespro.com The Russian Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers