Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rksax-00G6mR-Sa for pgsql-hackers@arkaria.postgresql.org; Thu, 14 Mar 2024 21:26:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rksaw-003VdA-8j for pgsql-hackers@arkaria.postgresql.org; Thu, 14 Mar 2024 21:26:34 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rksav-003Vd2-VJ for pgsql-hackers@lists.postgresql.org; Thu, 14 Mar 2024 21:26:34 +0000 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rksas-004Xpx-M8 for pgsql-hackers@postgresql.org; Thu, 14 Mar 2024 21:26:33 +0000 Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-5131316693cso1957076e87.0 for ; Thu, 14 Mar 2024 14:26:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1710451589; x=1711056389; darn=postgresql.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vpAnB0kiJW3QaM7IumVgKU3PFyA2AnVjo6KzUTRdloE=; b=EnxqipWsHrj2vfOmqu2wyfJXf6lCAPQrBpiucihJj9Ze5EPR1+lQlQEwLT6G7Vb1Xt jPW7Y0SPSVWPNLyLhhDZjOxUw/YtLPOOuvSK6EwFbxo5ud4Z9jIxSKqttUzzofHUuyC/ 9WGsoQuqPQEA+q88YiYuYaLixctk7M3uU7iWKrlekXUSM55NwjuuybcWhtbwvCg2QZFu HRFYzTgxbr5G+wWktpzNBe2CMkvNT2nQfzaAuonxlL0mbl8njq68PSfEjrg30u3xHXac jhlR0P5z6+WSrzVVPE80MHtNscVo50jrflZVJYZ5FI0c7q/NttmOHVDkvTlpmdSD1vHN Jh+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710451589; x=1711056389; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vpAnB0kiJW3QaM7IumVgKU3PFyA2AnVjo6KzUTRdloE=; b=E/1lKu+VTBFZA3z3WbarFn2cOlr6fgEMeIhzWtnftUS7GOI7o33jHe5j0irBUU/PdW AQdC3ehYvDsD7VrsYBZ2PariVzsRL9cNE8Ot54OhUMEo/sJH6+K/kIWK5sZXKhPcLr1J muJ3sZxfgxC/4VX5wNfXt5zj4npcjf0IW5aXS9ahi9Jg/d4vRSKpqHCO7DaHI2WEQhWF VH5VjOwxucqgnZGmnxljCc8sMsGzegfoS7WH9+3fIaASao4qe5TMQdaRpyj4NAAmDoPp UvTSWh4wIw54u7qJWUD9NCN3+rpKLN7BH43loUvw/GAE6+//BqnhU/SttehKpdmOIZCM TDuQ== X-Forwarded-Encrypted: i=1; AJvYcCWZJyVpsSEnDJPAcZ8REfIAaXOgOeliuqnRHu9iH1fmFH9CRORxqabQDQ5v2eMoDXSCBd8Py1zdBD6Mk96Hv6LAGUaGS9IiGC08MYOg X-Gm-Message-State: AOJu0YwSoo5dTj0x9xSu0KlZ6yuYndiMRV7IALkXMkzjtZ2RSJTXPLJ+ 4eNY1MT78noV/7y/Om9gTuqAFzBhKhbsUs0OpS/r7OEy8i/6WCkgUUFlqsztAw== X-Google-Smtp-Source: AGHT+IGxcT+AiQxattL9+iQV/Jh0bWReCI2kwTJnjVLrd5aXRlLP1DlUJHC3Yj4xu/5iTM+WLMLlPA== X-Received: by 2002:ac2:4c9c:0:b0:512:e218:db7f with SMTP id d28-20020ac24c9c000000b00512e218db7fmr2200468lfl.67.1710451589553; Thu, 14 Mar 2024 14:26:29 -0700 (PDT) Received: from [10.137.0.18] (84-217-81-189.customers.ownit.se. [84.217.81.189]) by smtp.gmail.com with ESMTPSA id q24-20020ac25298000000b00513a11e9dc3sm414895lfm.211.2024.03.14.14.26.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Mar 2024 14:26:29 -0700 (PDT) Message-ID: <2ed1e06b-feae-4c61-9f58-3fcc358104c7@enterprisedb.com> Date: Thu, 14 Mar 2024 22:26:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: BitmapHeapScan streaming read user and prelim refactoring Content-Language: en-US To: Melanie Plageman , Heikki Linnakangas Cc: Dilip Kumar , Robert Haas , Nazir Bilal Yavuz , Andres Freund , Pg Hackers , Thomas Munro References: <20240216173559.xiy5xcl5dqmsprns@liskov> <20240227015028.knohvy3spaqwk7lf@liskov> <20240227142230.nu3ytvcjwouvczlt@liskov> <5f3b9d59-0f43-419d-80ca-6d04c07cf61a@iki.fi> <20240314181625.a7uigo5ujaogfd6x@liskov> From: Tomas Vondra In-Reply-To: <20240314181625.a7uigo5ujaogfd6x@liskov> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 3/14/24 19:16, Melanie Plageman wrote: > On Thu, Mar 14, 2024 at 03:32:04PM +0200, Heikki Linnakangas wrote: >> ... >> >> Ok, committed that for now. Thanks for looking! > > Attached v6 is rebased over your new commit. It also has the "fix" in > 0010 which moves BitmapAdjustPrefetchIterator() back above > table_scan_bitmap_next_block(). I've also updated the Streaming Read API > commit (0013) to Thomas' v7 version from [1]. This has the update that > we theorize should address some of the regressions in the bitmapheapscan > streaming read user in 0014. > Should I rerun the benchmarks with these new patches, to see if it really helps with the regressions? regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company