Subject: Re: useless RangeIOData->typiofunc
To: pgsql-hackers@lists.postgresql.org
References: <20200304215711.GA8732@alvherre.pgsql>
From: Paul Jungwirth <pj@illuminatedcomputing.com>
Message-ID: <2f266b59-86ab-af94-902f-5c5a6a834de4@illuminatedcomputing.com>
Date: Wed, 4 Mar 2020 14:34:02 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <20200304215711.GA8732@alvherre.pgsql>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/4/20 1:57 PM, Alvaro Herrera wrote:
> I noticed while going over the multirange types patch that it adds a
> pointless typiofunc cached OID to a struct used for I/O functions'
> fn_extra.  It seems to go completely unused, so I checked range types
> (which this was cribbed from) and indeed, it is completely unused there
> either.  My guess is that it was in turn cribbed from array's
> ArrayMetaState, which is considerably more sophisticated; I suspect
> nobody noticed that caching it was pointless.

I didn't believe it at first but I think you're right. :-)

> Here's a patch to remove it from rangetypes.c.  It doesn't really waste
> much memory anyway, but removing it lessens the cognitive load by one or
> two bits.

Looks good to me, and it seems okay to make the same edits to 
multirangetypes.c

Yours,

-- 
Paul              ~{:-)
pj@illuminatedcomputing.com