Subject: Re: color by default
To: Michael Paquier <michael@paquier.xyz>
References: <20200106053824.GO3598@paquier.xyz>
 <171d92f5-fc29-a207-3db9-c16c63bb2ea7@archidevsys.co.nz>
 <CAC+AXB04-NC6vF=c63EDp1G+c8n4uciZjeKMHY29LkBmZTebHA@mail.gmail.com>
 <20200303053101.GH32059@paquier.xyz> <20200320021557.GC1850@momjian.us>
 <20200321025522.GD10066@momjian.us> <6707.1584760507@sss.pgh.pa.us>
 <20200321032207.GE10066@momjian.us> <20200323050410.GE2900@paquier.xyz>
 <afc175cd-902b-3ee9-9cee-f709cadb9c23@2ndquadrant.com>
 <20200326063625.GG1471@paquier.xyz>
Cc: Bruce Momjian <bruce@momjian.us>, Tom Lane <tgl@sss.pgh.pa.us>,
 =?UTF-8?Q?Juan_Jos=c3=a9_Santamar=c3=ada_Flecha?=
 <juanjo.santamaria@gmail.com>, Gavin Flower <GavinFlower@archidevsys.co.nz>,
 Robert Haas <robertmhaas@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <2fa9de54-68cd-b29f-1ed1-b6fea806039a@2ndquadrant.com>
Date: Sun, 29 Mar 2020 11:56:15 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20200326063625.GG1471@paquier.xyz>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020-03-26 07:36, Michael Paquier wrote:
> I am not sure that deleting all the mentions would be a good idea, as
> we'd lose track of which tool supports coloring or not, and that could
> confuse users.  What about switching the existing paragraph to a
> simple sentence with a link to the new appendix you are adding?  Say:
> "pg_foo supports <place_your_link_here>colorized output</>".

I didn't do this because it would create additional complications in the 
man pages.  But there is now an index entry, so it's possible to find 
more information.

>> +  <para>
>> +   The actual colors to be used are configured using the environment variable
>> +   <envar>PG_COLORS</envar><indexterm><primary>PG_COLORS</primary></indexterm>
>> +   (note plural).  The value is a colon-separated list of
>> +   <literal><replaceable>key</replaceable>=<replaceable>value</replaceable></literal>
>> +   pairs.  The keys specify what the color is to be used for.  The values are
>> +   SGR (Select Graphic Rendition) specifications, which are interpreted by the
>> +   terminal.
>> +  </para>
> 
> A reference to SGR to understand better what's the list of values
> supported would be nice?

I'm not sure how to do that.  The full list of possible values is huge, 
and exactly what is supported depends on the terminal.

>> +  <para>
>> +   The default value is <literal>error=01;31:warning=01;35:locus=01</literal>.
>> +  </para>
> 
> Could it be possible to have more details about what those three
> fields map to?

I have added information about that and explained the example values.  I 
think if you search for "Select Graphic Rendition" and look for the 
example values, you can make sense of this.

Committed with those changes.  This closes the commit fest item.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services