MIME-Version: 1.0
Date: Wed, 05 Nov 2025 09:30:59 +0300
From: Alexander Pyhalov <a.pyhalov@postgrespro.ru>
To: Matheus Alcantara <matheusssilv97@gmail.com>
Cc: Alena Rybakina <a.rybakina@postgrespro.ru>, Pgsql Hackers
 <pgsql-hackers@postgresql.org>
Subject: Re: Asynchronous MergeAppend
In-Reply-To: <DDZ2ULUYDQJ4.MXMP02V4GIG@gmail.com>
References: <59be194c5a409fb9fc9f2031581b8a44@postgrespro.ru>
 <764dd8b8-6374-4f5a-aac7-d8e3f6ebe5fd@postgrespro.ru>
 <159b591411bb2c81332018927acbd509@postgrespro.ru>
 <DDZ2ULUYDQJ4.MXMP02V4GIG@gmail.com>
Message-ID: <2fb1d9923b6995492e7b163e6cb95402@postgrespro.ru>
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/2fb1d9923b6995492e7b163e6cb95402%40postgrespro.ru>
Precedence: bulk

Hi.

Matheus Alcantara =D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0) 2025-11-03 16:00=
:
> So I'm +1 for the idea. I know it's been while since the last patch,=20
> and
> unfortunully it hasn't received reviews since then. Do you still plan=20
> to
> work on it? I still need to take a look on the code to see if I can=20
> help
> with some comments.
>=20
> During the tests I got compiler errors due to fce7c73fba4, so I'm
> attaching a v5 with guc_parameters.dat correctly sorted.
>=20
> The postgres_fdw/regress tests was also failling due to some whitespace
> problems, v5 also fix this.
>=20
> [1]=20
> https://www.postgresql.org/message-id/202510251154.isknefznk566%40alvhe=
rre.pgsql
>=20

I'm still interested in working on this patch, but it didn't get any=20
review (besides internal one). I suppose, Append and MergeAppend nodes=20
need some unification, for example, ExecAppendAsyncEventWait and=20
ExecMergeAppendAsyncEventWait looks the same, both=20
classify_matching_subplans() versions are suspiciously similar. But=20
honestly, patch needs thorough review.
--=20
Best regards,
Alexander Pyhalov,
Postgres Professional