Message-ID: <2fc1658586de9ccdc742a973edf7831e109b7fdb.camel@cybertec.at>
Subject: Re: pg_receivewal documentation
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: jesper.pedersen@redhat.com, PostgreSQL-development
	 <pgsql-hackers@postgresql.org>
Date: Tue, 09 Jul 2019 11:16:55 +0200
In-Reply-To: <1427a2d3-1e51-9335-1931-4f8853d90d5e@redhat.com>
References: <1427a2d3-1e51-9335-1931-4f8853d90d5e@redhat.com>
Content-Type: multipart/mixed; boundary="=-+79c6sZI7/Mk8p5luxrp"
User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) 
MIME-Version: 1.0
Precedence: bulk


--=-+79c6sZI7/Mk8p5luxrp
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On Thu, 2019-06-27 at 10:06 -0400, Jesper Pedersen wrote:
> Here is a patch for the pg_receivewal documentation to highlight that 
> WAL isn't acknowledged to be applied.

I think it is a good idea to document this, but I have a few quibbles
with the patch as it is:

- I think there shouldn't be commas after the "note" and before the "if".
  Disclaimer: I am not a native speaker, so I am lacking authority.

- The assertion is wrong.  "on" (remote flush) is perfectly fine
  for synchronous_commit, only "remote_apply" is a problem.

- There is already something about "--synchronous" in the "Description"
  section.  It might make sense to add the additional information there.

How about the attached patch?

Yours,
Laurenz Albe

--=-+79c6sZI7/Mk8p5luxrp
Content-Disposition: attachment;
	filename="0001-Better-documentation-for-pg_receivewal-synchronous.patch"
Content-Transfer-Encoding: base64
Content-Type: text/x-patch;
	name="0001-Better-documentation-for-pg_receivewal-synchronous.patch";
	charset="UTF-8"

RnJvbSBjMThiNGIzODRhOTYzZTA0Y2M1YjViNTA1MzdjMTUwODU4ODI0ZjBhIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBMYXVyZW56IEFsYmUgPGxhdXJlbnouYWxiZUBjeWJlcnRlYy5h
dD4KRGF0ZTogVHVlLCA5IEp1bCAyMDE5IDExOjE1OjA5ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g
QmV0dGVyIGRvY3VtZW50YXRpb24gZm9yICJwZ19yZWNlaXZld2FsIC0tc3luY2hyb25vdXMiCgoi
c3luY2hyb25vdXNfY29tbWl0IiBtdXN0IG5vdCBiZSBzZXQgdG8gInJlbW90ZV9hcHBseSIgYmVj
YXVzZQpwZ19yZWNlaXZld2FsIGRvZXNuJ3QgYXBwbHkgV0FMLgotLS0KIGRvYy9zcmMvc2dtbC9y
ZWYvcGdfcmVjZWl2ZXdhbC5zZ21sIHwgNSArKysrLQogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0
aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9yZWYvcGdf
cmVjZWl2ZXdhbC5zZ21sIGIvZG9jL3NyYy9zZ21sL3JlZi9wZ19yZWNlaXZld2FsLnNnbWwKaW5k
ZXggMDUwNjEyMGMwMC4uNDM5M2VlZWUyYyAxMDA2NDQKLS0tIGEvZG9jL3NyYy9zZ21sL3JlZi9w
Z19yZWNlaXZld2FsLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21sL3JlZi9wZ19yZWNlaXZld2FsLnNn
bWwKQEAgLTUyLDcgKzUyLDEwIEBAIFBvc3RncmVTUUwgZG9jdW1lbnRhdGlvbgogICAgVW5saWtl
IHRoZSBXQUwgcmVjZWl2ZXIgb2YgYSBQb3N0Z3JlU1FMIHN0YW5kYnkgc2VydmVyLCA8YXBwbGlj
YXRpb24+cGdfcmVjZWl2ZXdhbDwvYXBwbGljYXRpb24+CiAgICBieSBkZWZhdWx0IGZsdXNoZXMg
V0FMIGRhdGEgb25seSB3aGVuIGEgV0FMIGZpbGUgaXMgY2xvc2VkLgogICAgVGhlIG9wdGlvbiA8
b3B0aW9uPi0tc3luY2hyb25vdXM8L29wdGlvbj4gbXVzdCBiZSBzcGVjaWZpZWQgdG8gZmx1c2gg
V0FMIGRhdGEKLSAgIGluIHJlYWwgdGltZS4KKyAgIGluIHJlYWwgdGltZS4gIE5vdGUgdGhhdCB3
aGlsZSBXQUwgd2lsbCBiZSBmbHVzaGVkIHdpdGggdGhpcyBzZXR0aW5nLAorICAgaXQgd2lsbCBu
ZXZlciBiZSBhcHBsaWVkLCBzbyA8eHJlZiBsaW5rZW5kPSJndWMtc3luY2hyb25vdXMtY29tbWl0
Ii8+IG11c3QKKyAgIG5vdCBiZSBzZXQgdG8gPGxpdGVyYWw+cmVtb3RlX2FwcGx5PC9saXRlcmFs
PiBpZiA8YXBwbGljYXRpb24+cGdfcmVjZWl2ZXdhbDwvYXBwbGljYXRpb24+CisgICBpcyB0aGUg
b25seSBzeW5jaHJvbm91cyBzdGFuZGJ5LgogICA8L3BhcmE+CiAKICAgPHBhcmE+Ci0tIAoyLjIw
LjEKCg==


--=-+79c6sZI7/Mk8p5luxrp--