Subject: Re: [PG13] Planning (time + buffers) data structure in explain plan
 (format text)
To: pgsql-hackers@lists.postgresql.org
References: <07b226e6-fa49-687f-b110-b7c37572f69e@dalibo.com>
 <20200819032706.GQ17022@telsasoft.com> <20200819072133.jnmtux7qbyxywh6r@nol>
 <CAApHDvrDpJNMpXMS3SNkeUitXrZAFRZ3MrzQG6ieC7vQte6aWA@mail.gmail.com>
 <20200819090429.s7hoyyw4a6jumgkc@nol>
 <CAApHDvr0hMeEDB6HE=GE6vc2kJjCoiWe7z+CVyD9CoAUB+Cpjw@mail.gmail.com>
 <e7361ab4-5b6b-9667-e25b-04ae0b070ded@oss.nttdata.com>
 <CAApHDvqWSk5tVqY9=SwsOF03xOJyrvwoavdDoNjV+2Wk10vsuQ@mail.gmail.com>
 <5605ac79-90c0-6a5f-256d-5cabf52a3fe8@oss.nttdata.com>
From: Pierre Giraud <pierre.giraud@dalibo.com>
Message-ID: <2fd56df7-ec7f-5c8a-0268-33be181438e9@dalibo.com>
Date: Thu, 20 Aug 2020 10:03:12 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <5605ac79-90c0-6a5f-256d-5cabf52a3fe8@oss.nttdata.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

Can you please show what the plan would look like for?

=# explain (buffers on, summary on, format JSON) select * from t;


Le 20/08/2020 à 09:58, Fujii Masao a écrit :
> 
> 
> On 2020/08/20 13:00, David Rowley wrote:
>> On Thu, 20 Aug 2020 at 03:31, Fujii Masao
>> <masao.fujii@oss.nttdata.com> wrote:
>>> With the patch, for example, whatever "summary" settng is, "buffers on"
>>> displays the planner's buffer usage if it happens.
>>
>> I forgot to mention earlier, you'll also need to remove the part in
>> the docs that mentions BUFFERS requires ANALYZE.
> 
> Thanks for the review! I removed that.
> Attached is the updated version of the patch.
> I also added the regression test performing "explain (buffers on)"
> without "analyze" option.
> 
> Regards,
>