Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tR4Hf-0074ej-4M for pgsql-hackers@arkaria.postgresql.org; Fri, 27 Dec 2024 06:57:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tR4He-007rsS-7G for pgsql-hackers@arkaria.postgresql.org; Fri, 27 Dec 2024 06:57:17 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tR4Hd-007rrN-O3 for pgsql-hackers@lists.postgresql.org; Fri, 27 Dec 2024 06:57:17 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tR4Ha-001peJ-KU for pgsql-hackers@lists.postgresql.org; Fri, 27 Dec 2024 06:57:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mx2023; t=1735282633; bh=JZY5AniwvT9oOpW3J0Pgt+qEwCFUFNfmon3suWoKTxU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:Message-ID:From; b=qHTDb6Zc+4R0pFrGV2v9Jf5KTaQ0af2Hq2jpLCqWkm/DP6eBLMDRlSwtV8+Rde8s0 F45J/zvx9ZsAmwHLyqKTlkP1DCE94f0Ki1lsnbE0Vnhx3ZuoUuoZwraErdpkDViLxw HSBIebkkAK879NIXA6r9/k3xqv6Z3WgJVIqCwZ3RLCUXH37jB3govOBWgumD+9HgrC fycvIyNvAa5Nz4O++zKQpwZUR3cUsoVbhvSuLsl48ERQwGM1XAEmeJsyjMU8tenynu 1q/Q7+kquyOEf0FdqviAOLAucHN2Um++qaoS+W0FnSSdITwYnTcDdZKoJIJZiUb7LQ Eom0araIRVXOQ== Received: from mail.postgrespro.ru (webmail-slave-mstn.l.postgrespro.ru [192.168.2.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: v.popolitov@postgrespro.ru) by mail.postgrespro.ru (Postfix/587) with ESMTPSA id E64466015D; Fri, 27 Dec 2024 09:57:12 +0300 (MSK) MIME-Version: 1.0 Date: Fri, 27 Dec 2024 09:57:12 +0300 From: Vladlen Popolitov To: "Kohei Harikae (Fujitsu)" Cc: 'Andres Freund' , "'pgsql-hackers@lists.postgresql.org'" Subject: Re: Windows meson build In-Reply-To: References: <3fadfb663c69bae7448797acfa47c2ba@postgrespro.ru> Message-ID: <2fe1080dc2f42e2510b810d84eee45bd@postgrespro.ru> X-Sender: v.popolitov@postgrespro.ru Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-KSMG-AntiPhishing: NotDetected X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.1.0.7854, bases: 2024/12/27 06:06:00 #26921178 X-KSMG-AntiVirus-Status: NotDetected, skipped X-KSMG-LinksScanning: not scanned, disabled by settings X-KSMG-Message-Action: skipped X-KSMG-Rule-ID: 1 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Kohei Harikae (Fujitsu) писал(а) 2024-12-27 04:31: > Hi, > > Thank you for your advice. > I added a sample setting PKG_CONFIG_PATH based on your advice. > > How do you think about this? > > Regards, > Kohei Harikae > Hi, From my point of view it looks good. Actual information is added, excessive information is removed. I think in the phrase: "add the directory where the .pc file resides to PKG_CONFIG_PATH." better to add wording, that PKG_CONFIG_PATH is the list of directories separated by PATH separator ( ; in Windows, : in POSIX). Otherwise the reader has to search additional information about this variable in meson documentation. -- Best regards, Vladlen Popolitov.