Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1wALWZ-002I90-1D
	for pgsql-hackers@arkaria.postgresql.org;
	Wed, 08 Apr 2026 05:32:23 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1wALWX-0057kU-2j
	for pgsql-hackers@arkaria.postgresql.org;
	Wed, 08 Apr 2026 05:32:22 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1wALWX-0057kM-1r
	for pgsql-hackers@lists.postgresql.org;
	Wed, 08 Apr 2026 05:32:21 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.98.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1wALWV-00000001FG5-44da;
	Wed, 08 Apr 2026 05:32:21 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 6385WF4u3000230;
	Wed, 8 Apr 2026 01:32:15 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
cc: Tatsuo Ishii <ishii@postgresql.org>, pgsql@j-davis.com,
        pgsql-hackers@lists.postgresql.org
Subject: Re: Do we still need MULE_INTERNAL?
In-reply-to: 
 <CA+hUKGJjnWaXfkkrgSLxWqxbb16x7W3PbKOvpL70yv9hNP=vVg@mail.gmail.com>
References: <20260401.083826.1947227822512469454.ishii@postgresql.org>
 <790a2e194c2d8cb03a2f1b8b580b64f25a5095b0.camel@j-davis.com>
 <20260402.075006.1215979483410908859.ishii@postgresql.org>
 <20260403.090640.487260902102768591.ishii@postgresql.org>
 <CA+hUKGJjnWaXfkkrgSLxWqxbb16x7W3PbKOvpL70yv9hNP=vVg@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@gmail.com>
	message dated "Wed, 08 Apr 2026 17:29:26 +1200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3000228.1775626335.1@sss.pgh.pa.us>
Date: Wed, 08 Apr 2026 01:32:15 -0400
Message-ID: <3000229.1775626335@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/3000229.1775626335%40sss.pgh.pa.us>
Precedence: bulk

Thomas Munro <thomas.munro@gmail.com> writes:
> Here's what I came up with for pg_upgrade.  It tests each database's
> encodings with PG_VALID_BE_ENCODING(), and looks like this when it
> fails:
> ...
> I'll wait a bit longer for this one, on the off chance of reviews at
> this late hour.

Passes a quick eyeball check, anyway.

			regards, tom lane